Lee's Feature Complete PDE
-
- Posts: 188
- Joined: Fri Dec 30, 2011 6:57 am
Re: Lee's Feature Complete PDE
Hi Lee, first off, your tank looks great!
I have a few questions about your code as I would like to borrow a section or two and incorporate it into my code. You have a lot of custom memory locations, variables defined, etc. that I probably won't need because they relate to your custom main screen, etc. and I don't want to add in stuff I don't need. I was wondering if you could help me select only what I would need for the following features that you use:
1. Custom feeding mode - I would want it just like you have it (minus the reactor control since I have mine off the return pump manifold). I would also like to delay the ATO port for 5 minutes instead of the skimmer... though I can figure that part out myself (just changing the port). But definitely want the VorTechs to Nutrient mode for 15 mins after.
2. Lighting Effects - Does this part give you cloud/lighting effects? Is it set for random or just on-demand via an app or something? I see you have the sun rise/set, moonphase, checkcloud stuff all in there, so I'm guessing you have some sort of storm effects coded in. This is where you have a lot of custom main screen stuff involved and I don't need that since I'm going to use the "2014Screen".
I also noticed that you were active in Colin's thread and talking about converting his "standard dimmer" code over to the expansion dimmer module. Any progress on that?
Any help would be appreciated! Thanks in advance.
I have a few questions about your code as I would like to borrow a section or two and incorporate it into my code. You have a lot of custom memory locations, variables defined, etc. that I probably won't need because they relate to your custom main screen, etc. and I don't want to add in stuff I don't need. I was wondering if you could help me select only what I would need for the following features that you use:
1. Custom feeding mode - I would want it just like you have it (minus the reactor control since I have mine off the return pump manifold). I would also like to delay the ATO port for 5 minutes instead of the skimmer... though I can figure that part out myself (just changing the port). But definitely want the VorTechs to Nutrient mode for 15 mins after.
2. Lighting Effects - Does this part give you cloud/lighting effects? Is it set for random or just on-demand via an app or something? I see you have the sun rise/set, moonphase, checkcloud stuff all in there, so I'm guessing you have some sort of storm effects coded in. This is where you have a lot of custom main screen stuff involved and I don't need that since I'm going to use the "2014Screen".
I also noticed that you were active in Colin's thread and talking about converting his "standard dimmer" code over to the expansion dimmer module. Any progress on that?
Any help would be appreciated! Thanks in advance.
Re: Lee's Feature Complete PDE
No progress on the clouds/lightning. That effects function isn't functional yet and none of my custom memory locations are for the screen drawing, though they do get used sometimes. You can replace any call to InternalMemory with a hard coded variable if it makes it easier for you.
Take a look at Sacohen's code for an easier post feeding mode function, but I think mine is pretty straight forward. If you take a stab at it we can debug in your INO thread.
Take a look at Sacohen's code for an easier post feeding mode function, but I think mine is pretty straight forward. If you take a stab at it we can debug in your INO thread.
-
- Posts: 188
- Joined: Fri Dec 30, 2011 6:57 am
Re: Lee's Feature Complete PDE
OK, thanks. I'll take a look at Steves code and see if that works for me.
In the meantime, I think I'll start my INO thread to show what I have and what I need help on. That might be the best way to go about it.
In the meantime, I think I'll start my INO thread to show what I have and what I need help on. That might be the best way to go about it.
Re: Lee's Feature Complete PDE
Very nice Lee. I love the music
No really, the tank looks incredible. Keep it up.
No really, the tank looks incredible. Keep it up.
Re: Lee's Feature Complete PDE
Thanks guys. Would not be doing this good without my RA!!!
-
- Posts: 188
- Joined: Fri Dec 30, 2011 6:57 am
- Rodasphoto
- Posts: 187
- Joined: Wed Apr 10, 2013 2:48 pm
- Location: Athens, Ga
- Contact:
Re: Lee's Feature Complete PDE
What does your BioHazard mode do? What does the custom waves mode accomplish?
Re: Lee's Feature Complete PDE
BioHazard mode was one of the attempts to replicate Else mode. It works pretty good.
The custom waves uses the RA modes instead of the Vortech built in functions. It also goes through a random mode each day if set to use the random mode.
The custom waves uses the RA modes instead of the Vortech built in functions. It also goes through a random mode each day if set to use the random mode.
- Rodasphoto
- Posts: 187
- Joined: Wed Apr 10, 2013 2:48 pm
- Location: Athens, Ga
- Contact:
Re: Lee's Feature Complete PDE
I want to redo the code I have programmed on my RA+ and want to borrow heavily on your code. I am in awe with you have done with your RA.lnevo wrote:BioHazard mode was one of the attempts to replicate Else mode. It works pretty good.
The custom waves uses the RA modes instead of the Vortech built in functions. It also goes through a random mode each day if set to use the random mode.
- Rodasphoto
- Posts: 187
- Joined: Wed Apr 10, 2013 2:48 pm
- Location: Athens, Ga
- Contact:
Re: Lee's Feature Complete PDE
Many thanks for the answers. I want to redo the code I have programmed on my RA+ and want to borrow heavily on your code. I am in awe with you have done with your RA.lnevo wrote:BioHazard mode was one of the attempts to replicate Else mode. It works pretty good.
The custom waves uses the RA modes instead of the Vortech built in functions. It also goes through a random mode each day if set to use the random mode.
Re: Lee's Feature Complete PDE
Wow, I haven't updated the code in this thread since January of 2013... I've certainly made a few tweaks here in there, but pretty incredible that I've been able to use the same code base for soooo long. Thanks to using memory for just about everything, I've been able to toggle and modify most every routine without needing new code. It's really only been minor tweaks for all this time. Anyway, page 1 is updated but in summary here are some features I've added this past go around
RF FeedingMode speed - override the vortech feeding mode and set a custom speed during feeding mode.
Acclimation code for dimming - Enahnced the acclimation so it can adjust the dimming % in addition to photoperiod.
Adjust alk manually (thanks AlanM) - Added a function I got from AlanM that lets you input the current alk measurement and dose the appropriate amount to get to your target amount.
Daily email report - Send an alert 2x a day since I rarely check on things so obsessively anymore
Light modes (select in memory which wavetype for lighting) - choose slope/parabola/sigmoid/slowramp
East/West offset dimming - Self explanatory I hope
Filll in gap from 5%->0% with moonlights - Extend the dimming past lights out with the moonlights for a smoother sunset routing
RF FeedingMode speed - override the vortech feeding mode and set a custom speed during feeding mode.
Acclimation code for dimming - Enahnced the acclimation so it can adjust the dimming % in addition to photoperiod.
Adjust alk manually (thanks AlanM) - Added a function I got from AlanM that lets you input the current alk measurement and dose the appropriate amount to get to your target amount.
Daily email report - Send an alert 2x a day since I rarely check on things so obsessively anymore
Light modes (select in memory which wavetype for lighting) - choose slope/parabola/sigmoid/slowramp
East/West offset dimming - Self explanatory I hope
Filll in gap from 5%->0% with moonlights - Extend the dimming past lights out with the moonlights for a smoother sunset routing
Re: Lee's Feature Complete PDE
Thanks for this great code Lee!
As a complete novis on ReefAngel its really valuable to check complex codes like this for reference. One question, what does the custom memory settings do?
//Jim
As a complete novis on ReefAngel its really valuable to check complex codes like this for reference. One question, what does the custom memory settings do?
//Jim
Re: Lee's Feature Complete PDE
The memory settings are basically persistent variables that let me change how things work on the fly without having to reupload a new program to the controller. In order to "save" them you have to assign them a memory location where it will be stored.
Re: Lee's Feature Complete PDE
Please expand. I'd like info on how to do these twoAdjust alk manually (thanks AlanM) - Added a function I got from AlanM that lets you input the current alk measurement and dose the appropriate amount to get to your target amount.
Daily email report - Send an alert 2x a day since I rarely check on things so obsessively anymore
Re: Lee's Feature Complete PDE
Both of these are in their own isolated functions so it should be easy to carry over.
This thread details the daily reminder mail
http://forum.reefangel.com/viewtopic.php?p=45678#p45678
The adjustAlk was a function I got from AlanM but I have not tested it yet. It's all in theory, but look for void adjustAlk() in my code and let me know what questions you have. It would have to be adapted to your tank and dosing regimen.
This thread details the daily reminder mail
http://forum.reefangel.com/viewtopic.php?p=45678#p45678
The adjustAlk was a function I got from AlanM but I have not tested it yet. It's all in theory, but look for void adjustAlk() in my code and let me know what questions you have. It would have to be adapted to your tank and dosing regimen.
Re: Lee's Feature Complete PDE
Thanks! I got the daily e-mails to work. Great tool... now working on:lnevo wrote:Both of these are in their own isolated functions so it should be easy to carry over.
This thread details the daily reminder mail
http://forum.reefangel.com/viewtopic.php?p=45678#p45678
The adjustAlk was a function I got from AlanM but I have not tested it yet. It's all in theory, but look for void adjustAlk() in my code and let me know what questions you have. It would have to be adapted to your tank and dosing regimen.
1. Change time from 0600/1800
2. Change contents of e-mail to include other info
3. Change title of e-mail. I'm so used to those e-mails meaning something is wrong!
Also going to start working with dosing.
Re: Lee's Feature Complete PDE
Can't change the title of the emajl unless roberto adds a parameter to the aspx script and then I'd have to add support in the class. Doable just needs work.
If you look at the function there is a 6 and a 12. The 12 is for every 12 hours and the 6 means start 6 hours from midnight. Feel free to change those numbers to your preference.
Other parameters should be easy to add just make sure the msg buffer will be large enough.
If you look at the function there is a 6 and a 12. The 12 is for every 12 hours and the 6 means start 6 hours from midnight. Feel free to change those numbers to your preference.
Other parameters should be easy to add just make sure the msg buffer will be large enough.
Re: Lee's Feature Complete PDE
Can you explain your memory use? How do you modify your memory? I assume you can from the RA memory in the app? Are they custom locations?
Re: Lee's Feature Complete PDE
Yes. Custom locations. I use the direct http calls to modify them or a web page form I have created. The RA app does not currently have a way to change custom memory locations. I believe the android one does. I try to use memory rather than hardcoding so I can modify everything on the fly without recompiling. I've gone about a year or so without any major modifications thanks to this.
Re: Lee's Feature Complete PDE
I didn't see it listed here so i thought i would ask, do you run any cloud and lightning code along with your sun location code? I am hoping to be able to incorporate both.
Re: Lee's Feature Complete PDE
Not yet. The SunLocation is used to get the date/time for your main LED schedule. I haven't looked closely at the cloud/lightnign code yet, but I believe you still need to set manually your lighting schedule. The SunLocation class will set the schedule in Memory if you're using Internal Memory today.
Re: Lee's Feature Complete PDE
Roberto,
I can no longer post my code. It's > 60,000 characters. I'm at 69k
I can no longer post my code. It's > 60,000 characters. I'm at 69k
Re: Lee's Feature Complete PDE
67504 characters, 5338 words, 1915 lines of code.
Re: Lee's Feature Complete PDE
I use the sunclass in my code as well as cloud and lighting....not sure of the link but check out my code.MDB1029 wrote:I didn't see it listed here so i thought i would ask, do you run any cloud and lightning code along with your sun location code? I am hoping to be able to incorporate both.
Sent from my Samsung Galaxy Note 3