help with menu

Do you have a question on how to do something.
Ask in here.
Post Reply
rossbryant1956
Posts: 471
Joined: Sat Jan 14, 2012 2:08 pm
Location: Montgomery Village, MD

help with menu

Post by rossbryant1956 »

I am having problems getting my menu to work. Please help. My snipped code is as follows:

Code: Select all

 // Custom Menu
    #include <avr/pgmspace.h>
    prog_char menu0_label[] PROGMEM = "Turn Lights On";
    prog_char menu1_label[] PROGMEM = "Turn Lights Off";
    prog_char menu2_label[] PROGMEM = "Start Feeding";
    prog_char menu3_label[] PROGMEM = "Start Water Change";
    prog_char menu4_label[] PROGMEM = "Clear Overheat";
    prog_char menu5_label[] PROGMEM = "Calibrate pH";
    prog_char menu6_label[] PROGMEM = "Calibrate Salinity";
    PROGMEM const char *menu_items[] = {
    menu0_label, menu1_label, menu2_label, menu3_label, menu4_label, menu5_label, menu6_label  };

    void MenuEntry1()
    {
    ReefAngel.DisplayMenuEntry("Item 1");ReefAngel.Relay.RelayMaskOn = ReefAngel.LightsOnPorts;
    #ifdef RelayExp
    for ( byte i = 0; i < MAX_RELAY_EXPANSION_MODULES; i++ )
    {
        ReefAngel.Relay.RelayMaskOnE[i] = ReefAngel.LightsOnPortsE[i];
    }
    #endif  // RelayExp
    ReefAngel.Relay.Write();

    }
    void MenuEntry2()
    {
    ReefAngel.DisplayMenuEntry("Item 2");ReefAngel.Relay.RelayMaskOn = 0;
    #ifdef RelayExp
    for ( byte i = 0; i < MAX_RELAY_EXPANSION_MODULES; i++ )
    {
        ReefAngel.Relay.RelayMaskOnE[i] = 0;
    }
    #endif  // RelayExp
    ReefAngel.Relay.Write();

    }
    void MenuEntry3()
    {
    ReefAngel.DisplayMenuEntry("Item 3");ReefAngel.FeedingModeStart();

    }
    void MenuEntry4()
    {
    ReefAngel.DisplayMenuEntry("Item 4");ReefAngel.WaterChangeModeStart();

    }
    void MenuEntry5()
    {
    ReefAngel.DisplayMenuEntry("Item 5");ReefAngel.OverheatClear();

    }
    void MenuEntry6()
    {
    ReefAngel.DisplayMenuEntry("Item 6");ReefAngel.SetupCalibratePH();
    ReefAngel.DisplayedMenu = ALT_SCREEN_MODE;

    }
    void MenuEntry7()
    {
    ReefAngel.DisplayMenuEntry("Item 7");ReefAngel.SetupCalibrateSalinity();
    }
    
    // End Custom Menu Globals

    // Define Relay Ports by Name
    #define DT_LightsOne       1
    #define DT_LightsTwo       2
    #define Unused3            3
    #define Unused4            4
    #define DT_LWM             5
    #define GT_LWM             6
    #define Unused7            7
    #define Unused8            8

    #define Unused11           Box1_Port1
    #define Unused12           Box1_Port2
    #define GT_LightsOne       Box1_Port3
    #define GT_LightsTwo       Box1_Port4
    #define DT_RWM             Box1_Port5
    #define GT_RWM             Box1_Port6
    #define DT_Heat            Box1_Port7
    #define DT_Pump            Box1_Port8
    
    #define RV_Heat            Box2_Port1
    #define RV_Pump            Box2_Port2
    #define GT_Heat            Box2_Port3
    #define Unused24           Box2_Port4
    #define GT_OverFill        Box2_Port5
    #define GT_Fill            Box2_Port6
    #define Skimmer            Box2_Port7
    #define GT_Pump            Box2_Port8

   
   
    void setup() {
        ReefAngel.Init();  //Initialize controller
        ReefAngel.InitMenu(pgm_read_word(&(menu_items[0])),SIZE(menu_items)); // Initialize the menu
        ReefAngel.FeedingModePortsE[0] = Port8Bit; // Turn off on Box1 when feeding mode is activated is activated
        ReefAngel.FeedingModePortsE[1] = Port7Bit | Port8Bit; // Turn off on Box2 when feeding mode is activated is activated
        ReefAngel.WaterChangePorts = Port5Bit | Port6Bit ; // Turn off when water change mode is activated
        ReefAngel.WaterChangePortsE[0] = Port5Bit | Port6Bit | Port7Bit | Port8Bit; // Turn off on Box1 when water change mode is activated
        ReefAngel.WaterChangePortsE[1] = Port3Bit | Port8Bit | Port7Bit | Port6Bit | Port1Bit; // Turn off on Box1 when water change mode is activated
        ReefAngel.PHExpMin = 1832;
        ReefAngel.PHExpMax = 2150;
        ReefAngel.TempProbe = T2_PROBE;  // Set the 2nd plug to be DT Main temp
        ReefAngel.OverheatProbe = T2_PROBE;  // to monitor the overheat and temperatures
        ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit;  // Items turned off when Overheat temperature exceeded
        ReefAngel.OverheatShutoffPortsE[0] = Port7Bit | Port3Bit | Box1_Port4;  // Items turned off on Box1 when Overheat temperature exceeded
        ReefAngel.OverheatShutoffPortsE[1] = Port3Bit | Port7Bit;  // Items turned off on Box2 when Overheat temperature exceeded
        InternalMemory.OverheatTemp_write( 829 ); // Set the DT Overheat temperature setting
        ReefAngel.LightsOnPorts = Port1Bit | Port2Bit; // Toggle Lights
        ReefAngel.LightsOnPortsE[0] = Port3Bit | Port4Bit; // Toggle Lights  
  
   // Ports that default on
        ReefAngel.Relay.On(DT_Pump); // Turn on DT Pump
        ReefAngel.Relay.On(GT_Pump); // Turn on GT Pump   
        ReefAngel.Relay.On(Skimmer); // Turn on Skimmer
    }
    void loop()
    {

       // CheckPower();           // Monitor for power outages
       // CheckSwitches();        // Monitor for float switches  
  
        ReefAngel.StandardLights( DT_LightsOne,14,00,22,00 ); // DT Lights on at 2:00pm and off at 10:00pm
        ReefAngel.StandardLights( DT_LightsTwo,22,00,01,00 ); // DT-Moon Lights on at 10:00am and off at 1:00am
        ReefAngel.StandardLights( GT_LightsOne,14,00,21,45 );  //GT Lights Main 2:00pm - 9:45pm
        ReefAngel.StandardLights( GT_LightsTwo,15,00,22,30 ); //GT Lights Actinic 3:00pm - 10:30pm
     
What am I doing wrong? Thx in advance!!
Roscoe's Reefs - Starting Over Again:

Building new 29g Nano after landlord went berserk over my 4 75 gallon tanks, Multiple RA's, Water mixing stations, etc. Your help welcomed in remembering all I've forgotten.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: help with menu

Post by rimai »

What's it doing or not doing?
Looks like you didn't paste the entire code.
Roberto.
rossbryant1956
Posts: 471
Joined: Sat Jan 14, 2012 2:08 pm
Location: Montgomery Village, MD

Re: help with menu

Post by rossbryant1956 »

sorry, When I press the buttons on the RA, it doesn't turn the lights on or off. Here is the code:

Code: Select all

   #include <ReefAngel_Features.h>
    #include <Globals.h>
    #include <RA_Wifi.h>
    #include <Wire.h>
    #include <OneWire.h>
    #include <Time.h>
    #include <ORP.h>
    #include <DS1307RTC.h>
    #include <InternalEEPROM.h>
    #include <RA_NokiaLCD.h>
    #include <RA_ATO.h>
    #include <RA_Joystick.h>
    #include <LED.h>
    #include <RA_TempSensor.h>
    #include <RA_Colors.h>
    #include <RA_CustomColors.h>
    #include <Relay.h>
    #include <RA_PWM.h>
    #include <Timer.h>
    #include <Memory.h>
    #include <IO.h>
    #include <Salinity.h>
    #include <PH.h>
    #include <WiFiAlert.h>
    #include <ReefAngel.h>
    
     // Globals for Params on Custom Main
    byte x,y;
    char text[10];
    
    // Define Custom Variables for Portal
    
    // Custom Menu
    #include <avr/pgmspace.h>
    prog_char menu0_label[] PROGMEM = "Turn Lights On";
    prog_char menu1_label[] PROGMEM = "Turn Lights Off";
    prog_char menu2_label[] PROGMEM = "Start Feeding";
    prog_char menu3_label[] PROGMEM = "Start Water Change";
    prog_char menu4_label[] PROGMEM = "Clear Overheat";
    prog_char menu5_label[] PROGMEM = "Calibrate pH";
    prog_char menu6_label[] PROGMEM = "Calibrate Salinity";
    PROGMEM const char *menu_items[] = {
    menu0_label, menu1_label, menu2_label, menu3_label, menu4_label, menu5_label, menu6_label  };

    void MenuEntry1()
    {
    ReefAngel.DisplayMenuEntry("Item 1");ReefAngel.Relay.RelayMaskOn = ReefAngel.LightsOnPorts;
    #ifdef RelayExp
    for ( byte i = 0; i < MAX_RELAY_EXPANSION_MODULES; i++ )
    {
        ReefAngel.Relay.RelayMaskOnE[i] = ReefAngel.LightsOnPortsE[i];
    }
    #endif  // RelayExp
    ReefAngel.Relay.Write();

    }
    void MenuEntry2()
    {
    ReefAngel.DisplayMenuEntry("Item 2");ReefAngel.Relay.RelayMaskOn = 0;
    #ifdef RelayExp
    for ( byte i = 0; i < MAX_RELAY_EXPANSION_MODULES; i++ )
    {
        ReefAngel.Relay.RelayMaskOnE[i] = 0;
    }
    #endif  // RelayExp
    ReefAngel.Relay.Write();

    }
    void MenuEntry3()
    {
    ReefAngel.DisplayMenuEntry("Item 3");ReefAngel.FeedingModeStart();

    }
    void MenuEntry4()
    {
    ReefAngel.DisplayMenuEntry("Item 4");ReefAngel.WaterChangeModeStart();

    }
    void MenuEntry5()
    {
    ReefAngel.DisplayMenuEntry("Item 5");ReefAngel.OverheatClear();

    }
    void MenuEntry6()
    {
    ReefAngel.DisplayMenuEntry("Item 6");ReefAngel.SetupCalibratePH();
    ReefAngel.DisplayedMenu = ALT_SCREEN_MODE;

    }
    void MenuEntry7()
    {
    ReefAngel.DisplayMenuEntry("Item 7");ReefAngel.SetupCalibrateSalinity();
    }
    
    // End Custom Menu Globals

    // Define Relay Ports by Name
    #define DT_LightsOne       1
    #define DT_LightsTwo       2
    #define Unused3            3
    #define Unused4            4
    #define DT_LWM             5
    #define GT_LWM             6
    #define Unused7            7
    #define Unused8            8

    #define Unused11           Box1_Port1
    #define Unused12           Box1_Port2
    #define GT_LightsOne       Box1_Port3
    #define GT_LightsTwo       Box1_Port4
    #define DT_RWM             Box1_Port5
    #define GT_RWM             Box1_Port6
    #define DT_Heat            Box1_Port7
    #define DT_Pump            Box1_Port8
    
    #define RV_Heat            Box2_Port1
    #define RV_Pump            Box2_Port2
    #define GT_Heat            Box2_Port3
    #define Unused24           Box2_Port4
    #define GT_OverFill        Box2_Port5
    #define GT_Fill            Box2_Port6
    #define Skimmer            Box2_Port7
    #define GT_Pump            Box2_Port8

   
   
    void setup() {
        ReefAngel.Init();  //Initialize controller
        ReefAngel.InitMenu(pgm_read_word(&(menu_items[0])),SIZE(menu_items)); // Initialize the menu
        ReefAngel.FeedingModePortsE[0] = Port8Bit; // Turn off on Box1 when feeding mode is activated is activated
        ReefAngel.FeedingModePortsE[1] = Port7Bit | Port8Bit; // Turn off on Box2 when feeding mode is activated is activated
        ReefAngel.WaterChangePorts = Port5Bit | Port6Bit ; // Turn off when water change mode is activated
        ReefAngel.WaterChangePortsE[0] = Port5Bit | Port6Bit | Port7Bit | Port8Bit; // Turn off on Box1 when water change mode is activated
        ReefAngel.WaterChangePortsE[1] = Port3Bit | Port8Bit | Port7Bit | Port6Bit | Port1Bit; // Turn off on Box1 when water change mode is activated
        ReefAngel.PHExpMin = 1832;
        ReefAngel.PHExpMax = 2150;
        ReefAngel.TempProbe = T2_PROBE;  // Set the 2nd plug to be DT Main temp
        ReefAngel.OverheatProbe = T2_PROBE;  // to monitor the overheat and temperatures
        ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit;  // Items turned off when Overheat temperature exceeded
        ReefAngel.OverheatShutoffPortsE[0] = Port7Bit | Port3Bit | Box1_Port4;  // Items turned off on Box1 when Overheat temperature exceeded
        ReefAngel.OverheatShutoffPortsE[1] = Port3Bit | Port7Bit;  // Items turned off on Box2 when Overheat temperature exceeded
        InternalMemory.OverheatTemp_write( 829 ); // Set the DT Overheat temperature setting
        ReefAngel.LightsOnPorts = Port1Bit | Port2Bit; // Toggle Lights
        ReefAngel.LightsOnPortsE[0] = Port3Bit | Port4Bit; // Toggle Lights  
  
   // Ports that default on
        ReefAngel.Relay.On(DT_Pump); // Turn on DT Pump
        ReefAngel.Relay.On(GT_Pump); // Turn on GT Pump   
        ReefAngel.Relay.On(Skimmer); // Turn on Skimmer
    }
    void loop()
    {

       // CheckPower();           // Monitor for power outages
       // CheckSwitches();        // Monitor for float switches  
  
        ReefAngel.StandardLights( DT_LightsOne,14,00,22,00 ); // DT Lights on at 2:00pm and off at 10:00pm
        ReefAngel.StandardLights( DT_LightsTwo,22,00,01,00 ); // DT-Moon Lights on at 10:00am and off at 1:00am
        ReefAngel.StandardLights( GT_LightsOne,14,00,21,45 );  //GT Lights Main 2:00pm - 9:45pm
        ReefAngel.StandardLights( GT_LightsTwo,15,00,22,30 ); //GT Lights Actinic 3:00pm - 10:30pm
        ReefAngel.WavemakerRandom( DT_LWM,60,100 );
        ReefAngel.Relay.Set( DT_RWM, !ReefAngel.Relay.Status( DT_LWM ) ); //Randomize DT powerheads
        ReefAngel.WavemakerRandom1( GT_LWM,60,100 );
        ReefAngel.Relay.Set( GT_RWM, !ReefAngel.Relay.Status( GT_LWM ) ); //Randomize GT powerheads
        StandardHeater1( DT_Heat,779,791 ); //DT-Heat
        StandardHeater2( GT_Heat,779,791 ); //GT-Heat 
    
            
       // if the hour is 2p or 8p, minute is 55 and seconds is 0, start the feeding mode
          if ( ((hour() == 14) || (hour() == 20)) &&
          (minute() == 55) &&
          (second() == 0) )
          {
          ReefAngel.FeedingModeStart();
          }   
        
          if (hour()>=1 && hour()<6)  // Turn on Reservoir Pump
          ReefAngel.Relay.On(RV_Pump);
          else
          ReefAngel.Relay.Off(RV_Pump); 
  
        // turn on RV_Heat when temp falls below 76.0 and turn off when temp gets above 80.0
        if (ReefAngel.Params.Temp[T3_PROBE] <= 780 && ReefAngel.Params.Temp[T3_PROBE] > 0) ReefAngel.Relay.On(RV_Heat); 
        if (ReefAngel.Params.Temp[T3_PROBE] >= 791) ReefAngel.Relay.Off(RV_Heat);     
       
  // I_O Expansion & Float Valves
  
       //    ReefAngel.CustomVar[7]=1;
  
        //turn off DT pump when switch is tripped and sound buzzer
           ReefAngel.Relay.Set(DT_Pump,ReefAngel.IO.GetChannel(0));
           ReefAngel.PWM.SetDaylight(100-(ReefAngel.IO.GetChannel(0)*100));
           ReefAngel.CustomVar[0]=ReefAngel.IO.GetChannel(0); //tell the portal we have a overflow problem
       
        //turn off GT pump when switch is tripped and sound buzzer
           ReefAngel.Relay.Set(GT_Pump,ReefAngel.IO.GetChannel(1));
           ReefAngel.PWM.SetDaylight(100-(ReefAngel.IO.GetChannel(1)*100));
           ReefAngel.CustomVar[1]=ReefAngel.IO.GetChannel(1); //tell the portal we have a overflow problem 
         
       //turn on GT Fill when switch is tripped 
           static time_t LastATO=millis();
           if (!ReefAngel.IO.GetChannel(2)) LastATO=millis();
           if (millis()-LastATO<5000 && millis()-LastATO>100)
           ReefAngel.Relay.Off(GT_Fill);
           else
           ReefAngel.SingleATO(true,GT_Fill,10,0);
            
       //   ReefAngel.Relay.Set(GT_Fill,ReefAngel.IO.GetChannel(2));
       //   ReefAngel.PWM.SetDaylight(100-(ReefAngel.IO.GetChannel(2)*100)); 
           
        //turn off GT OverFill when switch is tripped and sound buzzer
      //     ReefAngel.Relay.Set(GT_OverFill,ReefAngel.IO.GetChannel(3));
      //     ReefAngel.PWM.SetDaylight(100-(ReefAngel.IO.GetChannel(3)*100));
      //     ReefAngel.CustomVar[2]=ReefAngel.IO.GetChannel(3); //tell the portal we have a overflow problem
           
    // Dosing Pumps       
         
        //set up dosing pump one to run twice a week for 4 minutes
         //ReefAngel.Relay.Set(Box1_Port2,((weekday()==1||weekday()==4) && hour()==14 && minute()<6));
         //ReefAngel.Relay.Set (Box1_Port3,(hour()%2==0)); //stir chemicals in water top off unit

         ReefAngel.ShowInterface();
         // ReefAngel.Params.ORP=ReefAngel.PH.Read();
         ReefAngel.Portal("rossbryant1956");
    }

     void StandardHeater1(byte HeaterRelay, int LowTemp, int HighTemp)
        {
        if (ReefAngel.Params.Temp[T2_PROBE] == 0) return; // Don't turn the heater on if the temp is reading 0
        if (ReefAngel.Params.Temp[T2_PROBE] <= LowTemp && ReefAngel.Params.Temp[T2_PROBE] > 0) ReefAngel.Relay.On(HeaterRelay); // If sensor 2 temperature <= LowTemp - turn on heater
        if (ReefAngel.Params.Temp[T2_PROBE] >= HighTemp) ReefAngel.Relay.Off(HeaterRelay); // If sensor 2 temperature >= HighTemp - turn off heater
        }


   void StandardHeater2(byte HeaterRelay, int LowTemp, int HighTemp) //Heater for Grow Tank
    {
        if (ReefAngel.Params.Temp[T1_PROBE] == 0) return;  // Don't turn the heater on if the temp is reading 0
        if (ReefAngel.Params.Temp[T1_PROBE] <= LowTemp && ReefAngel.Params.Temp[T1_PROBE] > 0) ReefAngel.Relay.On(HeaterRelay);  // If sensor temperature <= LowTemp - turn on heater
        if (ReefAngel.Params.Temp[T1_PROBE] >= HighTemp) ReefAngel.Relay.Off(HeaterRelay);  // If sensor temperature >= HighTemp - turn off heater
    }
       
    void DrawCustomMain()
    {
      int x,y; 
      char text[7];
      
      // Date and Time
      ReefAngel.LCD.DrawDate( 6, 122 );  //6 pixels left, 122 lines down
      pingSerial();
      
      // I/O Expansion
      byte bkcolor;
      x = 14;
      y = 11;
      for ( int a=0;a<6;a++ )
      {
      ReefAngel.LCD.DrawCircleOutline( x+(a*20),y,4,COLOR_MEDIUMORCHID );
      if ( ReefAngel.IO.GetChannel(a) ) bkcolor=COLOR_WHITE; else bkcolor=COLOR_GRAY;
      ReefAngel.LCD.FillCircle( x+(a*20),y,2,bkcolor );
      }
      pingSerial();

      // Parameters
  
      ReefAngel.LCD.DrawText(0,255,18,26,"GT");  //18 left, 10 down
      ConvertNumToString(text, ReefAngel.Params.Temp[T1_PROBE], 10);
      ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 10, 37, text, Num8x8);
      pingSerial();

      ReefAngel.LCD.DrawText(0,255,57,26,"DT"); //57 left, 10 down
      ConvertNumToString(text, ReefAngel.Params.Temp[T2_PROBE], 10);
      ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 50, 37, text, Num8x8);
      pingSerial();
      
      ReefAngel.LCD.DrawText(0,255,94,26,"Res"); //94 left, 10 down
      ConvertNumToString(text, ReefAngel.Params.Temp[T3_PROBE], 10);
      ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 90, 37, text, Num8x8);
      pingSerial();

      ReefAngel.LCD.DrawText(0,255,16,52,"DT pH"); //18 left, 39 down
      ConvertNumToString(text, ReefAngel.Params.PH, 100);
      ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 15, 65, text, Num8x8);
      pingSerial();

      ReefAngel.LCD.DrawText( 0,255,57,52, "GT pH"); //57 left, 39 down
      ConvertNumToString(text, ReefAngel.Params.PHExp, 100);
      ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 55, 65, text, Num8x8);
      pingSerial();

      ReefAngel.LCD.DrawText(0,255,100,52,"Sal"); //100 left, 39 down
      ConvertNumToString(text, ReefAngel.Params.Salinity, 10);
      ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 98, 65, text, Num8x8);
      pingSerial();

      // Main Relay Box
      byte TempRelay = ReefAngel.Relay.RelayData;
      TempRelay &= ReefAngel.Relay.RelayMaskOff;
      TempRelay |= ReefAngel.Relay.RelayMaskOn;
      ReefAngel.LCD.DrawOutletBox( 12, 80, TempRelay );
      pingSerial();

       // Relay Expansion
      TempRelay = ReefAngel.Relay.RelayDataE[0];
      TempRelay &= ReefAngel.Relay.RelayMaskOffE[0];
      TempRelay |= ReefAngel.Relay.RelayMaskOnE[0];
      ReefAngel.LCD.DrawOutletBox( 12, 93, TempRelay );
      pingSerial();  
      
      // Relay Expansion
      TempRelay = ReefAngel.Relay.RelayDataE[1];
      TempRelay &= ReefAngel.Relay.RelayMaskOffE[1];
      TempRelay |= ReefAngel.Relay.RelayMaskOnE[1];
      ReefAngel.LCD.DrawOutletBox( 12, 107, TempRelay );
      pingSerial();  
    }

    void DrawCustomGraph()
    {
    // ReefAngel.LCD.DrawGraph( 5, 5 );
    }
Roscoe's Reefs - Starting Over Again:

Building new 29g Nano after landlord went berserk over my 4 75 gallon tanks, Multiple RA's, Water mixing stations, etc. Your help welcomed in remembering all I've forgotten.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: help with menu

Post by rimai »

Works for me here
Roberto.
Post Reply