Can't get weather code working

Do you have a question on how to do something.
Ask in here.
Post Reply
dlplunkett44
Posts: 74
Joined: Mon Aug 05, 2013 3:16 am

Can't get weather code working

Post by dlplunkett44 »

I'm trying to get the clouds and lightning code working but I am getting the following errors:

sketch_mar01a.cpp:207:5: error: invalid preprocessing directive #PWMExpansion
sketch_mar01a.cpp: In function 'void CheckCloud()':
sketch_mar01a:391: error: a function-definition is not allowed here before '{' token
sketch_mar01a:401: error: expected `}' at end of input
sketch_mar01a:401: error: expected `}' at end of input
sketch_mar01a:401: error: expected `}' at end of input
sketch_mar01a:401: error: expected `}' at end of input

Code: Select all

/*

 To be able to use the custom main screen and PWM Expansion, please make sure that you enabled custom main screen and pwm expansion on your features file.
 Open RAGen and make sure you have Custom Main Screen and PWM Expansion checked under the Features tab.

 Or, you can manually edit the file.
 The file is located at "Documents\Arduino\libraries\ReefAngel_Features.h" file and has to include this line in it:

 #define CUSTOM_MAIN
 #define PWMEXPANSION

 */

/* The following features are enabled for this PDE File:
#define DisplayImages
#define WavemakerSetup
#define DateTimeSetup
#define VersionMenu
#define DirectTempSensor
#define DisplayLEDPWM
#define StandardLightSetup
#define PWMEXPANSION
*/

//*********************************************************************************************************************************
//Start of PWM Expansion Code Header

// This is just how we are going to reference the PWM expansion ports within the code.
// You can change the labels if you would like, just as long as they are changed all throughout the code too.
#define LEDPWM0 0
#define LEDPWM1 1
#define LEDPWM2 2
#define LEDPWM3 3
#define LEDPWM4 4
#define LEDPWM5 5

// Initial values to all 6 channels at startup. They will always be 0.
byte PWMChannel[]={
  0,0,0,0,0,0};
//byte cloudchance=0;
//byte cloudduration=0;
//int cloudstart=0;
//End of PWM Expansion Code Header
//********************************************************************************************************************************

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <ReefAngel.h>
#include <avr/wdt.h>


void DrawCustomMain()
{
  ReefAngel.LCD.DrawDate(6, 112);
  pingSerial();
  ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15, 10, "T1:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T1_PROBE], T1TempColor, 15+18, 10, 10);
  ReefAngel.LCD.DrawText(T2TempColor, DefaultBGColor, 15, 10+10, "T2:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], T2TempColor, 15+18, 10+10, 10);
  ReefAngel.LCD.DrawText(T3TempColor, DefaultBGColor, 15, 10+20, "T3:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T3_PROBE], T3TempColor, 15+18, 10+20, 10);
  ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+60, 10, "PH:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.PH, PHColor, 15+78, 10, 100);

  //ATO status
  ReefAngel.LCD.DrawText(DefaultFGColor, DefaultBGColor, 15+60, 10+20, "Pump:");

  byte highcolor;
  char highstatus[10];

  if ( ReefAngel.HighATO.IsActive() )
    {
       ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+90, 10+20, "ON ");
    }
  else
    {
       ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15+90, 10+20, "OFF");
    }
  //End ATO status
  pingSerial();
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 95, TempRelay);
  //ReefAngel.LCD.DrawOutletBox(12, 35, TempRelay);

  ReefAngel.LCD.DrawText(0,255,15,52,"RB:");
  ReefAngel.LCD.DrawText(0,255,15,62,"BB:");
  ReefAngel.LCD.DrawText(0,255,15,72,"CW:");
  ReefAngel.LCD.DrawText(0,255,15,82,"WW:");
  ReefAngel.LCD.DrawText(0,255,15+20,52,PWMChannel[LEDPWM0]);
  ReefAngel.LCD.DrawText(0,255,15+20,62,PWMChannel[LEDPWM1]);
  ReefAngel.LCD.DrawText(0,255,15+20,72,PWMChannel[LEDPWM2]);
  ReefAngel.LCD.DrawText(0,255,15+20,82,PWMChannel[LEDPWM3]);

  ReefAngel.LCD.DrawText(0,255,15+60,52,"CC:");
  ReefAngel.LCD.DrawText(0,255,15+60,62,"CD:");
  ReefAngel.LCD.DrawText(0,255,15+60,72,"CS:");
 // ReefAngel.LCD.DrawText(0,255,15+80,52,cloudchance);
 // ReefAngel.LCD.DrawText(0,255,15+80,62,cloudduration);
 // ReefAngel.LCD.DrawText(0,255,15+80,72,cloudstart/60);
}

void DrawCustomGraph()
{

}

////// Place global variable code below here



////// Place global variable code above here 
void setup() {
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port3Bit | Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = 0;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port3Bit | Port7Bit;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 850 );
    // Ports that are always on
    ReefAngel.Relay.On( Port2 );
    ReefAngel.Relay.On( Port4 );
    ReefAngel.Relay.On( Port5 );
    ReefAngel.Relay.On( Port6 );

    //Port 1 = ATO
    //Port 2 = Always On
    //Port 3 = Heater
    //Port 4 = Main Pump
    //Port 5 = Wavemaker
    //Port 6 = Wavemaker
    //Port 7 = Sump Light
    //Port 8 = Feeder Relay


////// Place additional initialization code below here
   
   



    ////// Place additional initialization code above here 
  }

void loop()
{
    ReefAngel.StandardHeater( Port3,820,825 );
    ReefAngel.StandardLights( Port7,21,0,7,0 );
    ReefAngel.SingleATO( true,Port1,180,0 );
    ReefAngel.WavemakerRandom(Port5,15,45);
    ReefAngel.WavemakerRandom1(Port6,15,45);
   
    ////// Place your custom code below here
 
static unsigned long feeding = 0;
if ((now()%SECS_PER_DAY==28800) || (now()%SECS_PER_DAY==50400) || (now()%SECS_PER_DAY==72000)) //if it is 8am or 2pm or 8 pm { ReefAngel.FeedingModeStart(); //START FEEDING MODE } if (ReefAngel.DisplayedMenu==FEEDING_MODE)
{
if ( feeding == 0 )
{
feeding = now(); //set the time of the start of feeding to variable feeding } if ((now()-feeding>=60) && (now()-feeding<=61)) //if between 60 and 61 seconds has past { ReefAngel.Relay.On(Port8); //TURN FEEDER RELAY ON } else { ReefAngel.Relay.Off(Port8); //TURN FEEDER RELAY OFF } } else { if ( feeding > 0 ) { feeding = 0; } }

    }
   #PWMExpansion

  // Calculate your regular sunrise/sunset PWM value
  PWMChannel[LEDPWM0]=PWMSlope(10,30,22,00,0,50,240,PWMChannel[LEDPWM0]);
  PWMChannel[LEDPWM1]=PWMSlope(10,00,22,15,0,55,240,PWMChannel[LEDPWM1]);
  PWMChannel[LEDPWM2]=PWMSlope(11,0,21,30,0,45,240,PWMChannel[LEDPWM2]);
  PWMChannel[LEDPWM3]=PWMSlope(11,30,20,00,0,50,240,PWMChannel[LEDPWM3]);
  CheckCloud();
  //PWMExpansion(LEDPWM0,int(2.55*PWMChannel[LEDPWM0]));
  //PWMExpansion(LEDPWM1,int(2.55*PWMChannel[LEDPWM1]));
  //PWMExpansion(LEDPWM2,int(2.55*PWMChannel[LEDPWM2]));
  //PWMExpansion(LEDPWM3,int(2.55*PWMChannel[LEDPWM3]));
  //ReefAngel.LCD.DrawText(0,255,5,120,PWMChannel[LEDPWM0]);
  //ReefAngel.LCD.DrawText(0,255,35,120,PWMChannel[LEDPWM1]);
  //ReefAngel.LCD.DrawText(0,255,65,120,PWMChannel[LEDPWM2]);
  //ReefAngel.LCD.DrawText(0,255,95,120,PWMChannel[LEDPWM3]);





    ////// Place your custom code above here
    // This should always be the last line
    ReefAngel.AddWifi();
    ReefAngel.ShowInterface();
}




}
//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function 
void CheckCloud() {

 // ------------------------------------------------------------
 // Change the values below to customize your cloud/storm effect

 // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)  
 // For testing purposes, you can use 1 and cause the cloud to occur everyday 
 #define Clouds_Every_X_Days 1

 // Percentage chance of a cloud happening today  
 // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening 
 #define Cloud_Chance_per_Day 100

 // Minimum number of minutes for cloud duration. Don't use max duration of less than 6 
 #define Min_Cloud_Duration 7

 // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255 
 #define Max_Cloud_Duration 15

 // Minimum number of clouds that can happen per day 
 #define Min_Clouds_per_Day 3

 // Maximum number of clouds that can happen per day 
 #define Max_Clouds_per_Day 5

 // Only start the cloud effect after this setting  
 // In this example, start could after 11:30am 
 #define Start_Cloud_After NumMins(11,30)

 // Always end the cloud effect before this setting  
 // In this example, end could before 8:00pm 
 #define End_Cloud_Before NumMins(18,30)

 // Percentage chance of a lightning happen for every cloud  
 // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening 
 #define Lightning_Change_per_Cloud 100

 // Channels used by the actinic LEDs on the PWM Expansion module  
 // These channels will not be dimmed when the cloud effect is triggered  
 // Number is a binary form. B001100 means channel 2 and 3 are used for actinics 
 #define Actinic_Channels B000001

 // Channels used by the daylight LEDs on the PWM Expansion module  
 // These channels will be used for the spike when lightning effect is triggered  
 // Number is a binary form. B000011 means channel 0 and 1 are used for daylights 
 #define Daylight_Channels B000010

 // Note: Make sure to choose correct values that will work within your PWMSLope settings.
 // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
 // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
 // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
 // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
 // It's a tight fit, but it did.

 //#define printdebug 
 // Uncomment this for debug print on Serial Monitor window  
 #define forcecloudcalculation 
 // Uncomment this to force the cloud calculation to happen in the boot process.


 // Change the values above to customize your cloud/storm effect  
 // ------------------------------------------------------------
 // Do not change anything below here

 static byte cloudchance=255;
 static byte cloudduration=0;
 static int cloudstart=0;
 static byte numclouds=0;
 static byte lightningchance=0;
 static byte cloudindex=0;
 static byte lightningstatus=0;
 static int LastNumMins=0;
 // Every day at midnight, we check for chance of cloud happening today  
 if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
 if (cloudchance==255)
#else
 if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
 #endif  
 {  //Pick a random number between 0 and 99  
 cloudchance=random(100);  
 // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today  
 if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;  
 // Check if today is day for clouds.
 if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;  
 // If we have cloud today  
 if (cloudchance)  
 {  
   // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day  
   numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
 // pick the time that the first cloud will start  
 // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
 cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  // Now that we have all the parameters for the cloud, let's create the effect

 if (cloudchance)
 {
 //is it time for cloud yet?
 if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
 {
 // let's go through all channels to pick which ones will be dimmed  
 for (int a=0;a<6;a++)  
 {  
   if (bitRead(Actinic_Channels,a)==0)  
   {  
     // this will slope down the channel from the current PWM to 0 within 3minutes.
 // then it will stay at 0 for the duration of the cycle  
 // and finally slope up from 0 to PWM value within 3 minutes  
 // it is basically an inversed slope  
 PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
 }
 }
 if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)  {  for (int b=0;b<6;b++)  {  if (bitRead(Daylight_Channels,b)==1)  {  if (random(100)<20) lightningstatus=1;  else lightningstatus=0;  if (lightningstatus) PWMChannel[b]=100;  else PWMChannel[b]=0;  //delay(10);  }  else  {  PWMChannel[b]=20;  }  }  }  }  if (NumMins(hour(),minute())>(cloudstart+cloudduration))
 {
 cloudindex++;
 if (cloudindex < numclouds)
 {
 cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  
 // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  }

 if (LastNumMins!=NumMins(hour(),minute()))
 {
 LastNumMins=NumMins(hour(),minute());
 ReefAngel.LCD.Clear(255,0,120,132,132);
 ReefAngel.LCD.DrawText(0,255,5,120,"C");
 ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
 ReefAngel.LCD.DrawText(0,255,45,120,"L");
 ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
 if (cloudchance && (NumMins(hour(),minute())<cloudstart))
 {
 int x=0;
 if ((cloudstart/60)>=10) x=11; else x=17;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
 if ((cloudstart%60)>=10) x=29; else x=35;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
 }
 ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
 if (lightningchance)
 {
 int x=0;
 if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
 if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
 }
 }
}
 

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
  //End Cloud & Lighting 
}




//*********************************************************************************************************************************
dlplunkett44
Posts: 74
Joined: Mon Aug 05, 2013 3:16 am

Re: Can't get weather code working

Post by dlplunkett44 »

Ok, i made some formatting adjustments and got rid of all but one error:

sketch_mar01a.cpp:206:5: error: invalid preprocessing directive #PWMExpansion


Here is my new code:

Code: Select all

/*

 To be able to use the custom main screen and PWM Expansion, please make sure that you enabled custom main screen and pwm expansion on your features file.
 Open RAGen and make sure you have Custom Main Screen and PWM Expansion checked under the Features tab.

 Or, you can manually edit the file.
 The file is located at "Documents\Arduino\libraries\ReefAngel_Features.h" file and has to include this line in it:

 #define CUSTOM_MAIN
 #define PWMEXPANSION

 */

/* The following features are enabled for this PDE File:
#define DisplayImages
#define WavemakerSetup
#define DateTimeSetup
#define VersionMenu
#define DirectTempSensor
#define DisplayLEDPWM
#define StandardLightSetup
#define PWMEXPANSION
*/

//*********************************************************************************************************************************
//Start of PWM Expansion Code Header

// This is just how we are going to reference the PWM expansion ports within the code.
// You can change the labels if you would like, just as long as they are changed all throughout the code too.
#define LEDPWM0 0
#define LEDPWM1 1
#define LEDPWM2 2
#define LEDPWM3 3
#define LEDPWM4 4
#define LEDPWM5 5

// Initial values to all 6 channels at startup. They will always be 0.
byte PWMChannel[]={
  0,0,0,0,0,0};
//byte cloudchance=0;
//byte cloudduration=0;
//int cloudstart=0;
//End of PWM Expansion Code Header
//********************************************************************************************************************************

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <ReefAngel.h>
#include <avr/wdt.h>


void DrawCustomMain()
{
  ReefAngel.LCD.DrawDate(6, 112);
  pingSerial();
  ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15, 10, "T1:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T1_PROBE], T1TempColor, 15+18, 10, 10);
  ReefAngel.LCD.DrawText(T2TempColor, DefaultBGColor, 15, 10+10, "T2:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], T2TempColor, 15+18, 10+10, 10);
  ReefAngel.LCD.DrawText(T3TempColor, DefaultBGColor, 15, 10+20, "T3:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T3_PROBE], T3TempColor, 15+18, 10+20, 10);
  ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+60, 10, "PH:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.PH, PHColor, 15+78, 10, 100);

  //ATO status
  ReefAngel.LCD.DrawText(DefaultFGColor, DefaultBGColor, 15+60, 10+20, "Pump:");

  byte highcolor;
  char highstatus[10];

  if ( ReefAngel.HighATO.IsActive() )
    {
       ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+90, 10+20, "ON ");
    }
  else
    {
       ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15+90, 10+20, "OFF");
    }
  //End ATO status
  pingSerial();
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 95, TempRelay);
  //ReefAngel.LCD.DrawOutletBox(12, 35, TempRelay);

  ReefAngel.LCD.DrawText(0,255,15,52,"RB:");
  ReefAngel.LCD.DrawText(0,255,15,62,"BB:");
  ReefAngel.LCD.DrawText(0,255,15,72,"CW:");
  ReefAngel.LCD.DrawText(0,255,15,82,"WW:");
  ReefAngel.LCD.DrawText(0,255,15+20,52,PWMChannel[LEDPWM0]);
  ReefAngel.LCD.DrawText(0,255,15+20,62,PWMChannel[LEDPWM1]);
  ReefAngel.LCD.DrawText(0,255,15+20,72,PWMChannel[LEDPWM2]);
  ReefAngel.LCD.DrawText(0,255,15+20,82,PWMChannel[LEDPWM3]);

  ReefAngel.LCD.DrawText(0,255,15+60,52,"CC:");
  ReefAngel.LCD.DrawText(0,255,15+60,62,"CD:");
  ReefAngel.LCD.DrawText(0,255,15+60,72,"CS:");
 // ReefAngel.LCD.DrawText(0,255,15+80,52,cloudchance);
 // ReefAngel.LCD.DrawText(0,255,15+80,62,cloudduration);
 // ReefAngel.LCD.DrawText(0,255,15+80,72,cloudstart/60);
}

void DrawCustomGraph()
{

}

////// Place global variable code below here



////// Place global variable code above here 
void setup() {
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port3Bit | Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = 0;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port3Bit | Port7Bit;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 850 );
    // Ports that are always on
    ReefAngel.Relay.On( Port2 );
    ReefAngel.Relay.On( Port4 );
    ReefAngel.Relay.On( Port5 );
    ReefAngel.Relay.On( Port6 );

    //Port 1 = ATO
    //Port 2 = Always On
    //Port 3 = Heater
    //Port 4 = Main Pump
    //Port 5 = Wavemaker
    //Port 6 = Wavemaker
    //Port 7 = Sump Light
    //Port 8 = Feeder Relay


////// Place additional initialization code below here
   
   



    ////// Place additional initialization code above here 
  }

void loop()
{
    ReefAngel.StandardHeater( Port3,820,825 );
    ReefAngel.StandardLights( Port7,21,0,7,0 );
    ReefAngel.SingleATO( true,Port1,180,0 );
    ReefAngel.WavemakerRandom(Port5,15,45);
    ReefAngel.WavemakerRandom1(Port6,15,45);
   
    ////// Place your custom code below here
 
static unsigned long feeding = 0;
if ((now()%SECS_PER_DAY==28800) || (now()%SECS_PER_DAY==50400) || (now()%SECS_PER_DAY==72000)) //if it is 8am or 2pm or 8 pm { ReefAngel.FeedingModeStart(); //START FEEDING MODE } if (ReefAngel.DisplayedMenu==FEEDING_MODE)
{
if ( feeding == 0 )
{
feeding = now(); //set the time of the start of feeding to variable feeding } if ((now()-feeding>=60) && (now()-feeding<=61)) //if between 60 and 61 seconds has past { ReefAngel.Relay.On(Port8); //TURN FEEDER RELAY ON } else { ReefAngel.Relay.Off(Port8); //TURN FEEDER RELAY OFF } } else { if ( feeding > 0 ) { feeding = 0; } }

    }
   #PWMExpansion

  // Calculate your regular sunrise/sunset PWM value
  PWMChannel[LEDPWM0]=PWMSlope(10,30,22,00,0,50,240,PWMChannel[LEDPWM0]);
  PWMChannel[LEDPWM1]=PWMSlope(10,00,22,15,0,55,240,PWMChannel[LEDPWM1]);
  PWMChannel[LEDPWM2]=PWMSlope(11,0,21,30,0,45,240,PWMChannel[LEDPWM2]);
  PWMChannel[LEDPWM3]=PWMSlope(11,30,20,00,0,50,240,PWMChannel[LEDPWM3]);
  CheckCloud();
  //PWMExpansion(LEDPWM0,int(2.55*PWMChannel[LEDPWM0]));
  //PWMExpansion(LEDPWM1,int(2.55*PWMChannel[LEDPWM1]));
  //PWMExpansion(LEDPWM2,int(2.55*PWMChannel[LEDPWM2]));
  //PWMExpansion(LEDPWM3,int(2.55*PWMChannel[LEDPWM3]));
  //ReefAngel.LCD.DrawText(0,255,5,120,PWMChannel[LEDPWM0]);
  //ReefAngel.LCD.DrawText(0,255,35,120,PWMChannel[LEDPWM1]);
  //ReefAngel.LCD.DrawText(0,255,65,120,PWMChannel[LEDPWM2]);
  //ReefAngel.LCD.DrawText(0,255,95,120,PWMChannel[LEDPWM3]);





    ////// Place your custom code above here
    // This should always be the last line
    ReefAngel.AddWifi();
    ReefAngel.ShowInterface();
}




}
//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function 


void CheckCloud() {

 // ------------------------------------------------------------
 // Change the values below to customize your cloud/storm effect

 // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)  
 // For testing purposes, you can use 1 and cause the cloud to occur everyday 
 #define Clouds_Every_X_Days 1

 // Percentage chance of a cloud happening today  
 // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening 
 #define Cloud_Chance_per_Day 100

 // Minimum number of minutes for cloud duration. Don't use max duration of less than 6 
 #define Min_Cloud_Duration 7

 // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255 
 #define Max_Cloud_Duration 15

 // Minimum number of clouds that can happen per day 
 #define Min_Clouds_per_Day 3

 // Maximum number of clouds that can happen per day 
 #define Max_Clouds_per_Day 5

 // Only start the cloud effect after this setting  
 // In this example, start could after 11:30am 
 #define Start_Cloud_After NumMins(11,30)

 // Always end the cloud effect before this setting  
 // In this example, end could before 8:00pm 
 #define End_Cloud_Before NumMins(18,30)

 // Percentage chance of a lightning happen for every cloud  
 // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening 
 #define Lightning_Change_per_Cloud 100

 // Channels used by the actinic LEDs on the PWM Expansion module  
 // These channels will not be dimmed when the cloud effect is triggered  
 // Number is a binary form. B001100 means channel 2 and 3 are used for actinics 
 #define Actinic_Channels B000001

 // Channels used by the daylight LEDs on the PWM Expansion module  
 // These channels will be used for the spike when lightning effect is triggered  
 // Number is a binary form. B000011 means channel 0 and 1 are used for daylights 
 #define Daylight_Channels B000010

 // Note: Make sure to choose correct values that will work within your PWMSLope settings.
 // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
 // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
 // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
 // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
 // It's a tight fit, but it did.

 //#define printdebug 
 // Uncomment this for debug print on Serial Monitor window  
 #define forcecloudcalculation 
 // Uncomment this to force the cloud calculation to happen in the boot process.


 // Change the values above to customize your cloud/storm effect  
 // ------------------------------------------------------------
 // Do not change anything below here

 static byte cloudchance=255;
 static byte cloudduration=0;
 static int cloudstart=0;
 static byte numclouds=0;
 static byte lightningchance=0;
 static byte cloudindex=0;
 static byte lightningstatus=0;
 static int LastNumMins=0;
 // Every day at midnight, we check for chance of cloud happening today  
 if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
 if (cloudchance==255)
#else
 if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
 #endif  
 {  
   //Pick a random number between 0 and 99  
 cloudchance=random(100);  
 // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today  
 if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;  
 // Check if today is day for clouds.
 if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;  
 // If we have cloud today  
 if (cloudchance)  
 {  
   // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day  
   numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
 // pick the time that the first cloud will start  
 // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
 cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  // Now that we have all the parameters for the cloud, let's create the effect

 if (cloudchance)
 {
 //is it time for cloud yet?
 if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
 {
 // let's go through all channels to pick which ones will be dimmed  
 for (int a=0;a<6;a++)  
 {  
   if (bitRead(Actinic_Channels,a)==0)  
   {  
     // this will slope down the channel from the current PWM to 0 within 3minutes.
 // then it will stay at 0 for the duration of the cycle  
 // and finally slope up from 0 to PWM value within 3 minutes  
 // it is basically an inversed slope  
 PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
 }
 }
 if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)  
 {  
 for (int b=0;b<6;b++)  
 {  
 if (bitRead(Daylight_Channels,b)==1)  
 {  
 if (random(100)<20) lightningstatus=1;  
 else lightningstatus=0;  
 if (lightningstatus) PWMChannel[b]=100;  
 else PWMChannel[b]=0;  
 //delay(10);  
 }  
 else  
 {  
 PWMChannel[b]=20;  
 }  }  }  }  
 if (NumMins(hour(),minute())>(cloudstart+cloudduration))
 {
 cloudindex++;
 if (cloudindex < numclouds)
 {
 cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  
 // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  }

 if (LastNumMins!=NumMins(hour(),minute()))
 {
 LastNumMins=NumMins(hour(),minute());
 ReefAngel.LCD.Clear(255,0,120,132,132);
 ReefAngel.LCD.DrawText(0,255,5,120,"C");
 ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
 ReefAngel.LCD.DrawText(0,255,45,120,"L");
 ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
 if (cloudchance && (NumMins(hour(),minute())<cloudstart))
 {
 int x=0;
 if ((cloudstart/60)>=10) x=11; else x=17;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
 if ((cloudstart%60)>=10) x=29; else x=35;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
 }
 ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
 if (lightningchance)
 {
 int x=0;
 if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
 if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
 }
 }
}
 

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
  //End Cloud & Lighting 
}




//*********************************************************************************************************************************
dlplunkett44
Posts: 74
Joined: Mon Aug 05, 2013 3:16 am

Re: Can't get weather code working

Post by dlplunkett44 »

So I was able to change a few things and get it to compile. When I tried uploading it, I got no errors, but now the screen flashes white then the status led flashes 3 times and it repeats. Please help!

My code is:

Code: Select all

/*

 To be able to use the custom main screen and PWM Expansion, please make sure that you enabled custom main screen and pwm expansion on your features file.
 Open RAGen and make sure you have Custom Main Screen and PWM Expansion checked under the Features tab.

 Or, you can manually edit the file.
 The file is located at "Documents\Arduino\libraries\ReefAngel_Features.h" file and has to include this line in it:

 #define CUSTOM_MAIN
 #define PWMEXPANSION

 */

/* The following features are enabled for this PDE File:
#define DisplayImages
#define WavemakerSetup
#define DateTimeSetup
#define VersionMenu
#define DirectTempSensor
#define DisplayLEDPWM
#define StandardLightSetup
#define PWMEXPANSION
*/

//*********************************************************************************************************************************
//Start of PWM Expansion Code Header

// This is just how we are going to reference the PWM expansion ports within the code.
// You can change the labels if you would like, just as long as they are changed all throughout the code too.
#define LEDPWM0 0
#define LEDPWM1 1
#define LEDPWM2 2
#define LEDPWM3 3
#define LEDPWM4 4
#define LEDPWM5 5

// Initial values to all 6 channels at startup. They will always be 0.
byte PWMChannel[]={
  0,0,0,0,0,0};
//byte cloudchance=0;
//byte cloudduration=0;
//int cloudstart=0;
//End of PWM Expansion Code Header
//********************************************************************************************************************************

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <ReefAngel.h>
#include <avr/wdt.h>


void DrawCustomMain()
{
  ReefAngel.LCD.DrawDate(6, 112);
  pingSerial();
  ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15, 10, "T1:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T1_PROBE], T1TempColor, 15+18, 10, 10);
  ReefAngel.LCD.DrawText(T2TempColor, DefaultBGColor, 15, 10+10, "T2:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], T2TempColor, 15+18, 10+10, 10);
  ReefAngel.LCD.DrawText(T3TempColor, DefaultBGColor, 15, 10+20, "T3:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T3_PROBE], T3TempColor, 15+18, 10+20, 10);
  ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+60, 10, "PH:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.PH, PHColor, 15+78, 10, 100);

  //ATO status
  ReefAngel.LCD.DrawText(DefaultFGColor, DefaultBGColor, 15+60, 10+20, "Pump:");

  byte highcolor;
  char highstatus[10];

  if ( ReefAngel.HighATO.IsActive() )
    {
       ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+90, 10+20, "ON ");
    }
  else
    {
       ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15+90, 10+20, "OFF");
    }
  //End ATO status
  pingSerial();
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 95, TempRelay);
  //ReefAngel.LCD.DrawOutletBox(12, 35, TempRelay);

  ReefAngel.LCD.DrawText(0,255,15,52,"RB:");
  ReefAngel.LCD.DrawText(0,255,15,62,"CW");
  ReefAngel.LCD.DrawText(0,255,15,72,"OCW:");
  ReefAngel.LCD.DrawText(0,255,15,82,"VI:");
  ReefAngel.LCD.DrawText(0,255,15+20,52,PWMChannel[LEDPWM0]);
  ReefAngel.LCD.DrawText(0,255,15+20,62,PWMChannel[LEDPWM1]);
  ReefAngel.LCD.DrawText(0,255,15+20,72,PWMChannel[LEDPWM2]);
  ReefAngel.LCD.DrawText(0,255,15+20,82,PWMChannel[LEDPWM3]);

  ReefAngel.LCD.DrawText(0,255,15+60,52,"CC:");
  ReefAngel.LCD.DrawText(0,255,15+60,62,"CD:");
  ReefAngel.LCD.DrawText(0,255,15+60,72,"CS:");
//ReefAngel.LCD.DrawText(0,255,15+80,52,cloudchance);
  //ReefAngel.LCD.DrawText(0,255,15+80,62,cloudduration);
  //ReefAngel.LCD.DrawText(0,255,15+80,72,cloudstart/60);
}

void DrawCustomGraph()
{

}

////// Place global variable code below here



////// Place global variable code above here 
void setup() {
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port3Bit | Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = 0;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port3Bit | Port7Bit;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 860 );
    // Ports that are always on
    ReefAngel.Relay.On( Port2 );
    ReefAngel.Relay.On( Port4 );
    ReefAngel.Relay.On( Port5 );
    ReefAngel.Relay.On( Port6 );

    //Port 1 = ATO
    //Port 2 = Always On
    //Port 3 = Heater
    //Port 4 = Main Pump
    //Port 5 = Wavemaker
    //Port 6 = Wavemaker
    //Port 7 = Sump Light
    //Port 8 = Feeder Relay


////// Place additional initialization code below here
   
   



    ////// Place additional initialization code above here 
  }

void loop()
{
    ReefAngel.StandardHeater( Port3,820,825 );
    ReefAngel.StandardLights( Port7,21,0,7,0 );
    ReefAngel.SingleATO( true,Port1,180,1 );
    ReefAngel.WavemakerRandom(Port5,15,45);
    ReefAngel.WavemakerRandom1(Port6,15,45);
   
    ////// Place your custom code below here
 
static unsigned long feeding = 0;
if ((now()%SECS_PER_DAY==28800) || (now()%SECS_PER_DAY==50400) || (now()%SECS_PER_DAY==72000)) //if it is 8am or 2pm or 8 pm { ReefAngel.FeedingModeStart(); //START FEEDING MODE } if (ReefAngel.DisplayedMenu==FEEDING_MODE)
{
if ( feeding == 0 )
{
feeding = now(); //set the time of the start of feeding to variable feeding } if ((now()-feeding>=60) && (now()-feeding<=61)) //if between 60 and 61 seconds has past { ReefAngel.Relay.On(Port8); //TURN FEEDER RELAY ON } else { ReefAngel.Relay.Off(Port8); //TURN FEEDER RELAY OFF } } else { if ( feeding > 0 ) { feeding = 0; } }

    }
  // #PWMEXPANSION

//Channel 0 = Blue
//Channel 1 = White
//Channel 2 = OCW
//Channel 3 = Violet
//Channel 4 = Moonlights
//Channel 5 = Not Used




  // Calculate your regular sunrise/sunset PWM value
  PWMChannel[LEDPWM0]=PWMSlope(6,0,21,30,1,80,60,PWMChannel[LEDPWM0]);
  PWMChannel[LEDPWM1]=PWMSlope(6,30,20,45,1,60,60,PWMChannel[LEDPWM1]);
  PWMChannel[LEDPWM2]=PWMSlope(6,15,21,00,1,60,90,PWMChannel[LEDPWM2]);
  PWMChannel[LEDPWM3]=PWMSlope(6,0,21,45,0,75,60,PWMChannel[LEDPWM3]);
  ReefAngel.PWM.SetChannel( 4, PWMSlope(20,30,6,30,0,30,60,0) );
  
  CheckCloud();
  //PWMExpansion(LEDPWM0,int(2.55*PWMChannel[LEDPWM0]));
  //PWMExpansion(LEDPWM1,int(2.55*PWMChannel[LEDPWM1]));
  //PWMExpansion(LEDPWM2,int(2.55*PWMChannel[LEDPWM2]));
  //PWMExpansion(LEDPWM3,int(2.55*PWMChannel[LEDPWM3]));
  //ReefAngel.LCD.DrawText(0,255,5,120,PWMChannel[LEDPWM0]);
  //ReefAngel.LCD.DrawText(0,255,35,120,PWMChannel[LEDPWM1]);
  //ReefAngel.LCD.DrawText(0,255,65,120,PWMChannel[LEDPWM2]);
  //ReefAngel.LCD.DrawText(0,255,95,120,PWMChannel[LEDPWM3]);





    ////// Place your custom code above here
    // This should always be the last line
    ReefAngel.AddWifi();
    ReefAngel.ShowInterface();
}




}
//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function 


void CheckCloud() {

 // ------------------------------------------------------------
 // Change the values below to customize your cloud/storm effect

 // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)  
 // For testing purposes, you can use 1 and cause the cloud to occur everyday 
 #define Clouds_Every_X_Days 1

 // Percentage chance of a cloud happening today  
 // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening 
 #define Cloud_Chance_per_Day 100

 // Minimum number of minutes for cloud duration. Don't use max duration of less than 6 
 #define Min_Cloud_Duration 7

 // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255 
 #define Max_Cloud_Duration 15

 // Minimum number of clouds that can happen per day 
 #define Min_Clouds_per_Day 3

 // Maximum number of clouds that can happen per day 
 #define Max_Clouds_per_Day 5

 // Only start the cloud effect after this setting  
 // In this example, start could after 10:00am 
 #define Start_Cloud_After NumMins(10,00)

 // Always end the cloud effect before this setting  
 // In this example, end could before 7:30pm 
 #define End_Cloud_Before NumMins(19,30)

 // Percentage chance of a lightning happen for every cloud  
 // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening 
 #define Lightning_Change_per_Cloud 100

 // Channels used by the actinic LEDs on the PWM Expansion module  
 // These channels will not be dimmed when the cloud effect is triggered  
 // Number is a binary form. B001100 means channel 2 and 3 are used for actinics 
 #define Actinic_Channels B001001

 // Channels used by the daylight LEDs on the PWM Expansion module  
 // These channels will be used for the spike when lightning effect is triggered  
 // Number is a binary form. B000011 means channel 0 and 1 are used for daylights 
 #define Daylight_Channels B000110

 // Note: Make sure to choose correct values that will work within your PWMSLope settings.
 // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
 // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
 // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
 // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
 // It's a tight fit, but it did.

 //#define printdebug 
 // Uncomment this for debug print on Serial Monitor window  
 #define forcecloudcalculation 
 // Uncomment this to force the cloud calculation to happen in the boot process.


 // Change the values above to customize your cloud/storm effect  
 // ------------------------------------------------------------
 // Do not change anything below here

 static byte cloudchance=255;
 static byte cloudduration=0;
 static int cloudstart=0;
 static byte numclouds=0;
 static byte lightningchance=0;
 static byte cloudindex=0;
 static byte lightningstatus=0;
 static int LastNumMins=0;
 // Every day at midnight, we check for chance of cloud happening today  
 if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
 if (cloudchance==255)
#else
 if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
 #endif  
 {  
   //Pick a random number between 0 and 99  
 cloudchance=random(100);  
 // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today  
 if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;  
 // Check if today is day for clouds.
 if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;  
 // If we have cloud today  
 if (cloudchance)  
 {  
   // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day  
   numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
 // pick the time that the first cloud will start  
 // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
 cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  // Now that we have all the parameters for the cloud, let's create the effect

 if (cloudchance)
 {
 //is it time for cloud yet?
 if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
 {
 // let's go through all channels to pick which ones will be dimmed  
 for (int a=0;a<6;a++)  
 {  
   if (bitRead(Actinic_Channels,a)==0)  
   {  
     // this will slope down the channel from the current PWM to 0 within 3minutes.
 // then it will stay at 0 for the duration of the cycle  
 // and finally slope up from 0 to PWM value within 3 minutes  
 // it is basically an inversed slope  
 PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
 }
 }
 if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)  
 {  
 for (int b=0;b<6;b++)  
 {  
 if (bitRead(Daylight_Channels,b)==1)  
 {  
 if (random(100)<20) lightningstatus=1;  
 else lightningstatus=0;  
 if (lightningstatus) PWMChannel[b]=100;  
 else PWMChannel[b]=0;  
 //delay(10);  
 }  
 else  
 {  
 PWMChannel[b]=20;  
 }  }  }  }  
 if (NumMins(hour(),minute())>(cloudstart+cloudduration))
 {
 cloudindex++;
 if (cloudindex < numclouds)
 {
 cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  
 // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  }

 if (LastNumMins!=NumMins(hour(),minute()))
 {
 LastNumMins=NumMins(hour(),minute());
 ReefAngel.LCD.Clear(255,0,120,132,132);
 ReefAngel.LCD.DrawText(0,255,5,120,"C");
 ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
 ReefAngel.LCD.DrawText(0,255,45,120,"L");
 ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
 if (cloudchance && (NumMins(hour(),minute())<cloudstart))
 {
 int x=0;
 if ((cloudstart/60)>=10) x=11; else x=17;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
 if ((cloudstart%60)>=10) x=29; else x=35;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
 }
 ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
 if (lightningchance)
 {
 int x=0;
 if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
 if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
 }
 }
}
 

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
  //End Cloud & Lighting 
}




//*********************************************************************************************************************************
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Can't get weather code working

Post by rimai »

You are missing one } in your code, which ended up all the way in the end and caused ShowInterface() to be inside the if statement.
You must have ShowInterface being called in every loop pass.
Roberto.
dlplunkett44
Posts: 74
Joined: Mon Aug 05, 2013 3:16 am

Re: Can't get weather code working

Post by dlplunkett44 »

Thanks!! So that got the screen working, but the clouds/lightning are not working. I watched as the screen said a cloud/lightning should have happened and the lights did not change at all. Here is my updated code:

Code: Select all

/*

 To be able to use the custom main screen and PWM Expansion, please make sure that you enabled custom main screen and pwm expansion on your features file.
 Open RAGen and make sure you have Custom Main Screen and PWM Expansion checked under the Features tab.

 Or, you can manually edit the file.
 The file is located at "Documents\Arduino\libraries\ReefAngel_Features.h" file and has to include this line in it:

 #define CUSTOM_MAIN
 #define PWMEXPANSION

 */

/* The following features are enabled for this PDE File:
#define DisplayImages
#define WavemakerSetup
#define DateTimeSetup
#define VersionMenu
#define DirectTempSensor
#define DisplayLEDPWM
#define StandardLightSetup
#define PWMEXPANSION
*/

//*********************************************************************************************************************************
//Start of PWM Expansion Code Header

// This is just how we are going to reference the PWM expansion ports within the code.
// You can change the labels if you would like, just as long as they are changed all throughout the code too.
#define LEDPWM0 0
#define LEDPWM1 1
#define LEDPWM2 2
#define LEDPWM3 3
#define LEDPWM4 4
#define LEDPWM5 5

// Initial values to all 6 channels at startup. They will always be 0.
byte PWMChannel[]={
  0,0,0,0,0,0};
//byte cloudchance=0;
//byte cloudduration=0;
//int cloudstart=0;
//End of PWM Expansion Code Header
//********************************************************************************************************************************

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <ReefAngel.h>
#include <avr/wdt.h>


void DrawCustomMain()
{
  
  
  ReefAngel.LCD.DrawDate(6, 112);
  pingSerial();
  ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15, 10, "T1:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T1_PROBE], T1TempColor, 15+18, 10, 10);
  ReefAngel.LCD.DrawText(T2TempColor, DefaultBGColor, 15, 10+10, "T2:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], T2TempColor, 15+18, 10+10, 10);
  ReefAngel.LCD.DrawText(T3TempColor, DefaultBGColor, 15, 10+20, "T3:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T3_PROBE], T3TempColor, 15+18, 10+20, 10);
  ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+60, 10, "PH:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.PH, PHColor, 15+78, 10, 100);

  //ATO status
  ReefAngel.LCD.DrawText(DefaultFGColor, DefaultBGColor, 15+60, 10+20, "Pump:");

  byte highcolor;
  char highstatus[10];

  if ( ReefAngel.HighATO.IsActive() )
    {
       ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+90, 10+20, "ON ");
    }
  else
    {
       ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15+90, 10+20, "OFF");
    }
  //End ATO status
  pingSerial();
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 95, TempRelay);
  //ReefAngel.LCD.DrawOutletBox(12, 35, TempRelay);

  ReefAngel.LCD.DrawText(0,255,15,52,"RB:");
  ReefAngel.LCD.DrawText(0,255,15,62,"CW:");
  ReefAngel.LCD.DrawText(0,255,15,72,"OCW:");
  ReefAngel.LCD.DrawText(0,255,15,82,"VI:");
  ReefAngel.LCD.DrawText(0,255,15+22,52,PWMChannel[LEDPWM0]);
  ReefAngel.LCD.DrawText(0,255,15+22,62,PWMChannel[LEDPWM1]);
  ReefAngel.LCD.DrawText(0,255,15+22,72,PWMChannel[LEDPWM2]);
  ReefAngel.LCD.DrawText(0,255,15+22,82,PWMChannel[LEDPWM3]);

  ReefAngel.LCD.DrawText(0,255,15+60,52,"CC:");
  ReefAngel.LCD.DrawText(0,255,15+60,62,"CD:");
  ReefAngel.LCD.DrawText(0,255,15+60,72,"CS:");
  //ReefAngel.LCD.DrawText(0,255,15+80,52,cloudchance);
  //ReefAngel.LCD.DrawText(0,255,15+80,62,cloudduration);
  //ReefAngel.LCD.DrawText(0,255,15+80,72,cloudstart/60);
  
  
}

void DrawCustomGraph()
{

}

////// Place global variable code below here



////// Place global variable code above here 
void setup() {
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port3Bit | Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = 0;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port3Bit | Port7Bit;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 860 );
    // Ports that are always on
    ReefAngel.Relay.On( Port2 );
    ReefAngel.Relay.On( Port4 );
    ReefAngel.Relay.On( Port5 );
    ReefAngel.Relay.On( Port6 );

    //Port 1 = ATO
    //Port 2 = Always On
    //Port 3 = Heater
    //Port 4 = Main Pump
    //Port 5 = Wavemaker
    //Port 6 = Wavemaker
    //Port 7 = Sump Light
    //Port 8 = Feeder Relay


////// Place additional initialization code below here
   
   



    ////// Place additional initialization code above here 
  }

void loop()
{
    ReefAngel.StandardHeater( Port3,820,825 );
    ReefAngel.StandardLights( Port7,21,0,7,0 );
    ReefAngel.SingleATO( true,Port1,180,1 );
    ReefAngel.WavemakerRandom(Port5,15,45);
    ReefAngel.WavemakerRandom1(Port6,15,45);
   
    ////// Place your custom code below here
 
  static unsigned long feeding = 0;
  if ((now()%SECS_PER_DAY==28800) || (now()%SECS_PER_DAY==50400) || (now()%SECS_PER_DAY==72000)) //if it is 8am or 2pm or 8 pm 
  { 
    ReefAngel.FeedingModeStart(); //START FEEDING MODE 
  } 
  if (ReefAngel.DisplayedMenu==FEEDING_MODE)
  {
    if ( feeding == 0 )
    {
      feeding = now(); //set the time of the start of feeding to variable feeding 
    } 
    if ((now()-feeding>=60) && (now()-feeding<=61)) //if between 60 and 61 seconds has past 
    { 
      ReefAngel.Relay.On(Port8); //TURN FEEDER RELAY ON 
    } 
    else 
    { 
      ReefAngel.Relay.Off(Port8); //TURN FEEDER RELAY OFF 
    } 
  } 
  else 
  { 
  if ( feeding > 0 ) 
  { 
    feeding = 0; 
  } 
}

    
   //#PWMEXPANSION

//Channel 0 = Blue
//Channel 1 = White
//Channel 2 = OCW
//Channel 3 = Violet
//Channel 4 = Moonlights
//Channel 5 = Not Used




  // Calculate your regular sunrise/sunset PWM value
  PWMChannel[LEDPWM0]=PWMSlope(6,0,21,30,1,80,60,PWMChannel[LEDPWM0]);
  PWMChannel[LEDPWM1]=PWMSlope(6,30,20,45,1,60,60,PWMChannel[LEDPWM1]);
  PWMChannel[LEDPWM2]=PWMSlope(6,15,21,00,1,60,90,PWMChannel[LEDPWM2]);
  PWMChannel[LEDPWM3]=PWMSlope(6,0,21,45,0,75,60,PWMChannel[LEDPWM3]);
  ReefAngel.PWM.SetChannel( 0,PWMChannel[LEDPWM0]);
  ReefAngel.PWM.SetChannel( 1,PWMChannel[LEDPWM1]);
  ReefAngel.PWM.SetChannel( 2,PWMChannel[LEDPWM2]);
  ReefAngel.PWM.SetChannel( 3,PWMChannel[LEDPWM3]);
  ReefAngel.PWM.SetChannel( 4, PWMSlope(20,30,6,30,0,30,60,0) );
  
  CheckCloud();
  PWMExpansion(LEDPWM0,int(2.55*PWMChannel[LEDPWM0]));
  PWMExpansion(LEDPWM1,int(2.55*PWMChannel[LEDPWM1]));
  PWMExpansion(LEDPWM2,int(2.55*PWMChannel[LEDPWM2]));
  PWMExpansion(LEDPWM3,int(2.55*PWMChannel[LEDPWM3]));
  //ReefAngel.LCD.DrawText(0,255,5,120,PWMChannel[LEDPWM0]);
  //ReefAngel.LCD.DrawText(0,255,35,120,PWMChannel[LEDPWM1]);
  //ReefAngel.LCD.DrawText(0,255,65,120,PWMChannel[LEDPWM2]);
 // ReefAngel.LCD.DrawText(0,255,95,120,PWMChannel[LEDPWM3]);





    ////// Place your custom code above here
    // This should always be the last line
    ReefAngel.AddWifi();
    ReefAngel.ShowInterface();
}


//Start of PWM slope function code designed for the PWM Expansion module
void PWMExpansion(byte cmd, byte data)
{ 
	Wire.beginTransmission(8); // transmit to device #2
	Wire.write('$'); // sends $ 
	Wire.write('$'); // sends $ 
	Wire.write('$'); // sends $ 
	Wire.write(cmd); // sends a value 
	Wire.write(data); // sends 255 
	Wire.endTransmission(); // stop transmitting
}
//End of PWM slope function code designed for the PWM Expansion module
//*********************************************************************************************************************************



//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function 


void CheckCloud() {

 // ------------------------------------------------------------
 // Change the values below to customize your cloud/storm effect

 // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)  
 // For testing purposes, you can use 1 and cause the cloud to occur everyday 
 #define Clouds_Every_X_Days 1

 // Percentage chance of a cloud happening today  
 // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening 
 #define Cloud_Chance_per_Day 100

 // Minimum number of minutes for cloud duration. Don't use max duration of less than 6 
 #define Min_Cloud_Duration 7

 // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255 
 #define Max_Cloud_Duration 15

 // Minimum number of clouds that can happen per day 
 #define Min_Clouds_per_Day 3

 // Maximum number of clouds that can happen per day 
 #define Max_Clouds_per_Day 5

 // Only start the cloud effect after this setting  
 // In this example, start could after 10:00am 
 #define Start_Cloud_After NumMins(10,00)

 // Always end the cloud effect before this setting  
 // In this example, end could before 7:30pm 
 #define End_Cloud_Before NumMins(22,00)

 // Percentage chance of a lightning happen for every cloud  
 // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening 
 #define Lightning_Change_per_Cloud 100

 // Channels used by the actinic LEDs on the PWM Expansion module  
 // These channels will not be dimmed when the cloud effect is triggered  
 // Number is a binary form. B001100 means channel 2 and 3 are used for actinics 
 #define Actinic_Channels B001001

 // Channels used by the daylight LEDs on the PWM Expansion module  
 // These channels will be used for the spike when lightning effect is triggered  
 // Number is a binary form. B000011 means channel 0 and 1 are used for daylights 
 #define Daylight_Channels B000110

 // Note: Make sure to choose correct values that will work within your PWMSLope settings.
 // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
 // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
 // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
 // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
 // It's a tight fit, but it did.

 //#define printdebug 
 // Uncomment this for debug print on Serial Monitor window  
 #define forcecloudcalculation 
 // Uncomment this to force the cloud calculation to happen in the boot process.


 // Change the values above to customize your cloud/storm effect  
 // ------------------------------------------------------------
 // Do not change anything below here

 static byte cloudchance=255;
 static byte cloudduration=0;
 static int cloudstart=0;
 static byte numclouds=0;
 static byte lightningchance=0;
 static byte cloudindex=0;
 static byte lightningstatus=0;
 static int LastNumMins=0;
 // Every day at midnight, we check for chance of cloud happening today  
 if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
 if (cloudchance==255)
#else
 if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
 #endif  
 {  
   //Pick a random number between 0 and 99  
 cloudchance=random(100);  
 // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today  
 if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;  
 // Check if today is day for clouds.
 if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;  
 // If we have cloud today  
 if (cloudchance)  
 {  
   // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day  
   numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
 // pick the time that the first cloud will start  
 // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
 cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  // Now that we have all the parameters for the cloud, let's create the effect

 if (cloudchance)
 {
 //is it time for cloud yet?
 if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
 {
 // let's go through all channels to pick which ones will be dimmed  
 for (int a=0;a<6;a++)  
 {  
   if (bitRead(Actinic_Channels,a)==0)  
   {  
     // this will slope down the channel from the current PWM to 0 within 3minutes.
 // then it will stay at 0 for the duration of the cycle  
 // and finally slope up from 0 to PWM value within 3 minutes  
 // it is basically an inversed slope  
 PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
 }
 }
 if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)  
 {  
 for (int b=0;b<6;b++)  
 {  
 if (bitRead(Daylight_Channels,b)==1)  
 {  
 if (random(100)<20) lightningstatus=1;  
 else lightningstatus=0;  
 if (lightningstatus) PWMChannel[b]=100;  
 else PWMChannel[b]=0;  
 //delay(10);  
 }  
 else  
 {  
 PWMChannel[b]=20;  
 }  }  }  }  
 if (NumMins(hour(),minute())>(cloudstart+cloudduration))
 {
 cloudindex++;
 if (cloudindex < numclouds)
 {
 cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  
 // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  }

 if (LastNumMins!=NumMins(hour(),minute()))
 {
 LastNumMins=NumMins(hour(),minute());
 ReefAngel.LCD.Clear(255,0,120,132,132);
 ReefAngel.LCD.DrawText(0,255,5,120,"C");
 ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
 ReefAngel.LCD.DrawText(0,255,45,120,"L");
 ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
 if (cloudchance && (NumMins(hour(),minute())<cloudstart))
 {
 int x=0;
 if ((cloudstart/60)>=10) x=11; else x=17;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
 if ((cloudstart%60)>=10) x=29; else x=35;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
 }
 ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
 if (lightningchance)
 {
 int x=0;
 if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
 if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
 }
 }
}
 

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
  //End Cloud & Lighting 
}




//*********************************************************************************************************************************
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Can't get weather code working

Post by rimai »

Ok, some of this code was meant for a really old dimming module.
Try this:

Code: Select all

/*

 To be able to use the custom main screen and PWM Expansion, please make sure that you enabled custom main screen and pwm expansion on your features file.
 Open RAGen and make sure you have Custom Main Screen and PWM Expansion checked under the Features tab.

 Or, you can manually edit the file.
 The file is located at "Documents\Arduino\libraries\ReefAngel_Features.h" file and has to include this line in it:

 #define CUSTOM_MAIN
 #define PWMEXPANSION

 */

/* The following features are enabled for this PDE File:
#define DisplayImages
#define WavemakerSetup
#define DateTimeSetup
#define VersionMenu
#define DirectTempSensor
#define DisplayLEDPWM
#define StandardLightSetup
#define PWMEXPANSION
*/

//*********************************************************************************************************************************
//Start of PWM Expansion Code Header

// This is just how we are going to reference the PWM expansion ports within the code.
// You can change the labels if you would like, just as long as they are changed all throughout the code too.
#define LEDPWM0 0
#define LEDPWM1 1
#define LEDPWM2 2
#define LEDPWM3 3
#define LEDPWM4 4
#define LEDPWM5 5

// Initial values to all 6 channels at startup. They will always be 0.
byte PWMChannel[]={
  0,0,0,0,0,0};
//byte cloudchance=0;
//byte cloudduration=0;
//int cloudstart=0;
//End of PWM Expansion Code Header
//********************************************************************************************************************************

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <ReefAngel.h>
#include <avr/wdt.h>


void DrawCustomMain()
{
  
  
  ReefAngel.LCD.DrawDate(6, 112);
  pingSerial();
  ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15, 10, "T1:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T1_PROBE], T1TempColor, 15+18, 10, 10);
  ReefAngel.LCD.DrawText(T2TempColor, DefaultBGColor, 15, 10+10, "T2:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], T2TempColor, 15+18, 10+10, 10);
  ReefAngel.LCD.DrawText(T3TempColor, DefaultBGColor, 15, 10+20, "T3:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T3_PROBE], T3TempColor, 15+18, 10+20, 10);
  ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+60, 10, "PH:");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.PH, PHColor, 15+78, 10, 100);

  //ATO status
  ReefAngel.LCD.DrawText(DefaultFGColor, DefaultBGColor, 15+60, 10+20, "Pump:");

  byte highcolor;
  char highstatus[10];

  if ( ReefAngel.HighATO.IsActive() )
    {
       ReefAngel.LCD.DrawText(PHColor, DefaultBGColor, 15+90, 10+20, "ON ");
    }
  else
    {
       ReefAngel.LCD.DrawText(T1TempColor, DefaultBGColor, 15+90, 10+20, "OFF");
    }
  //End ATO status
  pingSerial();
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 95, TempRelay);
  //ReefAngel.LCD.DrawOutletBox(12, 35, TempRelay);

  ReefAngel.LCD.DrawText(0,255,15,52,"RB:");
  ReefAngel.LCD.DrawText(0,255,15,62,"CW:");
  ReefAngel.LCD.DrawText(0,255,15,72,"OCW:");
  ReefAngel.LCD.DrawText(0,255,15,82,"VI:");
  ReefAngel.LCD.DrawText(0,255,15+22,52,PWMChannel[LEDPWM0]);
  ReefAngel.LCD.DrawText(0,255,15+22,62,PWMChannel[LEDPWM1]);
  ReefAngel.LCD.DrawText(0,255,15+22,72,PWMChannel[LEDPWM2]);
  ReefAngel.LCD.DrawText(0,255,15+22,82,PWMChannel[LEDPWM3]);

  ReefAngel.LCD.DrawText(0,255,15+60,52,"CC:");
  ReefAngel.LCD.DrawText(0,255,15+60,62,"CD:");
  ReefAngel.LCD.DrawText(0,255,15+60,72,"CS:");
  //ReefAngel.LCD.DrawText(0,255,15+80,52,cloudchance);
  //ReefAngel.LCD.DrawText(0,255,15+80,62,cloudduration);
  //ReefAngel.LCD.DrawText(0,255,15+80,72,cloudstart/60);
  
  
}

void DrawCustomGraph()
{

}

////// Place global variable code below here



////// Place global variable code above here 
void setup() {
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port3Bit | Port4Bit | Port5Bit | Port6Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = 0;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port3Bit | Port7Bit;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 860 );
    // Ports that are always on
    ReefAngel.Relay.On( Port2 );
    ReefAngel.Relay.On( Port4 );
    ReefAngel.Relay.On( Port5 );
    ReefAngel.Relay.On( Port6 );

    //Port 1 = ATO
    //Port 2 = Always On
    //Port 3 = Heater
    //Port 4 = Main Pump
    //Port 5 = Wavemaker
    //Port 6 = Wavemaker
    //Port 7 = Sump Light
    //Port 8 = Feeder Relay


////// Place additional initialization code below here
   
   



    ////// Place additional initialization code above here 
  }

void loop()
{
    ReefAngel.StandardHeater( Port3,820,825 );
    ReefAngel.StandardLights( Port7,21,0,7,0 );
    ReefAngel.SingleATO( true,Port1,180,1 );
    ReefAngel.WavemakerRandom(Port5,15,45);
    ReefAngel.WavemakerRandom1(Port6,15,45);
   
    ////// Place your custom code below here
 
  static unsigned long feeding = 0;
  if ((now()%SECS_PER_DAY==28800) || (now()%SECS_PER_DAY==50400) || (now()%SECS_PER_DAY==72000)) //if it is 8am or 2pm or 8 pm 
  { 
    ReefAngel.FeedingModeStart(); //START FEEDING MODE 
  } 
  if (ReefAngel.DisplayedMenu==FEEDING_MODE)
  {
    if ( feeding == 0 )
    {
      feeding = now(); //set the time of the start of feeding to variable feeding 
    } 
    if ((now()-feeding>=60) && (now()-feeding<=61)) //if between 60 and 61 seconds has past 
    { 
      ReefAngel.Relay.On(Port8); //TURN FEEDER RELAY ON 
    } 
    else 
    { 
      ReefAngel.Relay.Off(Port8); //TURN FEEDER RELAY OFF 
    } 
  } 
  else 
  { 
  if ( feeding > 0 ) 
  { 
    feeding = 0; 
  } 
}

    
   //#PWMEXPANSION

//Channel 0 = Blue
//Channel 1 = White
//Channel 2 = OCW
//Channel 3 = Violet
//Channel 4 = Moonlights
//Channel 5 = Not Used




  // Calculate your regular sunrise/sunset PWM value
  PWMChannel[LEDPWM0]=PWMSlope(6,0,21,30,1,80,60,PWMChannel[LEDPWM0]);
  PWMChannel[LEDPWM1]=PWMSlope(6,30,20,45,1,60,60,PWMChannel[LEDPWM1]);
  PWMChannel[LEDPWM2]=PWMSlope(6,15,21,00,1,60,90,PWMChannel[LEDPWM2]);
  PWMChannel[LEDPWM3]=PWMSlope(6,0,21,45,0,75,60,PWMChannel[LEDPWM3]);
  
  CheckCloud();
  ReefAngel.PWM.SetChannel( LEDPWM0,PWMChannel[LEDPWM0]);
  ReefAngel.PWM.SetChannel( LEDPWM1,PWMChannel[LEDPWM1]);
  ReefAngel.PWM.SetChannel( LEDPWM2,PWMChannel[LEDPWM2]);
  ReefAngel.PWM.SetChannel( LEDPWM3,PWMChannel[LEDPWM3]);
  ReefAngel.PWM.SetChannel( 4, PWMSlope(20,30,6,30,0,30,60,0) );
  //ReefAngel.LCD.DrawText(0,255,5,120,PWMChannel[LEDPWM0]);
  //ReefAngel.LCD.DrawText(0,255,35,120,PWMChannel[LEDPWM1]);
  //ReefAngel.LCD.DrawText(0,255,65,120,PWMChannel[LEDPWM2]);
 // ReefAngel.LCD.DrawText(0,255,95,120,PWMChannel[LEDPWM3]);





    ////// Place your custom code above here
    // This should always be the last line
    ReefAngel.AddWifi();
    ReefAngel.ShowInterface();
}


//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function 


void CheckCloud() {

 // ------------------------------------------------------------
 // Change the values below to customize your cloud/storm effect

 // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)  
 // For testing purposes, you can use 1 and cause the cloud to occur everyday 
 #define Clouds_Every_X_Days 1

 // Percentage chance of a cloud happening today  
 // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening 
 #define Cloud_Chance_per_Day 100

 // Minimum number of minutes for cloud duration. Don't use max duration of less than 6 
 #define Min_Cloud_Duration 7

 // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255 
 #define Max_Cloud_Duration 15

 // Minimum number of clouds that can happen per day 
 #define Min_Clouds_per_Day 3

 // Maximum number of clouds that can happen per day 
 #define Max_Clouds_per_Day 5

 // Only start the cloud effect after this setting  
 // In this example, start could after 10:00am 
 #define Start_Cloud_After NumMins(10,00)

 // Always end the cloud effect before this setting  
 // In this example, end could before 7:30pm 
 #define End_Cloud_Before NumMins(22,00)

 // Percentage chance of a lightning happen for every cloud  
 // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening 
 #define Lightning_Change_per_Cloud 100

 // Channels used by the actinic LEDs on the PWM Expansion module  
 // These channels will not be dimmed when the cloud effect is triggered  
 // Number is a binary form. B001100 means channel 2 and 3 are used for actinics 
 #define Actinic_Channels B001001

 // Channels used by the daylight LEDs on the PWM Expansion module  
 // These channels will be used for the spike when lightning effect is triggered  
 // Number is a binary form. B000011 means channel 0 and 1 are used for daylights 
 #define Daylight_Channels B000110

 // Note: Make sure to choose correct values that will work within your PWMSLope settings.
 // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
 // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
 // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
 // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
 // It's a tight fit, but it did.

 //#define printdebug 
 // Uncomment this for debug print on Serial Monitor window  
 #define forcecloudcalculation 
 // Uncomment this to force the cloud calculation to happen in the boot process.


 // Change the values above to customize your cloud/storm effect  
 // ------------------------------------------------------------
 // Do not change anything below here

 static byte cloudchance=255;
 static byte cloudduration=0;
 static int cloudstart=0;
 static byte numclouds=0;
 static byte lightningchance=0;
 static byte cloudindex=0;
 static byte lightningstatus=0;
 static int LastNumMins=0;
 // Every day at midnight, we check for chance of cloud happening today  
 if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
 if (cloudchance==255)
#else
 if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
 #endif  
 {  
   //Pick a random number between 0 and 99  
 cloudchance=random(100);  
 // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today  
 if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;  
 // Check if today is day for clouds.
 if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;  
 // If we have cloud today  
 if (cloudchance)  
 {  
   // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day  
   numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
 // pick the time that the first cloud will start  
 // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
 cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  // Now that we have all the parameters for the cloud, let's create the effect

 if (cloudchance)
 {
 //is it time for cloud yet?
 if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
 {
 // let's go through all channels to pick which ones will be dimmed  
 for (int a=0;a<6;a++)  
 {  
   if (bitRead(Actinic_Channels,a)==0)  
   {  
     // this will slope down the channel from the current PWM to 0 within 3minutes.
 // then it will stay at 0 for the duration of the cycle  
 // and finally slope up from 0 to PWM value within 3 minutes  
 // it is basically an inversed slope  
 PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
 }
 }
 if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)  
 {  
 for (int b=0;b<6;b++)  
 {  
 if (bitRead(Daylight_Channels,b)==1)  
 {  
 if (random(100)<20) lightningstatus=1;  
 else lightningstatus=0;  
 if (lightningstatus) PWMChannel[b]=100;  
 else PWMChannel[b]=0;  
 //delay(10);  
 }  
 else  
 {  
 PWMChannel[b]=20;  
 }  }  }  }  
 if (NumMins(hour(),minute())>(cloudstart+cloudduration))
 {
 cloudindex++;
 if (cloudindex < numclouds)
 {
 cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
 // pick a random number for the cloud duration of first cloud.
 cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
 //Pick a random number between 0 and 99  
 lightningchance=random(100);  
 // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today  
 if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;  }  }  }

 if (LastNumMins!=NumMins(hour(),minute()))
 {
 LastNumMins=NumMins(hour(),minute());
 ReefAngel.LCD.Clear(255,0,120,132,132);
 ReefAngel.LCD.DrawText(0,255,5,120,"C");
 ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
 ReefAngel.LCD.DrawText(0,255,45,120,"L");
 ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
 if (cloudchance && (NumMins(hour(),minute())<cloudstart))
 {
 int x=0;
 if ((cloudstart/60)>=10) x=11; else x=17;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
 if ((cloudstart%60)>=10) x=29; else x=35;
 ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
 }
 ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
 if (lightningchance)
 {
 int x=0;
 if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
 if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;  
 ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
 }
 }
}
 

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
  //End Cloud & Lighting 
}




//*********************************************************************************************************************************
Roberto.
dlplunkett44
Posts: 74
Joined: Mon Aug 05, 2013 3:16 am

Re: Can't get weather code working

Post by dlplunkett44 »

IT WORKS!!! Thanks! I tried it out this morning. The only thing is that I feel like the lights should dim faster when a cloud happens. Is this the code that I should change?
PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
I was thinking I would change it to
PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,30);

Would that make the dimming choppy though?
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Can't get weather code working

Post by rimai »

Cool!!!
Yes, I think you got it where to change for faster cloud :)
Roberto.
Post Reply