Page 1 of 1

DCPump code acting funny on portal

Posted: Sun Sep 22, 2019 6:54 am
by 89delta
So last night I finally decided to hook up an RW-4 and WP-25 I got from Ebay. I checked the portal to see what mode I was currently on and switched it to custom. When I did that the modes changed every few seconds. Am I missing something now from 4yrs ago when it worked on my BioCube???Thanks.

Code: Select all

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <PAR.h>
#include <ReefAngel.h>
#include <SunLocation.h>
#define NUMBERS_8x16
#define PI 3.141593


////// Place global variable code below here


SunLocation sl;


byte ActinicPWMValue=0;
byte DaylightPWMValue=0;

////// Memory Locations used by all formulas
#define Mem_B_AcclDay  100 
// Note - 100 represents the hard coded Memory location used for this variable 
// not the value for the variable.
// This variable represents the current day in Acclimation Cycle. Set this value to the same 
// number of days as your AcclDuration to begin the acclimation cycle or set it to 0 to use 
// your normal dimming end% values.
#define Mem_B_AcclDuration  101 // Set this value to how many days you want your acclimation cycle to take.
#define Mem_B_SlopeStart  102 // Set this to your desired starting acclimation end%.

/////// Memory Locations used by Blue Formula
#define Mem_B_AcclStartEndBlue  105    // Acclimation starting Slope end%
#define Mem_B_SlopeEndBlue  106    // slope End%
////// Memory Locations used by White Formula
#define Mem_B_AcclStartEndWhite  110 // Acclimation starting Slope end%
#define Mem_B_SlopeEndWhite  111    // Slope End%



void DrawCustomMain() {  //5,14
  char buf[16];
  //byte acclDay = InternalMemory.read(Mem_B_AcclDay);
  
  ReefAngel.LCD.DrawLargeText(COLOR_BLACK, COLOR_WHITE, 10, 4, "Paradise Reef");
  ReefAngel.LCD.DrawDate(6, 118);
  
  // Temp and PH
  ReefAngel.LCD.DrawText(COLOR_BLACK,DefaultBGColor,10,65,"Temp:");
  ReefAngel.LCD.DrawText(COLOR_BLACK,DefaultBGColor,85, 65, "PH:");
  ConvertNumToString(buf, ReefAngel.Params.Temp[T2_PROBE], 10);
  ReefAngel.LCD.DrawText(T2TempColor, DefaultBGColor, 48, 73, buf); 
  ConvertNumToString(buf, ReefAngel.Params.Temp[T1_PROBE], 10);
  ReefAngel.LCD.DrawLargeText(T1TempColor, DefaultBGColor, 10, 75, buf, Num8x16);
  ConvertNumToString(buf, ReefAngel.Params.PH, 100);
  ReefAngel.LCD.DrawLargeText(PHColor, DefaultBGColor, 85, 75, buf, Num8x16);
  ConvertNumToString(buf, ReefAngel.Params.Temp[T3_PROBE], 10);
  ReefAngel.LCD.DrawText(T3TempColor, DefaultBGColor, 48, 82, buf);


  //Salinity
    char text[10];
  ConvertNumToString(text, ReefAngel.Params.Salinity, 10);
  strcat(text,"  ");
  ReefAngel.LCD.DrawText(DefaultFGColor,DefaultBGColor,15,93,"Salinity:");
  ReefAngel.LCD.DrawText(COLOR_NAVY,DefaultBGColor,75,93,text);
  pingSerial();   
  
  // Display Relays  
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 102, TempRelay);
  
  
  
  
}
void DrawCustomGraph()
{
    ReefAngel.LCD.DrawGraph(5, 12);
}


////// Place global variable code above here


void setup()
{
    // This must be the first line
    ReefAngel.Init();  //Initialize controller

    ReefAngel.AddSalinityExpansion();         // Salinity Expansion Module
    ReefAngel.Salinity.SetCompensation(0);    // Default Salinity compensation
    
    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port1Bit | Port2Bit |Port3Bit | Port5Bit | Port6Bit ;
    
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port2Bit | Port3Bit | Port5Bit | Port6Bit;
    
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = Port7Bit | Port8Bit;
    
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port2Bit;
    
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;

    // Ports that are always on
    ReefAngel.Relay.On( Port1 );    //Return Pump
    ReefAngel.Relay.On( Port6 );    //Circ. Powerhead
    ReefAngel.Relay.On( Port7 );    //AI
    ReefAngel.Relay.On( Port8 );    //AI

    ////// Place additional initialization code below here
    
  //sl.Init(-21.285833, 150.999722); // In decimal numbers (i.e. -18.285833, 147.699722)
  //sl.SetOffset(11,0,11,0); // rise_hour, rise_seconds, set_hour, set_seconds
    sl.Init(38.8447,-104.8433); // Colorado Springs,CO In decimal numbers (i.e. -18.285833, 147.699722)
    sl.SetOffset(-6,0,-6,0); // rise_hour, rise_seconds, set_hour, set_seconds
    
    
  randomSeed(now()/SECS_PER_DAY);
  
    // Jebao Code   
    // Feeeding and Water Change mode speed
    ReefAngel.DCPump.FeedingSpeed=0;
    ReefAngel.DCPump.WaterChangeSpeed=0;
       
    ////// Place additional initialization code above here
}

void loop()
{
  


    ReefAngel.StandardLights( Port4,18,0,10,0 ); //Fuge Light
    ReefAngel.WavemakerRandom2( Port6,10,60 );    //Powerheads
    
    // 15min Delay on Skimmer coming from Feeding or Waterchange Modes
    ReefAngel.Relay.DelayedOn(Port1, 10);  //Return
    ReefAngel.Relay.DelayedOn(Port5, 10);  //Circ Pump
    ReefAngel.Relay.DelayedOn(Port6, 10);  //Powerhead
    ReefAngel.Relay.DelayedOn(Port3, 20);  //Skimmer
    
 
    SeasonalTemps();

    
    // Jebao Code   
    // Feeeding and Water Change mode speed
    pinMode(lowATOPin,OUTPUT);
    analogWrite(lowATOPin,ReefCrestMode(50,20,true)*2.55);
    ReefAngel.DCPump.UseMemory = true;
    ReefAngel.DCPump.LowATOChannel = AntiSync ; // Jebo connected to AtoPINLow
    pinMode(highATOPin,OUTPUT);
    analogWrite(highATOPin,ReefCrestMode(50,20,true)*2.55);
    ReefAngel.DCPump.UseMemory = true;
    ReefAngel.DCPump.HighATOChannel = Sync ; // Jebo connected to AtoPINLow
   

    // Add random mode if we set to Mode to Custom in portal
    static int rmode;
    static boolean changeMode=true;
    
    
    // These are the modes we can cycle through. You can add more and even repeat...
    byte modes[] = { Lagoon, ReefCrest, TidalSwell, ShortPulse, Else, NutrientTransport };
    
    if (now()%SECS_PER_DAY==0 || changeMode==true) { // Change at midnight or if controller rebooted
    rmode=random(100)%sizeof(modes); // Change the mode once per day to pick from our array
    changeMode=true;
    }
    
    // Set timer when in feeding mode
    static unsigned long feeding;
    if (ReefAngel.DisplayedMenu==FEEDING_MODE) feeding=now();
    
    if (now()-feeding<900) { 
      // First 15 minutes after feeding mode stops. Smart_NTM
      ReefAngel.DCPump.UseMemory=false;
      ReefAngel.DCPump.Mode=NutrientTransport;
    } else if (now()-feeding<2250) { // 15 minutes plus 1 hour
      // Continue NTM for the next 60 minutes (75 minutes total)
      ReefAngel.DCPump.UseMemory=false;
      ReefAngel.DCPump.Mode=NutrientTransport;
    } else if (now()%SECS_PER_DAY<23400 || now()%SECS_PER_DAY>=72000) { // 6:30am / 8:00pm
      // Night mode (go to 30%)
      ReefAngel.DCPump.UseMemory=false;
      ReefAngel.DCPump.Mode=Constant;
      ReefAngel.DCPump.Speed=40;
      //ReefAngel.DCPump.SetMode(Constant,31,45,30);
    } else if (InternalMemory.DCPumpMode_read()==11) { 
      // Custom Mode and nothing else going on
      ReefAngel.DCPump.UseMemory=false;
      ReefAngel.DCPump.Duration=InternalMemory.DCPumpDuration_read();
      if (modes[rmode]==Else) {
        ReefAngel.DCPump.UseMemory=false;
        ReefAngel.DCPump.Mode=Constant;
        ReefAngel.DCPump.Speed=ElseMode(InternalMemory.DCPumpSpeed_read(),25,true );    // ElseMode on sync mode, Portal Speed Setting +/- 25%
      } else {
        ReefAngel.DCPump.Mode=modes[rmode];  // Put the mode to the random mode :)
        ReefAngel.DCPump.Speed=InternalMemory.DCPumpSpeed_read(); // Set speed from portal
      }
    } else {
      ReefAngel.DCPump.UseMemory=true; // Will reset all values from memory
    }   
 


////////// Variables used for all channels
  byte acclDay = InternalMemory.read(Mem_B_AcclDay); 
// What day in the acclimation cycle it is 
  byte acclDuration = InternalMemory.read(Mem_B_AcclDuration); 
// Acclimation Duration in days
  byte startPercent = InternalMemory.read(Mem_B_SlopeStart); 
// Normal start% being used by all 3 channels



////////// Blue Channel Variables
  byte acclStartEndBlue = InternalMemory.read(Mem_B_AcclStartEndBlue); 
// Starting End% for Acclimation cycle
  float acclendPercentBlue = InternalMemory.read(Mem_B_SlopeEndBlue); 
// Your target Blue end% once acclimation is complete

////////// Blue Channel Formula
  float acclPercentPerDayBlue = (acclendPercentBlue - acclStartEndBlue) / acclDuration;
// How much your Blue end% rises per acclimation day 
  float acclFactorBlue = acclDay * acclPercentPerDayBlue; 
// endPercentBlue will be offset by this much. If acclDay = 0 then this value will be 0
  byte endPercentBlue = acclendPercentBlue - acclFactorBlue; 
// Your final Blue end% for the day



////////// White Channel Variables
  byte acclStartEndWhite = InternalMemory.read(Mem_B_AcclStartEndWhite); 
// Starting End% for Acclimation cycle
  float acclEndPercentWhite = InternalMemory.read(Mem_B_SlopeEndWhite); 
// Your target White end% once acclimation is complete

////////// White Channel Formula
  float acclPercentPerDayWhite= (acclEndPercentWhite - acclStartEndWhite) / acclDuration; 
// How much your White end% rises per acclimation day
  float acclFactorWhite = acclDay * acclPercentPerDayWhite; 
// endPercentWhite will be offset by this much. If acclDay = 0 then this value will be 0
  byte endPercentWhite = acclEndPercentWhite - acclFactorWhite; 

// Custom Variable for Portal
ReefAngel.CustomVar[Var_AcclDay]=acclDay;

// At the end of the day, we need to decrement the acclimation counter.
  static boolean acclCounterReady=false; // We need a boolean so we only do this once per day
  if (now()%SECS_PER_DAY!=0) acclCounterReady=true; // If it's not midnight we'll get the boolean ready
  if (now()%SECS_PER_DAY==0 && acclCounterReady && acclDay>0) { // It's midnight, our bool is true and acclDay is more than 0
    acclDay--; // Reduce the counter
    acclCounterReady=false; // Reset the boolean flag
    InternalMemory.write(Mem_B_AcclDay,acclDay); // Update memory
}
    
    // handle updating sunrise and sunset values
    sl.CheckAndUpdate();

    ////// Place your custom code above here

    // This should always be the last line

    ReefAngel.CloudPortal();
    ReefAngel.ShowInterface();
    
    
  // Calculate your regular sunrise/sunset PWM value
  ActinicPWMValue=PWMSlope(sl.GetRiseHour(),sl.GetRiseMinute(),sl.GetSetHour(),sl.GetSetMinute(),startPercent,endPercentBlue,120,(MoonPhase()/3));
  DaylightPWMValue=PWMSlope(sl.GetRiseHour(),sl.GetRiseMinute(),sl.GetSetHour(),sl.GetSetMinute(),startPercent,endPercentWhite,120,DaylightPWMValue);
  
  CheckCloud();
  
  ReefAngel.PWM.SetActinic(ActinicPWMValue);
  ReefAngel.PWM.SetDaylight(DaylightPWMValue);    
  
  

}
// RA_STRING1=U2FsdGVkX19/CQXYxFHutorfRImY8TNubevs+8+6Sjw=
// RA_STRING2=U2FsdGVkX1+7EBoxpKZdEtYXEBfHD+fIe5qrAeDKTa8=
// RA_STRING3=Gundel
// RA_LABEL LABEL_ACTINIC=Actinic
// RA_LABEL LABEL_DAYLIGHT=Daylight


void SeasonalTemps ()
 {
  static int heatArray[][2] = { {792,796},// default in case of error in month=0 (June)
                    {778,810},//January (winter)
                    {780,810},//February (winter)
                    {783,810},//March (early spring)
                    {789,798},//April (spring)
                    {789,798},//May (spring)
                    {772,786},//June (early summer)
                    {769,775},//July (summer)
                    {769,775},//August (summer)
                    {772,786},//September (early fall)
                    {787,791},//October (fall)
                    {785,794},//November (fall)
                    {775,810} };//December (early winter)
                    
               
  ReefAngel.StandardHeater( Port2,heatArray[month()][0],heatArray[month()][1]);
 }//end seasonalTemps

//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function
void CheckCloud()
{

  // ------------------------------------------------------------
  // Change the values below to customize your cloud/storm effect

  // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)
  // For testing purposes, you can use 1 and cause the cloud to occur everyday
#define Clouds_Every_X_Days 1 

  // Percentage chance of a cloud happening today
  // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
#define Cloud_Chance_per_Day 50

  // Minimum number of minutes for cloud duration.  Don't use max duration of less than 6
#define Min_Cloud_Duration 6

  // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
#define Max_Cloud_Duration 15

  // Minimum number of clouds that can happen per day
#define Min_Clouds_per_Day 3

  // Maximum number of clouds that can happen per day
#define Max_Clouds_per_Day 10

  // Only start the cloud effect after this setting
  // In this example, start could after 11:30am
#define Start_Cloud_After NumMins(7,30)

  // Always end the cloud effect before this setting
  // In this example, end could before 8:00pm
#define End_Cloud_Before NumMins(20,00)

  // Percentage chance of a lightning happen for every cloud
  // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening
#define Lightning_Change_per_Cloud 55

  // Note: Make sure to choose correct values that will work within your PWMSLope settings.
  // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
  // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
    // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
  // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
    // It's a tight fit, but it did.

    //#define printdebug // Uncomment this for debug print on Serial Monitor window
  #define forcecloudcalculation // Uncomment this to force the cloud calculation to happen in the boot process. 

    
  // Add Random Lightning modes
#define Slow 0    // 5 seconds of slow lightning in the middle of a cloud for ELN style (slow response) drivers
#define Fast 1    // 5 seconds of fast lightning in the middle of a cloud for LDD style (fast response) drivers
#define Mega 2    // Lightning throughout the cloud, higher chance as it gets darker
#define Mega2 3   // Like Mega, but with more lightning
  // Set which modes you want to use
  // Example:  { Slow, Fast, Mega, Mega2 } to randomize all four modes.  
  // { Mega2 } for just Mega2.  { Mega, Mega, Fast} for Mega and Fast, with twice the chance of Mega.
byte LightningModes[] = { Fast, Mega, Mega2 };

    //ReefAngel.CustomVar[Var_StormMode]=lightningMode;
//#define Var_StormMode
  // Change the values above to customize your cloud/storm effect
  // ------------------------------------------------------------
  // Do not change anything below here

  static byte cloudchance=255;
  static byte cloudduration=0;
  static int cloudstart=0;
  static byte numclouds=0;
  static byte lightningchance=0;
  static byte cloudindex=0;
  static byte lightningstatus=0;
  static int LastNumMins=0;
  static byte lightningMode=0;
  static boolean chooseLightning=true;
  
  static time_t DelayCounter=millis();    // Variable for lightning timing.  
  static int DelayTime=random(1000);      // Variable for lightning timimg.
  
  // Every day at midnight, we check for chance of cloud happening today
  if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
    if (cloudchance==255)
#else
    if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
#endif
    {
      randomSeed(millis());    // Seed the random number generator
      //Pick a random number between 0 and 99
      cloudchance=random(100); 
      // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today
      if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;
      // Check if today is day for clouds. 
      if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0; 
      // If we have cloud today
      if (cloudchance)
      {
        // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day
        numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
        // pick the time that the first cloud will start
        // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day. 
        cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0; 
      }
    }
  // Now that we have all the parameters for the cloud, let's create the effect

  
  if (cloudchance)
  {
    //is it time for cloud yet?
    if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
    {
      DaylightPWMValue=ReversePWMSlope(cloudstart,cloudstart+cloudduration,DaylightPWMValue,0,180);
      if (chooseLightning) { lightningMode=LightningModes[random(100)%sizeof(LightningModes)]; chooseLightning=false; } 
        switch (lightningMode) {
        case Mega:
        // Lightning chance from beginning of cloud through the end.  Chance increases with darkness of cloud.
      if (lightningchance && random(ReversePWMSlope(cloudstart,cloudstart+cloudduration,100,0,180))<1 && (millis()-DelayCounter)>DelayTime)
      {
        int a=random(1,5);    // Pick a number of consecutive flashes from 1 to 4.  
        for (int i=0; i<a; i++)
        {
          analogWrite(daylightPWMPin,random(DaylightPWMValue*2.55,255));    // Flash on
          int randy=random(20,80);    // Random number for a delay
          if (randy>71) randy=((randy-70)/2)*100;    // Small chance of a longer delay
          delay(randy);                // Wait from 20 to 69 ms, or 100-400 ms
          analogWrite(daylightPWMPin,DaylightPWMValue*2.55);      // Flash off
          delay(random(30,50));                // Wait from 30 to 49 ms 
          wdt_reset();
        }
        DelayCounter=millis();    // If we just had a round of flashes, then lets put in a longer delay
        DelayTime=random(1000);   // of up to a second for dramatic effect before we do another round. 
      }
      break;
       case Mega2:
        // Higher lightning chance from beginning of cloud through the end.  Chance increases with darkness of cloud.
      if (lightningchance && random(ReversePWMSlope(cloudstart,cloudstart+cloudduration,100,0,180))<2 && (millis()-DelayCounter)>DelayTime)
      {
        int a=random(1,5);    // Pick a number of consecutive flashes from 1 to 4.  
        for (int i=0; i<a; i++)
        {
          analogWrite(daylightPWMPin,random(DaylightPWMValue*2.55,255));    // Flash on
          int randy=random(20,80);    // Random number for a delay
          if (randy>71) randy=((randy-70)/2)*100;    // Small chance of a longer delay
          delay(randy);                // Wait from 20 to 69 ms, or 100-400 ms
          analogWrite(daylightPWMPin,DaylightPWMValue*2.55);      // Flash off
          delay(random(30,50));                // Wait from 30 to 49 ms 
          wdt_reset();
        }
        DelayCounter=millis();    // If we just had a round of flashes, then lets put in a longer delay
        DelayTime=random(1000);   // of up to a second for dramatic effect before we do another round. 
      }
      break;
        case Fast:
        // 5 seconds of lightning in the middle of the cloud
      if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5 && (millis()-DelayCounter)>DelayTime)
      {
        int a=random(1,5);    // Pick a number of consecutive flashes from 1 to 4.  
        for (int i=0; i<a; i++)
        {
          analogWrite(daylightPWMPin,random(DaylightPWMValue*2.55,255));    // Flash on
          int randy=random(20,80);    // Random number for a delay
          if (randy>71) randy=((randy-70)/2)*100;    // Small chance of a longer delay
          delay(randy);                // Wait from 20 to 69 ms, or 100-400 ms
          analogWrite(daylightPWMPin,DaylightPWMValue*2.55);      // Flash off
          delay(random(30,50));                // Wait from 30 to 49 ms 
          wdt_reset();
        }
        DelayCounter=millis();    // If we just had a round of flashes, then lets put in a longer delay
        DelayTime=random(1000);   // of up to a second for dramatic effect before we do another round. 
      }
      break;
        case Slow:
        // Slow lightning for 5 seconds in the middle of the cloud.  Suitable for slower ELN style drivers
         if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5) 
      {
        if (random(100)<20) lightningstatus=1; 
        else lightningstatus=0;
        if (lightningstatus)
        {
          DaylightPWMValue=100; 
        }
        else 
        {
          DaylightPWMValue=0;
        }
        delay(1);
      }
        break;
        default:
        break;
      }
    } else {
      chooseLightning=true; // Reset the flag to choose a new lightning type
    }
    
    if (NumMins(hour(),minute())>(cloudstart+cloudduration))
    {
      cloudindex++;
      if (cloudindex < numclouds)
      {
        cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  }
  
  if (LastNumMins!=NumMins(hour(),minute()))
  {
    LastNumMins=NumMins(hour(),minute());
    //ReefAngel.LCD.Clear(255,0,62,132,132);
  //ReefAngel.LCD.DrawText(0,255,5,62,"C");
  //ReefAngel.LCD.DrawText(0,255,11,62,"00:00");
  //ReefAngel.LCD.DrawText(0,255,45,62,"L");
  //ReefAngel.LCD.DrawText(0,255,51,62,"00:00");
    if (cloudchance && (NumMins(hour(),minute())<cloudstart))
    {
      int x=0;
      if ((cloudstart/60)>=10) x=11; else x=17;
      //ReefAngel.LCD.DrawText(0,255,x,62,(cloudstart/60));
      if ((cloudstart%60)>=10) x=29; else x=35;
      //ReefAngel.LCD.DrawText(0,255,x,62,(cloudstart%60));
    }
    //ReefAngel.LCD.DrawText(0,255,90,62,cloudduration);
    if (lightningchance) 
    {
      int x=0;
      if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;
      //ReefAngel.LCD.DrawText(0,255,x,62,((cloudstart+(cloudduration/2))/60));
      if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;
      //ReefAngel.LCD.DrawText(0,255,x,62,((cloudstart+(cloudduration/2))%60));
    }
  }   
}

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
}


Re: DCPump code acting funny on portal

Posted: Mon Sep 23, 2019 1:22 pm
by rimai
I would revisit this random mode selection.
The logic seems weird.