PWM output not matching schedule

New members questions
Post Reply
rufessor
Posts: 293
Joined: Tue Oct 25, 2011 7:39 am

PWM output not matching schedule

Post by rufessor »

Hi All-

This is really the first major operating code I am trying to load and it has the cloud feature in it. I have changed things to match my setup which is.

Channel 0 PWM output Rightside NW
Channel 1 PWM ouput Rightside RB
Channel 2 PWM output Leftside NW
Channel 3 PWM output Rightside RB

I have the following as my PDE, in entirety. It loads fine and when I run it I get at 10:45 pm only the left side NW lights on low and PWM output voltage at all terminals is as follows.

PWM 0= 0V
1=0V
2=3.3V
3=0V

The pde is here in its entirety. When I use a RaGEN pde FOR pwm CONTROL I get accurate dimming control over all 4 modules, the whites drop at about 23 % to flicker the Blues about 10% to flicker. So I know that my PWM controller can output all range voltage to all channels...

Oh... the controller knows the correct time if your wondering.


Also... screwing around with this a little bit I had just the left side blues on, but none of the other lights on. When I set it to run lights to 11:50 pm i.e. 23,50 everywhere and reload...

only the left side RB and NW string power on... at 4.97 V each... which is channel 2 and 3 so what happened to 0 and 1???????????

Can you help tell me why... I think the code looks ok in terms of definig the on off times but I am not absolutely certain, but I think its right. Also, this would be inconsistent with the behavior I am seeing, both NW strings are set the same for me in sunrise sunet table but only L side lights....

or none of hte right side seems to work...
channel 0 1 seems to not output no matter what I do to the inputs but I have made them the same as whats working for chanel 2 3 and that does not fix it so I am kinda lost.

Code: Select all

// Autogenerated file by RAGen (v1.1.0.126), (01/14/2012 21:47)
// RA_011412_2147.pde
//
// This version designed for v0.8.5 Beta 17 or later

/* The following features are enabled for this PDE File: 
#define DisplayImages
#define WavemakerSetup
#define DateTimeSetup
#define VersionMenu
#define ATOSetup
#define MetalHalideSetup
#define DirectTempSensor
#define DisplayLEDPWM
#define StandardLightSetup
#define SaveRelayState
#define PWMEXPANSION
*/


#include <ReefAngel_Features.h>
#include <ReefAngel_Globals.h>
#include <ReefAngel_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <ReefAngel_EEPROM.h>
#include <ReefAngel_NokiaLCD.h>
#include <ReefAngel_ATO.h>
#include <ReefAngel_Joystick.h>
#include <ReefAngel_LED.h>
#include <ReefAngel_TempSensor.h>
#include <ReefAngel_Relay.h>
#include <ReefAngel_PWM.h>
#include <ReefAngel_Timer.h>
#include <ReefAngel_Memory.h>
#include <ReefAngel.h>

//*********************************************************************************************************************************
//Start of PWM Expansion Code Header

// This is just how we are going to reference the PWM expansion ports within the code.
// You can change the labels if you would like, just as long as they are changed all throughout the code too.
#define LEDPWM0 0
#define LEDPWM1 1
#define LEDPWM2 2
#define LEDPWM3 3
#define LEDPWM4 4
#define LEDPWM5 5

// Initial values to all 6 channels at startup. They will always be 0.
byte PWMChannel[]={
  0,0,0,0,0,0};

//End of PWM Expansion Code Header
//*********************************************************************************************************************************



void setup()
{
    ReefAngel.Init();  //Initialize controller

    // Ports that are always on
    ReefAngel.Relay.On(Port8);
}

void loop()
{
    // Specific functions
    ReefAngel.ShowInterface();
    ReefAngel.StandardATO(Port1);
    ReefAngel.StandardLights(Port2);
    ReefAngel.MHLights(Port3);
    ReefAngel.Wavemaker1(Port4);
    ReefAngel.Wavemaker2(Port5);
    ReefAngel.StandardFan(Port6);
    ReefAngel.StandardHeater(Port7);
    
   // Calculate your regular sunrise/sunset PWM value
 
  PWMChannel[LEDPWM0]=PWMSlope(9,00,19,30,23,50,20,PWMChannel[LEDPWM0]);
  PWMChannel[LEDPWM1]=PWMSlope(7,30,23,00,10,50,20,PWMChannel[LEDPWM1]);
  PWMChannel[LEDPWM2]=PWMSlope(9,00,19,30,23,50,20,PWMChannel[LEDPWM2]);
  PWMChannel[LEDPWM3]=PWMSlope(7,30,23,00,10,50,20,PWMChannel[LEDPWM3]);
  CheckCloud();
  PWMExpansion(LEDPWM0,int(2.55*PWMChannel[LEDPWM0]));
  PWMExpansion(LEDPWM1,int(2.55*PWMChannel[LEDPWM1]));
  PWMExpansion(LEDPWM2,int(2.55*PWMChannel[LEDPWM2]));
  PWMExpansion(LEDPWM3,int(2.55*PWMChannel[LEDPWM3]));
//  ReefAngel.LCD.DrawText(0,255,120,120,PWMChannel[LEDPWM1]);
//  ReefAngel.LCD.DrawText(0,255,35,120,PWMChannel[LEDPWM1]);
//  ReefAngel.LCD.DrawText(0,255,65,120,PWMChannel[LEDPWM2]);
//  ReefAngel.LCD.DrawText(0,255,95,120,PWMChannel[LEDPWM3]);
   
}


//*********************************************************************************************************************************
//Start of PWM slope function code designed for the PWM Expansion module
void PWMExpansion(byte cmd, byte data)
{ 
Wire.beginTransmission(8); // transmit to device #2
Wire.send('$'); // sends $ 
Wire.send('$'); // sends $ 
Wire.send('$'); // sends $ 
Wire.send(cmd); // sends a value 
Wire.send(data); // sends 255 
Wire.endTransmission(); // stop transmitting
}
//End of PWM slope function code designed for the PWM Expansion module
//*********************************************************************************************************************************



//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function
void CheckCloud()
{

  // ------------------------------------------------------------
  // Change the values below to customize your cloud/storm effect

  // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)
  // For testing purposes, you can use 1 and cause the cloud to occur everyday
#define Clouds_Every_X_Days 1 

  // Percentage chance of a cloud happening today
  // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
#define Cloud_Chance_per_Day 100

  // Minimum number of minutes for cloud duration.  Don't use max duration of less than 6
#define Min_Cloud_Duration 7

  // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
#define Max_Cloud_Duration 15

  // Minimum number of clouds that can happen per day
#define Min_Clouds_per_Day 3

  // Maximum number of clouds that can happen per day
#define Max_Clouds_per_Day 5

  // Only start the cloud effect after this setting
  // In this example, start could after 11:30am
#define Start_Cloud_After NumMins(9,30)

  // Always end the cloud effect before this setting
  // In this example, end could before 8:00pm
#define End_Cloud_Before NumMins(18,30)

  // Percentage chance of a lightning happen for every cloud
  // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening
#define Lightning_Change_per_Cloud 100

  // Channels used by the actinic LEDs on the PWM Expansion module
  // These channels will not be dimmed when the cloud effect is triggered
  // Number is a binary form. B001100 means channel 2 and 3 are used for actinics
#define Actinic_Channels B010100

  // Channels used by the daylight LEDs on the PWM Expansion module
  // These channels will be used for the spike when lightning effect is triggered
  // Number is a binary form. B000011 means channel 0 and 1 are used for daylights
#define Daylight_Channels B101000

  // Note: Make sure to choose correct values that will work within your PWMSLope settings.
  // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
  // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
    // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
  // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
    // It's a tight fit, but it did.

    //#define printdebug // Uncomment this for debug print on Serial Monitor window
  #define forcecloudcalculation // Uncomment this to force the cloud calculation to happen in the boot process. 


    // Change the values above to customize your cloud/storm effect
  // ------------------------------------------------------------
  // Do not change anything below here

  static byte cloudchance=255;
  static byte cloudduration=0;
  static int cloudstart=0;
  static byte numclouds=0;
  static byte lightningchance=0;
  static byte cloudindex=0;
  static byte lightningstatus=0;
  static int LastNumMins=0;
  // Every day at midnight, we check for chance of cloud happening today
  if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
    if (cloudchance==255)
#else
    if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
#endif
    {
      //Pick a random number between 0 and 99
      cloudchance=random(100); 
      // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today
      if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;
      // Check if today is day for clouds. 
      if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0; 
      // If we have cloud today
      if (cloudchance)
      {
        // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day
        numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
        // pick the time that the first cloud will start
        // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day. 
        cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  // Now that we have all the parameters for the cloud, let's create the effect

  if (cloudchance)
  {
    //is it time for cloud yet?
    if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
    {
      // let's go through all channels to pick which ones will be dimmed
      for (int a=0;a<6;a++)
      {
        if (bitRead(Actinic_Channels,a)==0)
        {
          // this will slope down the channel from the current PWM to 0 within 3minutes.
          // then it will stay at 0 for the duration of the cycle
          // and finally slope up from 0 to PWM value within 3 minutes
          // it is basically an inversed slope
          PWMChannel[a]=ReversePWMSlope(cloudstart,cloudstart+cloudduration,PWMChannel[a],0,180);
        }
      }
      if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5) 
      {
        for (int b=0;b<6;b++)
        {
          if (bitRead(Daylight_Channels,b)==1)
          {
            if (random(100)<20) lightningstatus=1; 
            else lightningstatus=0;
            if (lightningstatus) PWMChannel[b]=100; 
            else PWMChannel[b]=0;
            //delay(10);
          }
          else
          {
            PWMChannel[b]=20;
          }
        }
      }
    }
    if (NumMins(hour(),minute())>(cloudstart+cloudduration))
    {
      cloudindex++;
      if (cloudindex < numclouds)
      {
        cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  }
  
  if (LastNumMins!=NumMins(hour(),minute()))
  {
    LastNumMins=NumMins(hour(),minute());
    ReefAngel.LCD.Clear(255,0,120,132,132);
    ReefAngel.LCD.DrawText(0,255,5,120,"C");
    ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
    ReefAngel.LCD.DrawText(0,255,45,120,"L");
    ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
    if (cloudchance && (NumMins(hour(),minute())<cloudstart))
    {
      int x=0;
      if ((cloudstart/60)>=10) x=11; else x=17;
      ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
      if ((cloudstart%60)>=10) x=29; else x=35;
      ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
    }
    ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
    if (lightningchance) 
    {
      int x=0;
      if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;
      ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
      if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;
      ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
    }
  }   
}

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
}
rufessor
Posts: 293
Joined: Tue Oct 25, 2011 7:39 am

Re: PWM output not matching schedule

Post by rufessor »

might have an issue with features file... checking now hold on worrying..
rufessor
Posts: 293
Joined: Tue Oct 25, 2011 7:39 am

Re: PWM output not matching schedule

Post by rufessor »

It does not seem to be that but here is current features.h file
/*
* Copyright 2010-11 Curt Binder
*
* Licensed under the Apache License, Version 2.0 (the "License")
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/


#ifndef __REEFANGEL_FEATURES_H__
#define __REEFANGEL_FEATURES_H__

#define SIMPLE_MENU
#define wifi
#define DisplayLEDPWM
#define PWMEXPANSION
#define VersionMenu

#endif // __REEFANGEL_FEATURES_H__
rufessor
Posts: 293
Joined: Tue Oct 25, 2011 7:39 am

Re: PWM output not matching schedule

Post by rufessor »

Oh.. more information so you dont have to look at the whole thing. I did not write any of this code really, its a RAgen PDE that I copied the cloud.pde (from a post attachment by Roberto) into. I changed the way the PWM slope is done to correspod to my times and flicker points, and I changed the lines about Actinic/daylight channels and as far as I know not much else. I copied a features.h file as the one RAgen makes pushes the files over memory limit with the cloud feature in it as has been posted before so I used the features.h file Binder posted to help someone else.

This morning at sunrise channel 2 (NW) was on at the correct time for the RB channels but only channel 2 so clearly comm to the PWM module is wrong as it was supposed to be channel 1,3 this morning and then 0,2.... seems like only 1 channel comes on... I must have done something because when I reload the RAgen PDE for PMW and LEDdisplay I can turn them all back on to light the tank today so its not hardware thats for sure :) Just me!

Thanks
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: PWM output not matching schedule

Post by rimai »

I can see these 2 lines need to be changed:

Code: Select all

#define Actinic_Channels B010100
#define Daylight_Channels B101000
The binary number starts on the right and not the left.
They should be:

Code: Select all

#define Actinic_Channels B001010
#define Daylight_Channels B000101
Try this first.
But I don't think this is the problem though.
I need to look more closely at the code.
Roberto.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: PWM output not matching schedule

Post by rimai »

Image
Did you connect like in this photo?
Channel 0 is the furthest away from the +12VDC.
Roberto.
rufessor
Posts: 293
Joined: Tue Oct 25, 2011 7:39 am

Re: PWM output not matching schedule

Post by rufessor »

I believe i have it wrong which would explain much. Fixing now I bet code is fine but for binary issues. thanks. will post if further issues else consider it fixed I bet its this.
Post Reply