Bus Lock Issues

[rimai]

That's what it is supposed to do.
But it should upload in the middle.
Ahh..
Did you remove the RF module when uploading the code?

[Marshall O]

That's what it is supposed to do.
But it should upload in the middle.
Ahh..
Did you remove the RF module when uploading the code?

Negative I have tried it at least 10 times. I even tried uploading the original firmware (RF_Update), and it does the same.


C:\Users\ohearn\Documents\Arduino\Original RF Firmware>avrdude -Cavrdude.conf -v
-patmega328p -carduino -P//./COM3 -b115200 -D -Uflash:w:RF_Update.hex:i

avrdude: Version 6.0, compiled on Apr 6 2012 at 19:29:19
Copyright (c) 2000-2005 Brian Dean, http://www.bdmicro.com/
Copyright (c) 2007-2009 Joerg Wunsch

System wide configuration file is "avrdude.conf"

Using Port : \\.\COM3
Using Programmer : arduino
Overriding Baud Rate : 115200
Rebooting Reef Angel Controller
avrdude: stk500_getsync(): not in sync: resp=0x20

avrdude done. Thank you.

Microsoft Windows [Version 6.1.7601]
Copyright (c) 2009 Microsoft Corporation. All rights reserved.

C:\Users\ohearn\Documents\Arduino\Original RF Firmware>

I'm assuming if it worked correctly, it would do something besides saying "not in sync", correct?

[rimai]

You must remove the rf module to upload codes

[Marshall O]

You must remove the rf module to upload codes

Sorry, I guess I did not understand your original question. I can't remember if the RF module was installed when I last uploaded my code. So I just did it again, with the RF module removed. I still could not get the RF module itself updated, but if your fix to the RF.cpp works, then I guess it won't matter anyways.

I will update either if I get another Bus Lock, or hopefully later on tonight with some success!

[rimai]

It is very important to remove the ecotech RF board from the module prior to updating the module or it will definitely fail.
Make sure to detach it and put it aside.

[Marshall O]

It is very important to remove the ecotech RF board from the module prior to updating the module or it will definitely fail.
Make sure to detach it and put it aside.

Again, I misunderstood what you were asking! Now I understand I removed the Ecotech board, did the update (which of course now worked fine!), and reinstalled it. I guess I should be good to go now.

So sorry about the misunderstanding of physically removing the Ecotech board. Thank you so much for all of your help though!

[Marshall O]

Following up on this, the firmware update works as it should, checking for Bus Locks every 5 minutes and then clearing. My question is, does the Bus Lock turn on relays for other people? Some of the times it just locks, and does not turn on or off any relays. Other times, it will turn on some or all relays that are off. This caused me to already have to change out my ATO pump, as it was dumping in gallons of water when the relay kicked on and stayed on for a couple of minutes before the bus lock was cleared. That and it is turning on my lights at times when then should be off. Last night they came on at about 9:45PM. Normally when the bus lock clears, it turns them back off. This time, they stayed on. I had to manually turn them off around 10:15PM after it was clear they were not turning back off. I am not sure if it changed the time on my controller, or what the problem was (I did it from my phone). When I woke up this morning, they were back to running in auto (and so they were off).

I am going to be going away on vacation for a week shortly. I certainly don't want to be worried about my lights being locked on throughout the night. That has already happened to me in the past, and I ended up losing a lot of corals. So, I am just seeing if this happens to anyone else, and if there is any kind of a fix.

[rimai]

This is definitely not normal.
I think the bus lock is messing with your clock and that's why the lights kicked on.
But, you are getting way too many bus locks.
Are you using the original USB cable that came with the modules?
What other modules do you have?

[Marshall O]

This is definitely not normal.
I think the bus lock is messing with your clock and that's why the lights kicked on.
But, you are getting way too many bus locks.
Are you using the original USB cable that came with the modules?
What other modules do you have?

Yes, I am using all original USB cables that were supplied. I have the WiFi attachment, expansion hub, single water level, and RF module. I got at least 18 bus locks yesterday (I setup and email notification yesterday morning for it). I turned the email notification off this morning as I was getting way too many emails!

[rimai]

Yeah, I know. I looked at your history.
Does the problem persist if you remove the RF module?

[Marshall O]

As far as I know, yes. I only removed it when I was trying to update the firmware, but I did not have any bus locks during that time. If I do get a bus lock, I can just unattach the USB on the RF and it immediately clears it. I have tried three different ports on the expansion hub (I am not plugged into the side, as some saw less issues with it plugged in there), but this has not made a difference.

[rimai]

Ok, let me try using a different library. Give me a couple days.

[Marshall O]

Thanks Roberto!!

[rimai]

Ok, let's try this one.
Let me know how it goes.

[lnevo]

Roberto any improvements to this one or something specific for Marshall?

[rimai]

No improvements. I just used a different I2C library to see if the interferences go away. The bus locks are coming externally from something that is causing the signal to deteriorate.

[Marshall O]

Ok, let's try this one.
Let me know how it goes.

Thanks Roberto! I will do this tonight when I get home, and then update tomorrow

[Marshall O]

Well, the update did not go well. It immediately locked, and didn't clear itself. Tried again (I installed the original firmware, then re-installed the new update), and same thing. Immediately locked. So I re-installed the bus lock fix in the meantime. The only thing I can think of that would be causing my interference may be the microinverters for my photo-voltaic system. From the manual: "This equipment generates, uses and can radiate radio frequency energy..."

[rimai]

Are you using the RF module for Radions or just vortech?

[Marshall O]

Are you using the RF module for Radions or just vortech?

Just Vortechs. (2) MP40s, (2) MP10s.

[rimai]

Something is not making sense.
If you disconnect the rf module from the hub and plug it back in, it should blink red three times and go off.
Does it eventually change colors (after a minute or so) or it stays off all the time?

[Marshall O]

Something is not making sense.
If you disconnect the rf module from the hub and plug it back in, it should blink red three times and go off.
Does it eventually change colors (after a minute or so) or it stays off all the time?

It blinks red 3 times, then immediately goes to the color of the mode I want to run in. It stays lit all the time.

I believe I have not gotten any locks for maybe 24 hours now. However, my Vortechs do not respond to the mode shown all of the time. They go into feeding mode no problem, and respond to changes to the internal memory, but nothing that I coded. I have them set to go to NutrientTransport mode at night. The controller says it is in NTM, however the Vortechs stay in whatever the last mode they were in. Very weird.

[rimai]

Can I see your entire code?
It was not supposed to light up after the 3 blinks.

[Marshall O]

Sorry for the delay in sending this to you, but here it is:

Code: Select all

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <ReefAngel.h>

void setup()
{
  ReefAngel.Init(); // Initialize Controller
  ReefAngel.Use2014Screen();
  ReefAngel.AddStandardMenu();
  ReefAngel.AddDateTimeMenu();  
  ReefAngel.AddWaterLevelExpansion(); // Water Level Expansion Module
  ReefAngel.FeedingModePorts = Port5Bit; // Turn off Port 5 (skimmer, carbon reactor) when Feeding Mode is activated
  ReefAngel.WaterChangePorts = Port1Bit | Port5Bit | Port7Bit | Port8Bit; // Turn off Ports 1 (ATO), 5 (skimmer/reactor, etc), 7 (heater) and 8 (return pump, powerhead) when Water Change Mode is activated
  ReefAngel.OverheatShutoffPorts = Port4Bit; // Turn off Ports 4 when overheat occurs
  ReefAngel.LightsOnPorts = Port3Bit | Port4Bit; // Turn on/off Ports 3 & 4 when Light On/Off menu option is selected
  ReefAngel.OverheatProbe = T2_PROBE; // Use Temperature probe 2 to check for overheat
  ReefAngel.TempProbe = T2_PROBE;
  ReefAngel.Relay.On(Port8); // Always on
  ReefAngel.Relay.On(Port6);
  ReefAngel.Relay.On(Port5);
}

void loop()
{
  ReefAngel.Portal("Marshall%20O",""); // Note I deleted my password to post this
  
  ReefAngel.WaterLevelATO(Port1,800,60,63); // On at 60% and Off at 63%, timeout 800 seconds
  
  ReefAngel.StandardLights(Port3,60); // Actinic Lights set for 60 minute offset from daylights
  ReefAngel.StandardLights(Port4); // Daylight Lights
  //ReefAngel.StandardLights(Port6,05,30,23,30); // Moon Lights on at 530A, off at 1130P
  ReefAngel.StandardHeater(Port7); // Heater
  ReefAngel.StandardFan(Port2); // Fans
  ReefAngel.Relay.DelayedOn(Port5, 60); //delay skimmer 1 hr after feed/water change
  if (ReefAngel.Params.Temp[T1_PROBE||T2_PROBE]>778) ReefAngel.Relay.Off(Port7);
  if (ReefAngel.Params.Temp[T2_PROBE]>790||ReefAngel.Params.Temp[T2_PROBE]<755) ReefAngel.PWM.SetActinic(100); else ReefAngel.PWM.SetActinic(0);
  //if (!ReefAngel.HighATO.IsActive()) ReefAngel.PWM.SetDaylight(100); else ReefAngel.PWM.SetDaylight(0);
  if (!ReefAngel.HighATO.IsActive()) ReefAngel.Relay.Off(Port1); 
  if (ReefAngel.LowATO.IsActive() || !ReefAngel.HighATO.IsActive()) ReefAngel.PWM.SetActinic(100); else ReefAngel.PWM.SetActinic(0);
    
  if (ReefAngel.DisplayedMenu!=FEEDING_MODE || ReefAngel.DisplayedMenu!=WATERCHANGE_MODE)
  {
    if (hour()>=22 && hour()<=23)
    {
      ReefAngel.RF.UseMemory=false;
      ReefAngel.RF.SetMode(NutrientTransport,100,10);
    }
     else if (hour()>=0 && hour()<2)
    {
      ReefAngel.RF.UseMemory=false;
      ReefAngel.RF.SetMode(NutrientTransport,100,10);
    }
    else if (hour()>=2 && hour()<7)
    {
      ReefAngel.RF.UseMemory=false;
      ReefAngel.RF.SetMode(TidalSwell,50,0);
    }
    else
    {
      ReefAngel.RF.UseMemory=true;
     }
  }

  
  ReefAngel.ShowInterface(); // Display everything on the LCD screen
}

[rimai]

Ok, I was able to figure out why your LED was lighting up.
There was a bug in the libraries.
Please open the RF.cpp again.
Remove the comment you added to the line the previous time.
Then you need to update the line right below it.
Both lines should look like this:

Code: Select all

			if (millis()%60000<200) lastcrc=-1;
			if ( (lastcrc!=(byte)(mode+speed+duration)) || millis()<5000 )

Save and upload the code to your RA again.
Let me know how it goes.

[Lionfan]

Is any of this common with my problems, Roberto?

[weaverwf]

Roberto, it looks like the second close paren after "duration" prematurely closes off the if clause.

[weaverwf]

Never mind delete previous

[rimai]

Is any of this common with my problems, Roberto?

No. this is for a bus lock issue he's been having.

[Marshall O]

Ok, I was able to figure out why your LED was lighting up.
There was a bug in the libraries.
Please open the RF.cpp again.
Remove the comment you added to the line the previous time.
Then you need to update the line right below it.
Both lines should look like this:

Code: Select all

			if (millis()%60000<200) lastcrc=-1;
			if ( (lastcrc!=(byte)(mode+speed+duration)) || millis()<5000 )

Save and upload the code to your RA again.
Let me know how it goes.

Thanks Roberto! I will do this tonight and then update you.