Wave patterns

[Robert1969]

Is the definition part everything between { } ?

[enigma32]

And the line above it.
He's saying the whole function no longer needs to be manually added in your code:

Code: Select all

    byte ReefCrestMode(byte WaveSpeed, byte WaveOffset, boolean PulseSync)
{
  static unsigned long lastwavemillis=millis();
  static int newspeed=WaveSpeed;
  if ((millis()-lastwavemillis) > 5000)
  {
    if (random(100)<50) newspeed--; else newspeed++;
    newspeed=constrain(newspeed,WaveSpeed-WaveOffset,WaveSpeed+WaveOffset);
    newspeed=constrain(newspeed,0,100);
    lastwavemillis=millis();
  }  
  if (PulseSync)
    return newspeed;
  else
    return WaveSpeed-(newspeed-WaveSpeed);
}

[Robert1969]

Ok I'm confused. What do I add then if I want the reef crest mode?

[lnevo]

You just use the function...you no longer need to have the whole section in your code that was in the last post

[Robert1969]

What part is the function. Sorry for all the noob questions most of the time I feel so lost with this thing

[lnevo]

The function is part of the libraries.

You use it by setting the port connected to your pump with the result of the function like this...

ReefAngel.PWM.SetActinic( ReefCrestMode(45,10,true));

You put a line like that inside your loop section.

[Robert1969]

Oh ok. Thank you

[Sacohen]

So If I wanted a Long Pulse and my WP40 is plugged into my daylights i would do something like this...

ReefAngel.PWM.SetDaylight( LongPulseMode(45,10,true));

What is the 45,10 the pump speed and wave length?
Also what does the true do?

[lnevo]

45 is the % 10 is the time between pulses and true means sync.

If you had two pumps you could set one true and one false for an anti sync effect.

[Sacohen]

That's what I thought.
45 is the % of speed.
What format is the time in, seconds or milliseconds?

[rimai]

It's in the original post
Each function has a different unit. Short Pulse and NTM are milliseconds, but Long Pulse is seconds.
Also, your code is missing one parameter. It's supposed to be 4 total.
Check the original post.

[Sacohen]

Sorry Roberto. Like I said I'm a complete noob to coding.

It looks like I left out the PulseMinSpeed or PulseMaxSpeed.

So would it be like this?
ReefAngel.PWM.SetDaylight( LongPulseMode(45,70,10,true));

[rimai]

Yes
You got it

[Sacohen]

Thanks for making me figure it out.
Again "Teach a man to fish".

[SaltyGXP]

So I've scanned throughout the last 5 or so pages and didn't see it. Is there ant way we can get Lagoon mode add to the wave patterns?

Thanks
Dustin

[rimai]

Well, Lagoon is nothing more than reefcrest with a very close min and max range.

[Sacohen]

Ok I got most everything setup last night.
There's only a couple of things I need to tackle still, but the first and what seems to be the easiest is hooking up and coding the WP40.

I know all the wave patterns are on the first page (Thank Roberto), but can someone equate them to the different modes on the WP40?

H: High, constant, non-variable flow (13,000 LPH)

L: Low, constant, non-variable flow at a third of the speed (4,300 LPH)

W1: Short pulses which, when timed correctly will create a back and forth motion and form a gentle standing wave in your tank. Adjust the controller to change the speed of the pulses and vary the size of the wave according to your tank.

W2 & W3: Pump gradually speeds up and slows down incrementally to create a varied flow pattern. Adjustable to form the wave best suited to your tank.

Else: Reef Stream Mode, a mixed, changing pattern that creates a random flow cycle similar to what you would find in a natural reef.

I currently use W1 on a slow speed 16-18V and a medium wave length.

[coolbird]

Could I just ask as I may be looking at this a bit to simplistically:

I have 2x wp40's that I want to connect to my light ports and for example I want a long pulse minimum power at 10% maximum at 50 lasting for 20 seconds each anti-sync I would enter the below into my loop?

ReefAngel.PWM.SetDaylight( LongPulseMode(10,50,20,true))
ReefAngel.PWM.SetActinic( LongPulseMode(10,50,20,false))

Thanks
Dave

[Sacohen]

I'm just getting into coding and by no means am an expert, but this looks correct.

The criteria for Long Pulse is...

Long Pulse
PulseMinSpeed - % for minimal speed
PulseMaxSpeed - % for maximum speed
PulseDuration - Duration (seconds) in which each pulse will be held. The pump will stay at minimal speed for PulseDuration and will stay at maximum speed for PulseDuration.
PulseSync - true if you want to sync pumps to same cycle. one false and one true if you want to anti-sync pumps.

[coolbird]

I'm just getting into coding and by no means am an expert, but this looks correct.

The criteria for Long Pulse is...

Long Pulse
PulseMinSpeed - % for minimal speed
PulseMaxSpeed - % for maximum speed
PulseDuration - Duration (seconds) in which each pulse will be held. The pump will stay at minimal speed for PulseDuration and will stay at maximum speed for PulseDuration.
PulseSync - true if you want to sync pumps to same cycle. one false and one true if you want to anti-sync pumps.

Hi Sacohen

Its how I see it as well; I should thank you really as you have been asking all the questions I would have put

We will see what the masters of the "black art" say, I hope we are both not mistaken

Thanks again

Dave

[rimai]

Could I just ask as I may be looking at this a bit to simplistically:

I have 2x wp40's that I want to connect to my light ports and for example I want a long pulse minimum power at 10% maximum at 50 lasting for 20 seconds each anti-sync I would enter the below into my loop?

ReefAngel.PWM.SetDaylight( LongPulseMode(10,50,20,true))
ReefAngel.PWM.SetActinic( LongPulseMode(10,50,20,false))

Thanks
Dave

Yeap, that's all you need

[coolbird]

Could I just ask as I may be looking at this a bit to simplistically:

I have 2x wp40's that I want to connect to my light ports and for example I want a long pulse minimum power at 10% maximum at 50 lasting for 20 seconds each anti-sync I would enter the below into my loop?

ReefAngel.PWM.SetDaylight( LongPulseMode(10,50,20,true))
ReefAngel.PWM.SetActinic( LongPulseMode(10,50,20,false))

Thanks
Dave

Yeap, that's all you need

You mean I got something right Roberto I will try not to make a habit out of it,,,,,,,thanks

[rimai]

Well... Almost there.... You just missed the ; at the end of the 2 lines, but the idea was there and I consider this just a typo....

[lnevo]

I still forget parens, semicolons, braces all the time...thats what compiler errors are for

[coolbird]

Well... Almost there.... You just missed the ; at the end of the 2 lines, but the idea was there and I consider this just a typo....

Nope Roberto no typo I had missed them off serves me right for being smug with my minor success.

[oscarinw]

Hey folks, not trying to hijack your thread here. I need a bit of help with my controllable pump... Still trying to figure out if it's doable and if so how... I can't post links or send private messages I'm such a noob, but if you search for 'Help to connect a certain controllable pump to my ATO DWM' you will find it.
Thanks!

[coolbird]

Could I just ask as I may be looking at this a bit to simplistically:

I have 2x wp40's that I want to connect to my light ports and for example I want a long pulse minimum power at 10% maximum at 50 lasting for 20 seconds each anti-sync I would enter the below into my loop?

ReefAngel.PWM.SetDaylight( LongPulseMode(10,50,20,true))
ReefAngel.PWM.SetActinic( LongPulseMode(10,50,20,false))

Thanks
Dave

Yeap, that's all you need

You mean I got something right Roberto I will try not to make a habit out of it,,,,,,,thanks

I seem to be missing something here I am using the lines below but I was trying to get the pumps to alternate and as I understand it to do this you need one on false and the other on true (or have I got this wrong,,,again)

Doesn't seem to matter whether I have them false and true or both on true they seem to be coming on for 20 seconds at the set percentage then both dropping back to the reduced powerthen after 20 seconds back up to 30% again!!

ReefAngel.PWM.SetDaylight( LongPulseMode(10,30,20,true));
ReefAngel.PWM.SetActinic( LongPulseMode(10,30,20,false));

Any advice would be welcome.

Thanks
Dave

[rimai]

Yes, your code looks correct.
What do you see in the screen for AP/DP?? Are they alternating?

[coolbird]

Yes, your code looks correct.
What do you see in the screen for AP/DP?? Are they alternating?

On the ra screen its just showing the both solid at 30, not changing at all either of them!!

Edit:
When you run through the wizard am i supposed to change anything in the light settings?

[rimai]

Oh, I know now what is happening.
I don't think the pump can go much lower than 30%.
So, anything lower than 30% is capped at 30%.
If people that have been using this pump can confirm that the pump can indeed go lower than 30%, please let me know and I'll certainly change the libraries.