Issues I've seen in the current Dev Library.

Related to the development libraries, released by Curt Binder
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

For the record I like 3% is a perfect amount :)

Roberto,

What else is left for us to release 1.1.11? Are there still hardware support items that you're dependent on for release? I haven't seen any bugs at this point other than to confirm the ph/date&time issue I had.

I think we should add a Release_Notes.txt file in the repo so we can all start working on our contrib items in one place. That would taunt me to actually add things there.

I know a few people are testing but we should probably also make an official call for additional beta testers.

Is there portal support still pending for things (threshold settings?)

I know we talked about doing some redesign on some things like threshold and offsets per channel in the PWM library...lets get 1.1.11 out so we can start on those for 1.1.12 :)

Anything I missed?
User avatar
Sacohen
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL

Re: Issues I've seen in the current Dev Library.

Post by Sacohen »

The only thing I know about for the Portal was the server authentication. Roberto may already have that set up in then next version of the Portal.
We also need to get with Reeftronics to set up for that feature or else you lose connectivity with them.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

I don't think there is anything pending except for making sure it is working.
Can you add the release notes file to the github?
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Issues I've seen in the current Dev Library.

Post by lnevo »

Cool. I'll add the file and review the commits to see what can start going in. I'll get that other stuff verified too.

Steve, for reeftronics you should be able to add http authentication in the URL for your controller. Its not a portal issue they poll you directly. Just ask them to change the URL to:

http://user:password@your.ip.address:2000/r99
User avatar
Sacohen
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL

Re: Issues I've seen in the current Dev Library.

Post by Sacohen »

I know it's not a Portal issue.
I was saying that according to Roberto, the current Portal is not set for the server authentication.
I was also saying that Reeftronics would need something similar, but I can email Russ and see if he can do that with the URL.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

That should work you can test that too to make sure the URL pulls up properly. He might have a problem storing it but i doubt it. He just uses php so shouldn't be a big deal.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

Any issue to use the README.md file for the release notes? Not sure if it's there for something like the mainpage.h :)
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

Whatever you have on readme, gets displayed on the main page of github.com

Sent from my Galaxy S5 with Tapatalk
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

Well, I've created an initial stab at the release notes. I've made a pull request for it. You can track the branch "release" in my repo if you want to work on it until it's merged.

Ahh.. so I'll revert and move it to a separate file. :)

Edit: Updated. Also incremented version in ReefAngel.h to 1.1.1
User avatar
cosmith71
Posts: 1437
Joined: Fri Mar 29, 2013 3:51 pm
Location: Oklahoma City

Re: Issues I've seen in the current Dev Library.

Post by cosmith71 »

I had this in the Reef Angel Status thread, but it's more appropriate here.
cosmith71 wrote:Possible bug? Library or programming issue?

On the dimming expansion screen:

Channel 0 is at 0%. I override to value x. Value changes to **x%. Clear override. Value changes to x% (not zero) and light stays on at x%. The only way to get it back to zero is to override to 0 and then clear.

I'm using this:

Code: Select all

  ReefAngel.PWM.Channel0PWMSlope(30);

--Colin
To which Lee replied:
lnevo wrote:
Expected behavior

Right which only sets the channel during your StandardLights time otherwise it uses the channels previous value.
I'm wondering if it would be better if this returned the min % in the off hours instead of the previous value?

--Colin
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

Same issue in the current libraries so I think better to keep in the previous thread.

min% may be the way to go, BUT changing the behavior may break backwards compatibility with some INO.

Overall you need a one liner to get the behavior you want..

Code: Select all

  for(int i=0;i<4;i++) { ReefAngel.PWM.SetChannel(i,0); }
phrusher
Posts: 65
Joined: Fri May 25, 2012 12:22 am

Re: Issues I've seen in the current Dev Library.

Post by phrusher »

I switched to dev for a while to try out RANet but I encountered a few issues that made me switch back. Perhaps it's a coincidence and something happened to my hardware when installing RANet or maybe it's something I should have done when switching release but I though I should report here anyway.

1. Water level (single) went cray cray on a few spontaneous occasions. Watching the reported level on my RA and it kind of jumped on what looked like a random walk.
It didn't last for very long when I noticed it but the problem was that my ATO started filling up because I'm using WaterLevelATO. On one of the occasions it emptied my ATO reserve when I was at work while jumping around.

2. I could not clear ATO or overheat either on the RA or with the Android app. Whenever I try to clear the red light turns off for fraction of a second and then back on again, stuck on "Press to clear" screen.

3. Relay overrides set are removed when exiting feeding mode. Kind of annoying having an unreliable ATO and not be able to set the relay to off permanently.
(Although after switching back I realized that the same behavior is in the stable release but now my ATO works so I don't need it so bad. After playing around a bit more I suspect that it's the ports in FeedingModePorts that are unable to keep overrides?)
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

Thanks for reporting your findings.
1. This is the first occasion someone is reporting this.
2. Are you sure it was an ATO or overheat and not some other flag? If it was overheat and the temperature is still above the limit, it would cause it to do just like you mentioned. Same thing for a bus lock or leak detection.
3. I'm pretty sure this has been fixed for a while and the current release has this too.
Roberto.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

Regarding #3, I think you have ATO port set in the FeedingModePorts, don't you?
If so, yes, it will clear, because it applies the FeedingModePorts mask and we never store previous state of the off mask. It will keep the override for any other port that is not in the FeedingModePorts though.
Roberto.
phrusher
Posts: 65
Joined: Fri May 25, 2012 12:22 am

Re: Issues I've seen in the current Dev Library.

Post by phrusher »

rimai wrote:2. Are you sure it was an ATO or overheat and not some other flag? If it was overheat and the temperature is still above the limit, it would cause it to do just like you mentioned. Same thing for a bus lock or leak detection.
I'm not sure what flag it was. I suspected ATO because of the random levels so that's when I first noticed that I could not clear it. I had to restart my RA to exit the menu and clear the flag. The next time I encountered the issue I tried to clear overheat just to see what would happen and the same thing happened. I was stuck on "Clear overheat" and could not exit even though my temp was well below threshold.
rimai wrote:Regarding #3, I think you have ATO port set in the FeedingModePorts, don't you?
If so, yes, it will clear, because it applies the FeedingModePorts mask and we never store previous state of the off mask. It will keep the override for any other port that is not in the FeedingModePorts though.
Yes the ATO is one of the FeedingModePorts and I finally figured out that it didn't store the state on those ports. Not really the behavior I expected but now I know :)
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

Roberto,

The fix I tried to add for backward compatibility to maintain the PH calibration and Date/Time setup menu is NOT working. So this definitely needs to be revisited. Just want to throw this out there as a reminder.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

Can you post the code you tested with?
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

void MenuEntry7() {
ReefAngel.SetupCalibratePH();
ReefAngel.DisplayedMenu = ALT_SCREEN_MODE;
}

void MenuEntry9() {
ReefAngel.SetupDateTime();
ReefAngel.DisplayedMenu = ALT_SCREEN_MODE;
}

Pretty straight forward. It compiles but when I choose those menu options I don't get the calibration screen.... now on the other hand, when I initiate the ph calibration from the Universal App, it works just fine. I'll have to play with my test unit and see if I can fix it.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

I think you are missing the init of the menus.
Try this code:

Code: Select all

#include <Salinity.h>
#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <ReefAngel.h>

prog_char menu1_label[] PROGMEM = "Calibrate pH";
prog_char menu2_label[] PROGMEM = "Date/Time";
PROGMEM const char *menu_items[] = {
  menu1_label, menu2_label};

void MenuEntry1()
{
  ReefAngel.SetupCalibratePH();
}
void MenuEntry2()
{
  ReefAngel.SetupDateTime();
}

void setup()
{
  ReefAngel.Init();  
  ReefAngel.InitMenu(pgm_read_word(&(menu_items[0])),SIZE(menu_items));
}

void loop()
{
  ReefAngel.ShowInterface();
}
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

No, I have that in my setup already. My custom menu is work fine other than the ph and date/time which don't. I'll do some testing later this week to see what's going on.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

The issue was this:

ReefAngel.DisplayedMenu = ALT_SCREEN_MODE;

I guess that's no longer needed... not sure how many people are using this, but was trying to avoid backward compatiblity issues. But glad my patch is OK :)
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Issues I've seen in the current Dev Library.

Post by rimai »

Awesome!!!
I'm going to prep for release then :)
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

Ok, make sure you take the pull request with functions for the phExpansion and the changelog. I'm also going to add the auto-update for SunLocation if the ActinicOffset is changed.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Issues I've seen in the current Dev Library.

Post by lnevo »

Ok all the pull requests are submitted. :)
Post Reply