Serious Bug in ph calibration code

Related to the development libraries, released by Curt Binder

Posts: 140
Joined: Tue Oct 04, 2011 5:49 am
PostPosted: Sun Aug 02, 2015 12:21 pm
Hi,

There is a bug in the current pH expansion calibration code. If you look at ReefAngel_1.5_LCD.h you see:

Code: Select all
        InternalMemory.PHMin_write(PHExpMin);
        InternalMemory.PHMax_write(PHExpMax);


What should be there is:

Code: Select all
        InternalMemory.PHExpMin_write(PHExpMin);
        InternalMemory.PHExpMax_write(PHExpMax);


This bug causes the main ph values to be overwritten when you try to calibrate the ph expansion.

Don

Posts: 12327
Joined: Fri Mar 18, 2011 6:47 pm
PostPosted: Sun Aug 02, 2015 7:43 pm
Good catch :)
Thanks for the contribution!!
Roberto.

Return to Development Libraries

Who is online

Users browsing this forum: No registered users and 2 guests

cron