Serious Bug in ph calibration code

Related to the development libraries, released by Curt Binder
Post Reply
dedvalson
Posts: 140
Joined: Tue Oct 04, 2011 5:49 am

Serious Bug in ph calibration code

Post by dedvalson »

Hi,

There is a bug in the current pH expansion calibration code. If you look at ReefAngel_1.5_LCD.h you see:

Code: Select all

        InternalMemory.PHMin_write(PHExpMin);
        InternalMemory.PHMax_write(PHExpMax);
What should be there is:

Code: Select all

        InternalMemory.PHExpMin_write(PHExpMin);
        InternalMemory.PHExpMax_write(PHExpMax);
This bug causes the main ph values to be overwritten when you try to calibrate the ph expansion.

Don
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Serious Bug in ph calibration code

Post by rimai »

Good catch :)
Thanks for the contribution!!
Roberto.
Post Reply