U-App Repo

Community contributed apps
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

U-App Repo

Post by sbidny »

@Roberto, can you confirm where I can find the repo for the currently running version of U-App (http://forum.reefangel.com/uapp/)? The running version says v2.0.6, but the master branch at GitHub (https://github.com/reefangel/U-App-2.0) seems to show 2.0.4. I have a few tweaks that I'm hoping to submit as a pull request in the near future.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

BTW, the changes I have include:

[*]Menu item to show current controller time
[*]Show default labels instead of "null" if not available (which also fixes the issue with the Radion labels always showing "null" if you download labels from the portal)
[*]Allow adjusting the feeding timer from the internal memory screen
[*]Show the current mode (e.g., feeding, water change)
[*]Retry logic if HTML GET fails, which occurs quite often with my controller
[*]Turn the "Flags" tab red if there are currently active flags

I am also trying to get a change in to improve the ability for the app to automatically connect for cloud updates. I often find myself having to hit "Refresh" to get this going.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: U-App Repo

Post by lnevo »

Great to see some work going on to improve the U-App. Nice updates, I hope to see them merged soon!

For the retry, it's super-frustrating that if my screen locks and I open the phone back right to the u-app, it loses the connection to the cloud and issuing any relay commands time-out. I then have to refresh the screen by clicking the relay tab again or switching to status and back. Either way it's super annoying. I hope some of that logic improves things like that.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

Sorry... I forgot to push it.
Just did it :)
I hope it doesn't mess things up with your changes you made already.
Roberto.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

I was able to merge your changes in, and it seems to be working so far. Your changes have fixed the cloud stuff, so I now have the ability to make some changes there. I'll see what I can do to improve the connection logic.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

I have also now added a way to change the Radion settings in internal memory, since the RF screen only allows you to override the values.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

I have created a pull request for my updates. So far, I haven't solved the cloud connection issue, but I'll try to tackle that next. Want to get the current set of features out there first.

Roberto, I haven't been able to compile Cordova for iOS yet, so if you want to do this, please go ahead. I know that we're not currently releasing platform-specific apps right now, so maybe this isn't important.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

Looks awesome!!!
I'll check it out.
Not much worried on the iOS specific.
Roberto.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

Have now added a basic reconnect logic when you lose connection (likely due to inactivity timeout). This may help with the need to reconnect every time you return to the app. Fingers crossed. I'll try to test at home tonight.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

Seems that the reconnect logic is working. I do think I broke something with default labels, so I’ll take a quick look at that. Rest is looking good.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

Fixed the issue with default labels. Been using this all weekend, and I've been happy with the results. No longer need to hit refresh or change screens to reconnect, which is a big improvement in usability. Let me know if you need anything else.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

Trickling in more updates:

Fixed issued with dimming and RF sliders always showing 50% instead of actual percent value
Fixed issue with “Disconnected” not showing properly when connection lost
Fixed issue with “OK” not always showing properly after internal memory update

Plan to target the timeout issues when you try to update values to their same value next.

Roberto, do you think we’ll be able to get out the new version soon? Thanks!
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

Yeah I can do it.
I was just waiting for all the updates to be completed.
But I'll release one out today and if there is more, I'll release them later.
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: U-App Repo

Post by lnevo »

sbidny wrote:Trickling in more updates:
Plan to target the timeout issues when you try to update values to their same value next.
Similar issue with the relays if they reset. For instance, If i override a port on and my code put's it back to auto but then starts a timer or calls another function, you'll get the timeout there as well.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

Roberto, I noticed a bug caused by my cleanup of onMessageArrived(). It's a small change, and I have submitted a pull request to pick up the fix. I'd recommend pulling it in as soon as possible. It causes a timeout to occur every time you change mode or try to clear a flag, even though these actions succeed. Thanks!
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: U-App Repo

Post by lnevo »

Is there an easy way to confirm if I have your version @sbidny?
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

lnevo wrote:Is there an easy way to confirm if I have your version @sbidny?
There are a few ways, but the easiest is probably looking at the top of the menu. It should say “Reef Angel Uapp 2.0.7.”

If it doesn’t, try clearing your browser’s cache. Just need to do for reefangel.com, but if you do for everything, that should work too.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: U-App Repo

Post by lnevo »

Thanks that helped. I had to delete and recreate the bookmark (I think) on my phone. Will try a different way next time.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

Changes pushed.
Roberto.
sbidny
Posts: 123
Joined: Mon Sep 17, 2012 12:41 pm
Location: Lincoln Park, Chicago, IL, USA 60614

Re: U-App Repo

Post by sbidny »

Thanks, Roberto. We probably need to do something different with the file versioning to ensure browser caches are being refreshed when new files are available. Will look into it.

In the meantime, it’s likely that many folks are still using the old version until their browser cache expires or is manually cleared.
abavery
Posts: 9
Joined: Sat Dec 20, 2014 2:43 pm

Re: U-App Repo

Post by abavery »

I've got 2.0.8 running on the site, and it looks like I'm getting some sort of default labels when I try to download them. Any fix for that in place or should I go fix it on GitHub? Thanks
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

I am able to download labels just fine.
Roberto.
abavery
Posts: 9
Joined: Sat Dec 20, 2014 2:43 pm

Re: U-App Repo

Post by abavery »

Maybe I'm doing it wrong. I don't have the cloud module, so I just punch in my username. It downloads labels, but they're not my labels. I get ATO Solenoid, RODI to SW, SW Mixing Pump, ATO Pump, Saltwater Pump, Waste Pump, Heater 1, and Skimmer Cleaner. I'm guessing those are some kind of defaults. Anything I can do to troubleshoot? Thanks
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

When you login to the portal, is it not what you have?
Roberto.
abavery
Posts: 9
Joined: Sat Dec 20, 2014 2:43 pm

Re: U-App Repo

Post by abavery »

No, in the portal I have entirely different values. I have tried changing them. Removing spaces. Making them shorter. Nothing works. Although it did used to work.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

That is not what I get from the server....

Code: Select all

<R1N>Heater</R1N>
<R2N>LeftPowerhead</R2N>
<R3N>BackPowerhead</R3N>
<R4N>ProteinSkimmer</R4N>
<R5N>Refugium</R5N>
<R6N>FugeLight</R6N>
<R7N>AlkDoser</R7N>
<R8N>CaDoser</R8N>
I would suggest deleting all profiles and adding a new one again.
Roberto.
abavery
Posts: 9
Joined: Sat Dec 20, 2014 2:43 pm

Re: U-App Repo

Post by abavery »

Those are the values I am expecting. I have deleted the profile from the web app and readded it a couple times. No result. I tried in incognito mode so I'd have a fresh cache and I get the same incorrect labels. I may have to dig into the JS to see what kind of reply I'm getting to the request.
abavery
Posts: 9
Joined: Sat Dec 20, 2014 2:43 pm

Re: U-App Repo

Post by abavery »

I dug into the JS a little, and my RA.ID is null when the request is made for some reason. I'm investigating why that might be right now. I have the value set for the cloud username with no cloud password.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: U-App Repo

Post by rimai »

You can't assign cloud username nor cloud password if you don't use the cloud wifi attachment or RA Star.
You must leave those blank.
You do need the ip address and port. After the initial connection, the app will know the correct username to download the labels.
Roberto.
abavery
Posts: 9
Joined: Sat Dec 20, 2014 2:43 pm

Re: U-App Repo

Post by abavery »

Where does it get my username from? I think that must be the part I am missing.
Post Reply