Toggle problem

Requests for new functions or software apps

Posts: 6
Joined: Sat Jan 26, 2013 12:20 am
PostPosted: Sun May 05, 2013 3:21 am
I have uploaded the new library 1.0.4 and my Water change mode is not switching off the return pump and skimmer.

The lights toggle are working fine however.

I have re-installed Arduino but the problem still persists.

Any help is appreciated.

Thanks
spinev
User avatar
Posts: 1426
Joined: Fri Mar 29, 2013 3:51 pm
Location: Oklahoma City
PostPosted: Sun May 05, 2013 6:38 am
Code?

Posts: 6
Joined: Sat Jan 26, 2013 12:20 am
PostPosted: Sun May 05, 2013 7:51 am
Sorry Code below.

Port 1 is the return pump and Port 6 is the skimmer

My problem is that this was working fine before the upgrade.


////// Place global variable code above here


void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
ReefAngel.SetTemperatureUnit( Celsius ); // set to Celsius Temperature

ReefAngel.AddStandardMenu(); // Add Standard Menu

// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port1Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port1Bit | Port6Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = Port5Bit;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port4Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;
// Set the Overheat temperature setting
InternalMemory.OverheatTemp_write( 260 );


// Ports that are always on
ReefAngel.Relay.On( Port1 );
ReefAngel.Relay.On( Port4 );
ReefAngel.Relay.On( Port7 );
ReefAngel.Relay.On( Port8 );

////// Place additional initialization code below here


////// Place additional initialization code above here
}

void loop()
{
ReefAngel.StandardLights( Port3,0,0,0,0 );
ReefAngel.StandardLights( Port6,0,0,0,0 );
ReefAngel.StandardLights( Port5,17,0,20,0 );
ReefAngel.PWM.SetDaylight( PWMParabola(13,0,21,0,0,90,0) );
ReefAngel.PWM.SetActinic( PWMParabola(13,0,21,0,0,90,0) );
////// Place your custom code below here


////// Place your custom code above here

// This should always be the last line
ReefAngel.ShowInterface();
}
User avatar
Posts: 5362
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Sun May 05, 2013 9:03 am
Make sure no overrides are set and why are you using standard light schedule for your skimmer? Whats on Port3? Has the same configuration as skimmer..

Posts: 6
Joined: Sat Jan 26, 2013 12:20 am
PostPosted: Sun May 05, 2013 12:39 pm
So my setting is as follows:

Port 1 - Return Pump (always on) - to be swiched off with water change.
Port 2 - Vacant (relay not working)
Port 3 - AI leds (with AI controller) - Always on
Port 4 - Vacant
Port 5 - Refugium Lights ( toggle with Lights on/off function)
Port 6 - Skimmer (Always on)
Port 7 - Hydor Wavemaker (Always on)
Port 8 - Vacant (always on - using water pump for top up RO water) float switches not yet installed - switching on/off manually.
User avatar
Posts: 1426
Joined: Fri Mar 29, 2013 3:51 pm
Location: Oklahoma City
PostPosted: Sun May 05, 2013 1:00 pm
I would probably just start over with the wizard.

Also make sure you're on library version 1.0.5. It's the latest.

--Colin

Posts: 6
Joined: Sat Jan 26, 2013 12:20 am
PostPosted: Mon May 06, 2013 3:55 am
Will try again using the wizard tonight and let you know.

Thanks

Posts: 6
Joined: Sat Jan 26, 2013 12:20 am
PostPosted: Mon May 06, 2013 11:17 am
I have once again tried to do the code from the beginning but to no avail. When going to menu and press on water change mode I am hearing the click from the relay box but the power is still on both on skimmer and return pump. Do this have something to do with the relays?

I have also used the storm/cloud command. I am having an error on the display C0...0 L17:56. This is changing to C0...0 L18:15

any help how to remove this?

thanks

see below code:

Code: Select all

//The following features are enabled for this File:
#define VersionMenu
#define DisplayLEDPWM
#define wifi
#define WDT
#define NUMBERS_8x16
#define SIMPLE_MENU


#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <ReefAngel.h>

byte ActinicPWMValue=0;
byte DaylightPWMValue=0;

////// Place global variable code below here

void DrawCustomMain()
{
  byte x = 6;
  byte y = 2;
  byte t;
  char text[7];
 

  ReefAngel.LCD.DrawDate(6, 2);
  ReefAngel.LCD.Clear(COLOR_BLACK, 1, 11, 132, 11);
  pingSerial();
 
  ReefAngel.LCD.DrawText(0,255,3,17,"Neville's 500Ltr Reef");
 
 // ReefAngel.LCD.DrawText(0,255,20,57,MoonPhaseLabel());

  pingSerial();

  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 6, 90, "--------------------");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 6, 126, "--------------------");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 93, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 103, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 113, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 123, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 93, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 103, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 113, "|");
  //ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 123, "|");
 
 

  ReefAngel.LCD.DrawText(0,255,10,30,"Main Tank");
  ConvertNumToString(text, ReefAngel.Params.Temp[T1_PROBE], 10);
  ReefAngel.LCD.DrawLargeText(COLOR_BLACK, 255, 10, 40, text, Num8x16);
 
  ReefAngel.LCD.DrawText(0,255,8,68,"Refugium");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], COLOR_BLACK, 40, 68, 10);

  // ReefAngel.LCD.DrawText(0,255,70,68,"Temp3");
  // ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T3_PROBE], COLOR_BLACK, 99, 68, 10);
  pingSerial();

  ReefAngel.LCD.DrawText(0,255,100,30,"pH");
  ConvertNumToString(text, ReefAngel.Params.PH, 100);
  ReefAngel.LCD.DrawLargeText(COLOR_BLACK, 255, 85, 40, text, Num8x16);
  pingSerial();

  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 77, TempRelay);

  pingSerial();
 
  ReefAngel.LCD.DrawText(0,255,8,100, "WHITE"); 
  ReefAngel.LCD.DrawText(COLOR_BLACK,255,15,119, ReefAngel.PWM.GetDaylightValue());
 
  ReefAngel.LCD.DrawText(0,255,88,100, "R.BLUE"); 
  ReefAngel.LCD.DrawText(COLOR_BLACK,255,90,119, ReefAngel.PWM.GetActinicValue());
 

}
void DrawCustomGraph()
{
}

////// Place global variable code above here


void setup()
{
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
    ReefAngel.SetTemperatureUnit( Celsius );  // set to Celsius Temperature

    ReefAngel.AddStandardMenu();  // Add Standard Menu

    // Ports toggled in Feeding Mode
    ReefAngel.FeedingModePorts = Port6Bit;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port1Bit | Port5Bit | Port6Bit | Port7Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = Port5Bit;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = 0;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T1_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 265 );


    // Ports that are always on
    ReefAngel.Relay.On( Port1 );//Return Pump
    ReefAngel.Relay.On( Port3 );//AI Leds
    ReefAngel.Relay.On( Port6 );//Skimmer
    ReefAngel.Relay.On( Port7 );//Hydor Wavemaker
    ReefAngel.Relay.On( Port8 );//Overflow Pump

    ////// Place additional initialization code below here
   

    ////// Place additional initialization code above here
}

void loop()
{
  // Calculate your regular sunrise/sunset PWM value
  ActinicPWMValue=PWMSlope(12,00,21,0,1,85,0,ActinicPWMValue);
  DaylightPWMValue=PWMSlope(12,00,21,0,0,85,0,DaylightPWMValue);
  CheckCloud();
  ReefAngel.PWM.SetActinic(ActinicPWMValue);
  ReefAngel.PWM.SetDaylight(DaylightPWMValue); 
 
    ReefAngel.StandardLights( Port5,20,0,1,0 );
    ReefAngel.PWM.SetDaylight( PWMParabola(12,0,21,0,0,85,0) );
    ReefAngel.PWM.SetActinic( PWMParabola(12,0,21,0,1,85,0) );
   
   
    ////// Place your custom code below here
   
   
    ////// Place your custom code above here
 

 
  // This should always be the last line
  ReefAngel.ShowInterface();
}
//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function
void CheckCloud()
{

  // ------------------------------------------------------------
  // Change the values below to customize your cloud/storm effect

  // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)
  // For testing purposes, you can use 1 and cause the cloud to occur everyday
#define Clouds_Every_X_Days 1

  // Percentage chance of a cloud happening today
  // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
#define Cloud_Chance_per_Day 100

  // Minimum number of minutes for cloud duration.  Don't use max duration of less than 6
#define Min_Cloud_Duration 7

  // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
#define Max_Cloud_Duration 10

  // Minimum number of clouds that can happen per day
#define Min_Clouds_per_Day 3

  // Maximum number of clouds that can happen per day
#define Max_Clouds_per_Day 5

  // Only start the cloud effect after this setting
  // In this example, start could after 01:00pm
#define Start_Cloud_After NumMins(13,00)

  // Always end the cloud effect before this setting
  // In this example, end could before 7:00pm
#define End_Cloud_Before NumMins(19,00)

  // Percentage chance of a lightning happen for every cloud
  // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening
#define Lightning_Change_per_Cloud 100

  // Note: Make sure to choose correct values that will work within your PWMSLope settings.
  // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
  // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
    // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
  // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
    // It's a tight fit, but it did.

    //#define printdebug // Uncomment this for debug print on Serial Monitor window
  #define forcecloudcalculation // Uncomment this to force the cloud calculation to happen in the boot process.


  // Change the values above to customize your cloud/storm effect
  // ------------------------------------------------------------
  // Do not change anything below here

  static byte cloudchance=255;
  static byte cloudduration=0;
  static int cloudstart=0;
  static byte numclouds=0;
  static byte lightningchance=0;
  static byte cloudindex=0;
  static byte lightningstatus=0;
  static int LastNumMins=0;
  // Every day at midnight, we check for chance of cloud happening today
  if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
    if (cloudchance==255)
#else
    if (hour()==0 && minute()==0 && second()==1 && cloudchance==255)
#endif
    {
      //Pick a random number between 0 and 99
      cloudchance=random(100);
      // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today
      if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;
      // Check if today is day for clouds.
      if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;
      // If we have cloud today
      if (cloudchance)
      {
        // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day
        numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
        // pick the time that the first cloud will start
        // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
        cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  // Now that we have all the parameters for the cloud, let's create the effect

  if (cloudchance)
  {
    //is it time for cloud yet?
    if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
    {
      DaylightPWMValue=ReversePWMSlope(cloudstart,cloudstart+cloudduration,DaylightPWMValue,0,180);
      if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)
      {
        if (random(100)<20) lightningstatus=1;
        else lightningstatus=0;
        if (lightningstatus)
        {
          DaylightPWMValue=100;
          ActinicPWMValue=100;
        }
        else
        {
          DaylightPWMValue=0;
          ActinicPWMValue=0;
        }
        delay(1);
      }
    }
    if (NumMins(hour(),minute())>(cloudstart+cloudduration))
    {
      cloudindex++;
      if (cloudindex < numclouds)
      {
        cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  }
 
  if (LastNumMins!=NumMins(hour(),minute()))
  {
    LastNumMins=NumMins(hour(),minute());
    ReefAngel.LCD.Clear(255,0,120,132,132);
    ReefAngel.LCD.DrawText(0,255,5,120,"C");
    ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
    ReefAngel.LCD.DrawText(0,255,45,120,"L");
    ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
    if (cloudchance && (NumMins(hour(),minute())<cloudstart))
    {
      int x=0;
      if ((cloudstart/60)>=10) x=11; else x=17;
      ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
      if ((cloudstart%60)>=10) x=29; else x=35;
      ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
    }
    ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
    if (lightningchance)
    {
      int x=0;
      if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;
      ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
      if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;
      ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
    }
  }   
}

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
   
}

User avatar
Posts: 1426
Joined: Fri Mar 29, 2013 3:51 pm
Location: Oklahoma City
PostPosted: Mon May 06, 2013 11:25 am
Have you tried moving your skimmer and return to different outlets? Might be relay issues.

--Colin

Posts: 12308
Joined: Fri Mar 18, 2011 6:47 pm
PostPosted: Mon May 06, 2013 11:36 am
Does it turn on/off with portal or smart phone app?
Try the ControllerTester code: File->Sketchbook->Example Codes
Roberto.
Next

Return to Requests

Who is online

Users browsing this forum: No registered users and 1 guest

cron