I can't find the WifiSendAlert() function in the libraries.

Requests for new functions or software apps
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by rimai »

Ok, I've made the required changes.
Can you try again?
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

Working!
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

I don't think it is working for me. Where do I change the time interval with .SetDelay(int)? I can't find this anywhere.

Lee,
Did you have to change any of the original code to get it working?
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

Its part of the object..so if you declared atoAlarm then atoAlarm.SetDelay(30);

I didn't change any of the code. The code was good :) i need to upload my version with the force option tomorrow and see if that part is working. That might make debug easier..
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

Lee,
The problem that I am encountering now seems to be that it will not send the portal key with the request.

I have the portal key specified in the INO.

ReefAngel.Portal( "mudcat1","xxxxxxxxxx" );

When the float switch is triggered. This gets sent...

GET /status/wifialert.aspx?id=mudcat1&key=&msg=Sump_WaterLevel_too_high

The portal key is missing "&key=" How did you get past that issue?

Thanks,
John
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

I didn't get that far...i don't use a key. Your using the copy/paste code above? I'll check in a little while if i missed something.

For the record, long term the second arg will be for force not for key...that will get stored in library when you do SendPortal
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

Oh just re-read your post. If your doing copy / paste the. You will need to do

atoAlarm.Send("msg","key");

Edit: forgot the function :) syntax updated.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

So, this is starting to seriously call for a class to manage all the dosing pumps and a class for each dosing pump with its characteristics (calibration volume, rate factor, timers, messages, etc.)

Anyway, here's my first run at a calibraton routine. The way it works is that I have a virtual outlet that I turn on to calibrate. This could just as easily be a menu mode... When that outlet is on, the calibration starts. For each pump defined it waits for the maskon to happen. when you turn it on it assumes you are filling a measuring cup to whatever amount you want. At that point it records the time. When the mask off happens it compares the times and gets the total running time. It then pages you with the result. If you need to turn the pump back on for a little more, it will track the running time. When your happy with the result, the last page you get will be the total time.

You can then put that time into a memory variable and that is used by my previous dosing pump routine to calculate the dosage. Since you've also stored the amount of liquid you are measuring we can properly calculate this. Also, the units can be whatever.. it could just as easily be 5 gallons in 200 seconds or 100ml in an hour.

What is now important is that you can now enter the number of ml or gallons or whatever you want and over how ever many doses you want per day and it's all calculated... :) Let's see how it tests out.

I'm also going to add logging that we started working on for kirkwood. What I would like a separate function that is logging the relay and storing the total time it is on and send me the total each hour.

Anyway, without further-ado. This code is compiled but not yet tested. It will be uploaded after this post :)

Code: Select all

// Run calibration routine,
void CalibrateDPumps() {
  const byte numPumps=2;
  byte pump[numPumps] = { DPump1, DPump2 };
  static time_t pumpTimer[numPumps];
  static WiFiAlert calibrateMsg;
  char msg[16];
  
  if (ReefAngel.Relay.Status(VO_Calibrate)) { 
    for (int i=0;i < numPumps;i++) {
      if (ReefAngel.Relay.isMaskOn(pump[i])) {
        pumpTimer[i]=now()-pumpTimer[i];
        ReefAngel.Relay.Override(pump[i],2); 
        ReefAngel.Relay.On(pump[i]);
      } 
      
      if (ReefAngel.Relay.isMaskOff(pump[i]) && pumpTimer[i]>0) {
        ReefAngel.Relay.Override(pump[i],2);
        ReefAngel.Relay.Off(pump[i]);
        pumpTimer[i]=now()-pumpTimer[i];
        sprintf(msg,"Pump%d+:+%d",i+1,pumpTimer[i]); 
        calibrateMsg.Send(msg,true);
      }
    }
  } else {
    for (int i=0;i< numPumps;i++) {
      pumpTimer[i]=0;
    }
  }    
}
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:Oh just re-read your post. If your doing copy / paste the. You will need to do

atoAlarm.Send("msg","key");

Edit: forgot the function :) syntax updated.
Lee,
That fixed it. I can now send SMS texts from the Reef Angel. :D

Thanks for all of your help and patience.

John
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

Lee,
One more question. What interval does the 30 specify in this statement?
atoAlarm.SetDelay(30);

Is it 30 minutes, 30 seconds or 30 milliseconds? And does this delay the interval between when it will send the alert? I just tested the Sump too hot code and it SPAMMED me with several messages. I need to tune something.

Thanks,
John
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

30 seconds. It should only send after 30 seconds.
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

Lee,
I am curious if you have been receiving frequent false alarms from WifiAlert. I have been using it for a few days now and I receive several SMS alerts each day when I know that it should not be triggered that frequently. I am monitoring the status of both the ATO Low and ATO High float switches and sending the SMS text based upon the status. The ATO low float has been physically flipped so that the indicated display status on the portal displays green. The float switch is fully submerged in my ATO container and is triggered when the container is empty. I was receiving SMS text alerts every few minutes so I had to disable the code. The ATO High float switch is mounted at the top of the sump to monitor the water level and to prevent a sump overflow. It should not be triggered but I am receiving SMS alerts every few hours (but I don't see a pattern). I realize that you are not monitoring float switches but was curious if you are receiving false alerts too.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

I do have an alert on my float switches and haven't had any false alerts at all. Quite the opposite...a few alerts i should have received i have not. I don't know if roberto put any time delay on the alert page or if our strings are using up too much of the serial buffer or not. It has been working well, but i wouldn't say 100% at this point.

Can you post your code so i can see how you implemented it. I can see if any hanging logic as well that may be screwing up.
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:I do have an alert on my float switches and haven't had any false alerts at all. Quite the opposite...a few alerts i should have received i have not. I don't know if roberto put any time delay on the alert page or if our strings are using up too much of the serial buffer or not. It has been working well, but i wouldn't say 100% at this point.

Can you post your code so i can see how you implemented it. I can see if any hanging logic as well that may be screwing up.
Lee,
I also have a buzzer implemented which has been a very reliable alert for me so I have a good indicator when the float switches have been activated. I receive random SMS text alerts at all times to the extent that I have decided to disable the ATO container empty alert because it is triggered too frequently while the ATO container is actually full. Here are my code snippets...

Code: Select all

// ************ PLACE GLOBAL VARIABLE CODE BELOW HERE *******************

class WiFiAlert
{
public:
  WiFiAlert();
  void Send(char *message, char *key);
  inline void Send(char *message) { Send(message,""); }
  inline void SetDelay(int delay) { AlertDelay=delay; }
private:
  int AlertDelay;
  time_t LastAlert;
  boolean IsAlert();
  void WiFiSendAlert(char *message, char *key);  
};

WiFiAlert::WiFiAlert()
{
  AlertDelay=900;
  LastAlert=0;
}

boolean WiFiAlert::IsAlert()
{
  if (now()-LastAlert >= AlertDelay) 
  {
    return true;
  }
  return false;
}

void WiFiAlert::Send(char *message, char *key)
{
  if (IsAlert())
  {
    LastAlert=now();
    WiFiSendAlert(message, key);
  }
}

void WiFiAlert::WiFiSendAlert(char *message, char *key)
{
  Serial.print("GET /status/wifialert.aspx?id=");
  Serial.print(ReefAngel.portalusername);
  Serial.print("&key=");
  Serial.print(key);
  Serial.print("&msg=");
  Serial.println(message);
  Serial.println("\n\n");
}

// Initialize Buzzer variables
byte buzzer=0;
byte overheatflag=0;
byte atoflag=0;

// Declare variables for Wifi Alert
static WiFiAlert sumpOverflowAlarm, tempAlarm;
static WiFiAlert atoEmptyAlarm;

void setup()
{
  
// Added buzzer 1-19-13    
// Sound buzzer if any flag is set.
// Added 1-19-13 - Uncomment when I purchase the IO expansion module.
//   buzzer = overheatflag + atoflag + iochannel0flag + iochannel1flag + iochannel2flag + iochannel3flag + iochannel4flag + iochannel5flag;
   buzzer = overheatflag + atoflag;
   if ( buzzer >= 1 ){
     buzzer = InternalMemory.read(buzzer_volume); // Set value of buzzer volume.
 } else {
     ReefAngel.PWM.SetDaylight(0);
   }  
//   Do not sound the buzzer for empty ATO reservior between 7:00 am and 10:00 pm.
   if (!ReefAngel.LowATO.IsActive() && ( hour() >= 7 && hour() < 22)) {
      ReefAngel.PWM.SetDaylight( buzzer );
      atoEmptyAlarm.SetDelay(3600); // delay SMS text alert for 1 hour.
      atoEmptyAlarm.Send("ATO_container_empty","xxxxxxxxxx");
 } else {   
      ReefAngel.PWM.SetDaylight(0);
      if (!ReefAngel.HighATO.IsActive()) { 
        ReefAngel.PWM.SetDaylight( buzzer );
        sumpOverflowAlarm.SetDelay(300); // delay SMS alert for 5 minutes.
        sumpOverflowAlarm.Send("Sump_WaterLevel_too_high","xxxxxxxxxx");
    } else {
        ReefAngel.PWM.SetDaylight(0);
      }
   }    
Thanks for your help,
John
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

So two things to check...is it just the ato empty alarm being flakey? Or both?

What is the IP the alert is coming from? I did have a false alarm early on but it was from someone or some bot clicking in this thread...i changed the url in the post and havent had any others..

We may need some logs from roberto to see if these hot queued up on his end or if he's getting valid alerts from your controller.

The code looks good at first glance.
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:So two things to check...is it just the ato empty alarm being flakey? Or both?

What is the IP the alert is coming from? I did have a false alarm early on but it was from someone or some bot clicking in this thread...i changed the url in the post and havent had any others..

We may need some logs from roberto to see if these hot queued up on his end or if he's getting valid alerts from your controller.

The code looks good at first glance.
They are both sending false alerts, but the ATO empty occurs every few minutes where the Sump overflow occurs every few hours. The buzzer works flawlessly and is triggered by the same float switches.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

Ok a few strange things i noticed.

One is you have all that code in setup() and not in loop()...not sure why that would make a difference, but something worth correcting, I had a block of code in setup and it was behaving completely different than what I'd expect.

Second you have your wifi alarm variables as globals and static which might cause it to behave strangely. Try taking off the static or leaving it but putting it inside setup or eventually to loop.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

mudcat1 wrote:They are both sending false alerts, but the ATO empty occurs every few minutes where the Sump overflow occurs every few hours. The buzzer works flawlessly and is triggered by the same float switches.
Are you sure the empty is alarming every few minutes...the overflow is the one with the 5 minute delay...
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:Ok a few strange things i noticed.

One is you have all that code in setup() and not in loop()...not sure why that would make a difference, but something worth correcting, I had a block of code in setup and it was behaving completely different than what I'd expect.

Second you have your wifi alarm variables as globals and static which might cause it to behave strangely. Try taking off the static or leaving it but putting it inside setup or eventually to loop.
Lee,
I tried to make my code similar to yours, however, I was not sure how to use the #include statement as you did so I copied the wifialert() code immediately following the include statements. I added the static declaration because I saw it in your ino but I will remove it shortly.
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:
mudcat1 wrote:They are both sending false alerts, but the ATO empty occurs every few minutes where the Sump overflow occurs every few hours. The buzzer works flawlessly and is triggered by the same float switches.
Are you sure the empty is alarming every few minutes...the overflow is the one with the 5 minute delay...
Yes, the ato empty alert was occurring more frequently than the sump overflow.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

mudcat1 wrote:
lnevo wrote:Ok a few strange things i noticed.

One is you have all that code in setup() and not in loop()...not sure why that would make a difference, but something worth correcting, I had a block of code in setup and it was behaving completely different than what I'd expect.

Second you have your wifi alarm variables as globals and static which might cause it to behave strangely. Try taking off the static or leaving it but putting it inside setup or eventually to loop.
Lee,
I tried to make my code similar to yours, however, I was not sure how to use the #include statement as you did so I copied the wifialert() code immediately following the include statements. I added the static declaration because I saw it in your ino but I will remove it shortly.
The main thing I'm concerned about is your custom code should all be inside loop() not inside setup() which is what you showed. But the static thing is easy to fix.
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

Sorry Lee, i didn't read your post closely enough. I do have my custom code in the void loop() section, I just forgot to copy it in the snippet section that I provided.

Code: Select all

    // ************ PLACE GLOBAL VARIABLE CODE BELOW HERE *******************

    class WiFiAlert
    {
    public:
      WiFiAlert();
      void Send(char *message, char *key);
      inline void Send(char *message) { Send(message,""); }
      inline void SetDelay(int delay) { AlertDelay=delay; }
    private:
      int AlertDelay;
      time_t LastAlert;
      boolean IsAlert();
      void WiFiSendAlert(char *message, char *key); 
    };

    WiFiAlert::WiFiAlert()
    {
      AlertDelay=900;
      LastAlert=0;
    }

    boolean WiFiAlert::IsAlert()
    {
      if (now()-LastAlert >= AlertDelay)
      {
        return true;
      }
      return false;
    }

    void WiFiAlert::Send(char *message, char *key)
    {
      if (IsAlert())
      {
        LastAlert=now();
        WiFiSendAlert(message, key);
      }
    }

    void WiFiAlert::WiFiSendAlert(char *message, char *key)
    {
      Serial.print("GET /status/wifialert.aspx?id=");
      Serial.print(ReefAngel.portalusername);
      Serial.print("&key=");
      Serial.print(key);
      Serial.print("&msg=");
      Serial.println(message);
      Serial.println("\n\n");
    }

    // Initialize Buzzer variables
    byte buzzer=0;
    byte overheatflag=0;
    byte atoflag=0;

    // Declare variables for Wifi Alert
    WiFiAlert sumpOverflowAlarm, tempAlarm;
    WiFiAlert atoEmptyAlarm;

    void setup()
    
    void loop()
   {
     
    // Added buzzer 1-19-13   
    // Sound buzzer if any flag is set.
    // Added 1-19-13 - Uncomment when I purchase the IO expansion module.
    //   buzzer = overheatflag + atoflag + iochannel0flag + iochannel1flag + iochannel2flag + iochannel3flag + iochannel4flag + iochannel5flag;
       buzzer = overheatflag + atoflag;
       if ( buzzer >= 1 ){
         buzzer = InternalMemory.read(buzzer_volume); // Set value of buzzer volume.
    } else {
         ReefAngel.PWM.SetDaylight(0);
       } 
    //   Do not sound the buzzer for empty ATO reservior between 7:00 am and 10:00 pm.
       if (!ReefAngel.LowATO.IsActive() && ( hour() >= 7 && hour() < 22)) {
          ReefAngel.PWM.SetDaylight( buzzer );
          atoEmptyAlarm.SetDelay(3600); // delay SMS text alert for 1 hour.
          atoEmptyAlarm.Send("ATO_container_empty","xxxxxxxxxx");
    } else {   
          ReefAngel.PWM.SetDaylight(0);
          if (!ReefAngel.HighATO.IsActive()) {
            ReefAngel.PWM.SetDaylight( buzzer );
            sumpOverflowAlarm.SetDelay(300); // delay SMS alert for 5 minutes.
            sumpOverflowAlarm.Send("Sump_WaterLevel_too_high","xxxxxxxxxx");
        } else {
            ReefAngel.PWM.SetDaylight(0);
          }
       }   
Sorry for the confusion.
John
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

Another thing that I noticed is that the time on the SMS text alert is incorrect. The text message that I receive says ...

"(Reef Angel - Alert) Reef Angel Controller AlertTime: 6/3/2013 5:46:46 PM IP Address: xxx.xxx.xxx.xxx ATO_container_empty"

The actual time is 7:46 PM. Is there a date setting that can be adjusted so that the time on the alert is correct?
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

That doesn't even make sense. Unless the float switch is getting triggered for a blip not enough to trigger the buzzer.

Can you add a Serial.println(buzzer); before the atoAlarm.Send(); and monitor for a bit through Serial Monitor?
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by rimai »

mudcat1 wrote:Another thing that I noticed is that the time on the SMS text alert is incorrect. The text message that I receive says ...

"(Reef Angel - Alert) Reef Angel Controller AlertTime: 6/3/2013 5:46:46 PM IP Address: xxx.xxx.xxx.xxx ATO_container_empty"

The actual time is 7:46 PM. Is there a date setting that can be adjusted so that the time on the alert is correct?
That would have to be modified in the server to accept GMT offset.
Currently, it will use the server's local time.
Roberto.
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:That doesn't even make sense. Unless the float switch is getting triggered for a blip not enough to trigger the buzzer.

Can you add a Serial.println(buzzer); before the atoAlarm.Send(); and monitor for a bit through Serial Monitor?
Lee,
I added the Serial.println(buzzer); before the atoAlarm.Send() and received the following output from Serial Monitor.

Code: Select all

GET /status/submitp.aspx?t1=793&t2=739&t3=0&ph=1045&id=mudcat1&em=0&rem=0&key=xxxxxxxxxx&atohigh=1&atolow=1&r=49&ron=0&roff=255&pwma=45&pwmd=0&c0=160&c1=160&c2=50&c3=0&c4=50&c5=15&c6=45&c7=45


0
GET /status/wifialert.aspx?id=mudcat1&key=xxxxxxxxxx&msg=ATO_container_empty



0
0
Eventually the ATO container was actually empty so that buzzer sounded but when I checked the Reef Angel it appeared to be locked up and the Reef Angel display was black, so I did not receive the Serial Monitor output for the actual alarm. I just cycled power to the Reef Angel and will run Serial Monitor a little longer.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

I think you are getting noise on your float switch that may not be causing your buzzer to go off...maybe for one millisecond..thats the only way those Serial.print would get triggered....unless some bracket is missing somewhere causing the code blocks to be messed up...
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

Actually you can see in the output the reason your buzzer is not going off is because the volume is 0.

However, your float is definitely getting triggered.... You can even see the Serial.print happen followed by the alarm.
You can then see subsequent triggering of the Serial.print followed by no alarm. It looks like the alert is working properly...

Code: Select all

0
GET /status/wifialert.aspx?id=mudcat1&key=xxxxxxxxxx&msg=ATO_container_empty



0
0
What condition do you set the volume of the buzzer maybe you can add the additional checks in this block of code. You could even wrap the atoEmptyAlarm.Send() like this:

if(buzzer > 0) atoEmptyAlarm.Send();

I think thats your best course of action..
mudcat1
Posts: 133
Joined: Sun Dec 09, 2012 7:23 pm

Re: I can't find the WifiSendAlert() function in the librari

Post by mudcat1 »

lnevo wrote:Actually you can see in the output the reason your buzzer is not going off is because the volume is 0.

However, your float is definitely getting triggered.... You can even see the Serial.print happen followed by the alarm.
You can then see subsequent triggering of the Serial.print followed by no alarm. It looks like the alert is working properly...

Code: Select all

0
GET /status/wifialert.aspx?id=mudcat1&key=xxxxxxxxxx&msg=ATO_container_empty



0
0
What condition do you set the volume of the buzzer maybe you can add the additional checks in this block of code. You could even wrap the atoEmptyAlarm.Send() like this:

if(buzzer > 0) atoEmptyAlarm.Send();

I think thats your best course of action..
Thanks Lee. I will try your suggestions.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: I can't find the WifiSendAlert() function in the librari

Post by lnevo »

Hey Roberto,

I've definitely been having some odd issues since adding in this code to my INO. I been having some strange issues like today I noticed that the portal hasn't updated since 6/15. I had some odd alerts at that time I was getting power outage alarms which I got to silence by resetting the expansion bus. Reading from the controller was working but obviously it was not sending to the portal.

Also, in troubleshooting code with another user and adding Serial.print's he was having the wifi not work at all. I'm wondering if there is something I'm missing after an alert to reset the wifi module or something and maybe it's not in the right state.

Anyway, the occasional wifi lockups. Any insight? I'd love to submit a patch to include this in the libs.
Post Reply