Different settings for 2 different DC Pumps.

Requests for new functions or software apps
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Fri Aug 29, 2014 9:27 am
Anything new on this front?

Lee you said you may have an idea, but I know you have very little time and may have not gotten to it.
User avatar
Posts: 5362
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Fri Aug 29, 2014 9:57 am
Looking at the code, it would be very complicated without a complete overhaul with how it's being done.

I would recommend at this point in time, to do it manually without the DCPump class if you need this functionality.
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Fri Aug 29, 2014 10:01 am
I don't need it, but it's one of those things that would be nice to be able to do.

I know a couple of others have asked about it too.

My setup is working fine.
User avatar
Posts: 5362
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Fri Aug 29, 2014 10:16 am
I think I can do something and it would greatly simplify the code, but I don't have a DCPump and no way to test it. If someone is willing to try it, I can put up a patch...
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Fri Aug 29, 2014 10:24 am
I'll try it since I'm the one asking for it.
User avatar
Posts: 5362
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Fri Aug 29, 2014 2:01 pm
Ok, Steve, you ask and you shall receive.

You can activate the offset for the AntiSync channel by specifying the percent power of the other channel by using a statement like this:
Code: Select all
    ReefAngel.DCPump.AntiSyncOffset=75;

This is a percent, so if you were at Constant 100, the Sync channel would be 100 and the AntiSync would be 75.
If you were at Constant 50, the Sync would be at 50 while the AntiSync would be at 37.5 (whatever that rounds to as a byte)

Download the branch from here

I basically cleaned up all of the case statements for each mode. It should make adding a new modes much easier. just set the Sync and AntiSync speeds accordingly and at the end of the case statement it will now call ReefAngel.SetDCPumpChannels(byte SyncSpeed,byte AntiSyncSpeed) which will apply the DCPump.Threshold and the AntiSyncOffset to the speeds and write to the proper channels. There is now also one function that writes the speed to the channel which will make it much easier to add future channels to the list. It should also make adding future channel modes easier, like back-wall or something :)

Let me know if you have any questions. This compiles for me and I have confidence that it should work.
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Fri Aug 29, 2014 2:06 pm
Thanks a lot Lee.
I'll try it tonight or over the weekend.
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Fri Aug 29, 2014 4:17 pm
I downloaded the libraries and replaced my previous version of them.

1st of all when I check the Library version it stall reads 1.1.0. Is this a change to 1.1.0 or 1.1.1?

2nd the ReefAngel.DCPump.AntiSyncOffset=75; goes in the setup section.
I put it here...

Code: Select all
// Feeeding and Water Change mode speed
ReefAngel.DCPump.FeedingSpeed=0;
ReefAngel.DCPump.WaterChangeSpeed=0;
ReefAngel.DCPump.ActinicChannel=Sync; // Now you're pump will be affected by the portal settings.
ReefAngel.DCPump.DaylightChannel=AntiSync; // Now you're pump will be affected by the portal settings.
ReefAngel.DCPump.AntiSyncOffset=75;


It seems to compile fine until it gets to the point of the random wave mode.

I get the following error "expected unqualified-id before numeric constant"

Code: Select all
// Add Else Mode definition..
const int Else=16;
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Fri Aug 29, 2014 7:34 pm
The error message came up when I was trying out the new libraries to test the DNS server.
So it's not related to what you modified for the DCPump Offset.

There is something in (or noti in) the libraries on GITHub that seems to be causing a problem with the Else Mode definition for the Random wave modes.
User avatar
Posts: 5362
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Fri Aug 29, 2014 7:47 pm
ElseMode is now built in. :)
PreviousNext

Return to Requests

Who is online

Users browsing this forum: No registered users and 1 guest

cron