Reef Angel Forum

It compiled now.

I had all that stuff at the bottom too, but there is always stuff running down there.
I pay attention to what's in the bar,

I'm going to upload it now and see how it works.

It uploaded and either it's not working properly or it;s not working because my pumps are coded to run at 30% at night.

Both the portal and Android show the pumps running at 29% rather than the 30 they are coded at during the night.

I tried it with an offset of 85% and then 50% and both the same results.

Is it because of this line of code....
that puts it at 30% between 10pm and noon.

If so why is it at 29% and not 30%?

Thanks;

I've also noticed that other readings are off.

The main WL sensor is reading 29% where it would normally be 32% where the water level in the sump sits now.

Also the multi WL sensors are not reporting now.

Can you try with Roberto's dev library and see if it's the same?

One reason it could say 29% instead of 30% is that everything is high resolution now. So there may be some rounding issues somewhere. As far as the WL, I don't believe any of that has been touched... I dont' recall seeing any commits that would change that.

Also try with the offset set to 100. That would be 100% and should have no change on what your pumps were at.

Finally one other thing to try is to run the wizard and just set a generic code (without all the random stuff and things we have in yours...) to see what the result is...

I'll try later today.
I have to try a repair a pool pump today.

Pumps are not high resolution. But I always see 29 instead of 30 on mine too. Maybe there is an off by 1 error somewhere in dev.

Good to remember...

I tried Robertos Dev Code and got the same issues.
29% of ump speeds and main WL sensor.
The Multi WL is not displaying.

Obviously I had to pull the offset out to use Roberto's libraries, but I did try it at 100% before switching to his libraries and it still showed 29%.

I haven't tried an INO from the wizard yet.

The wife it bugging me to look at the pool pump.

Wait, so you set it to 100 and it shows 29? I thought it was showing 29 when you set it to 30.

The offset of the pumps speed is set to 100% or no offset as opposed to 50% (half speed).

The 30% is what the pump is running at.
It supposed to run at 30% over night and it is running at 29%.

I noticed that too.
The high resolution may be messing with the rounding.

Yep. Probably some change I introduced for reporting the value set on the daylight and actinic channels. It multiplies by 2.55 to send the value to the port, but then divides by 2.55 to report it and I bet there's an integer truncation happening in the math that keeps it at 29 instead of 30 when it chops off 29.8 in to just 29.

Testing fix now. If it works. I'll send a pull request in to /dev. I realized that we used to divide by 2.55, now by 40.95, so it's more likely to be a round error.

OK. Think it's fixed. Submitted pull against /dev. I believe it was just a display error, not that it was actually at 29% when you asked for 30.

I think it also may not actually update the channel speed so we may not see the offset..the best way to see if its working is by looking at the pumps..i'll have to check the functionality again tonight...

The important thing about the patch too is whether or not its even setting sync/antisync right at all, because i updated the whole code that outputs to the channels. See if elsemode works as expected with offset set to 100

No, I'm wrong. It should update the anti-sync channel with the new offset speed. The time schedule should not affect it the way you have it written... confusing.

Happy Labor Day all.
Sorry didn't really get to try anything yesterday.
Lee;

You want me to try Else Mode @ 100% offset?

Is that correct?

Yes i want to know if its behaving as expected. Then try for some offsets...it should be noticable i think if you went to 50 or 25 or 10 or even 0 from there...

Ok. I'll try it later. We're having a little Labor Day partyt today, so afterwards I'll try it.

I'm having a labor day party too...it's called long postponed aquascaping day

For what it's worth, with my current version of /dev with the fix to pump speed reporting, I am now seeing 30 percent instead of 29 percent when things are set to 30, so it was integer truncation error.

Btw, there should be no reason the offset can't be greater than 100. Say you want it to be 125% you can go all the way to 255

I tried else mode with 100% offset and it didn't seem right.
The daylight channel was physically off. I put my hand in the tank and there was no movement. All displays read 0.

The actinic was full throttle.
Displays read 193 and felt like more power then I ever felt out of the WP40.

Something wasn't right.

Hmm thats odd. Will need to do some checking...

Can you try some tests with constant too, may be better able to see what's going on.

I'll try them tonight.

I think I did try Constant Mode, but I'll try it again.

Just curious the results at diff speeds on constant and with a couple diff offsets. Would help to narrow down what I may have done wrong.

Lee;

How can you have a value of over 100%?
you said in a previous post that you can enter up to 255.
Will that make the pump run faster then it should?