Different settings for 2 different DC Pumps.

Requests for new functions or software apps

Posts: 12242
Joined: Fri Mar 18, 2011 6:47 pm
PostPosted: Sun Aug 31, 2014 8:06 am
I noticed that too.
The high resolution may be messing with the rounding.
Roberto.

Posts: 263
Joined: Wed Jan 01, 2014 7:26 am
PostPosted: Sun Aug 31, 2014 9:25 am
Yep. Probably some change I introduced for reporting the value set on the daylight and actinic channels. It multiplies by 2.55 to send the value to the port, but then divides by 2.55 to report it and I bet there's an integer truncation happening in the math that keeps it at 29 instead of 30 when it chops off 29.8 in to just 29.

Posts: 263
Joined: Wed Jan 01, 2014 7:26 am
PostPosted: Sun Aug 31, 2014 9:50 am
Testing fix now. If it works. I'll send a pull request in to /dev. I realized that we used to divide by 2.55, now by 40.95, so it's more likely to be a round error.

Posts: 263
Joined: Wed Jan 01, 2014 7:26 am
PostPosted: Sun Aug 31, 2014 9:59 am
OK. Think it's fixed. Submitted pull against /dev. I believe it was just a display error, not that it was actually at 29% when you asked for 30.
User avatar
Posts: 5349
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Sun Aug 31, 2014 11:02 am
I think it also may not actually update the channel speed so we may not see the offset..the best way to see if its working is by looking at the pumps..i'll have to check the functionality again tonight...
User avatar
Posts: 5349
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Sun Aug 31, 2014 11:07 am
The important thing about the patch too is whether or not its even setting sync/antisync right at all, because i updated the whole code that outputs to the channels. See if elsemode works as expected with offset set to 100
User avatar
Posts: 5349
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Sun Aug 31, 2014 7:09 pm
No, I'm wrong. It should update the anti-sync channel with the new offset speed. The time schedule should not affect it the way you have it written... confusing.
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Mon Sep 01, 2014 5:35 am
Happy Labor Day all.
Sorry didn't really get to try anything yesterday.
Lee;

You want me to try Else Mode @ 100% offset?

Is that correct?
User avatar
Posts: 5349
Joined: Fri Jul 20, 2012 9:42 am
PostPosted: Mon Sep 01, 2014 7:33 am
Yes i want to know if its behaving as expected. Then try for some offsets...it should be noticable i think if you went to 50 or 25 or 10 or even 0 from there...
User avatar
Posts: 1833
Joined: Sun Apr 21, 2013 6:25 am
Location: Davie, FL
PostPosted: Mon Sep 01, 2014 7:41 am
Ok. I'll try it later. We're having a little Labor Day partyt today, so afterwards I'll try it.
PreviousNext

Return to Requests

Who is online

Users browsing this forum: No registered users and 1 guest

cron