All of a sudden no Reefcrest

[cjrudy]

I wasn't sure where to post this so I just stuck it here.

I have a WP40 and WP25 running and normally use Else mode however I wanted to switch it up and realized ReefCrest is not working, only one pump will run. All the other modes work fine.

Any ideas ?

[rimai]

at what %?

[cjrudy]

I tried at 100 and 90 i think

[rimai]

Was it not working as in not spinning at all?

[cjrudy]

Exactly, the WP40 propeller just stops spinning.

I just tied it again , same thing, all the other modes work fine.

Strange, I know it worked at some point.

[rimai]

What % does AD/DP show on screen?

[cjrudy]

I switched it back to else mode and I'm at work at the moment.
But I did know one was at 110%

Sent from my HTC6500LVW using Tapatalk 4

[cjrudy]

Well that was definitely it. The WP40 would shut off when the DP went over 100% with the Reefcrest setting on 100

Right now I have Reefcrest at 94 and so far the DP is staying below 100%

[cjrudy]

Anyone else experience this

Sent from my HTC6500LVW using Tapatalk 4

[ganjero]

I dont think you can run it above 100%.

[lnevo]

There should be a map or constrain function inside the ReefCrest to constain it within 100% but maybe it's missing...

[lnevo]

The constrain is there for the Sync pump... but it does not seem to be there for the AntiSync. Which of your pumps are defined as AntiSync? Is that the one that is stopping?

Roberto, you may need to review that as it might be the AntiSync channel is going above the 100% mark. Not sure what that would do here, but it seems this may be a possible reason...

[rimai]

Not so sure how that can happen on either one.
I'll have to load into the controller and check.

Code: Select all

byte ReefCrestMode(byte WaveSpeed, byte WaveOffset, boolean PulseSync)
{
	static unsigned long lastwavemillis=millis();
	static int newspeed=WaveSpeed;
	LightsOverride=false;
	if ((millis()-lastwavemillis) > 5000)
	{
		if (random(100)<50) newspeed--; else newspeed++;
		newspeed=constrain(newspeed,WaveSpeed-WaveOffset,WaveSpeed+WaveOffset);
		newspeed=constrain(newspeed,0,100);
		lastwavemillis=millis();
	}  
	if (PulseSync)
		return newspeed;
	else
		return WaveSpeed-(newspeed-WaveSpeed);
}

The constrain is there: newspeed=constrain(newspeed,0,100);

[cjrudy]

Right now the portal setting for Reefcrest is at 80, anything higher and the AD/DP goes over 100% which shuts off the wave maker.

Sent from my HTC6500LVW using Tapatalk 4

[lnevo]

I think the else has a double negative which may end up as a positive..maybe?

[rimai]

Ahh.. I see now
Good catch!!!