Lee's Feature Complete PDE

Share you PDE file with our community
MDB1029
Posts: 178
Joined: Wed Nov 12, 2014 3:10 pm
Location: An Oklahoman in Ohio

Re: Lee's Feature Complete PDE

Post by MDB1029 »

lnevo wrote:Ok give me a little time and try to parse through your code and then see what we can do.
No problem. I appreciate any help you can give me.
Image
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

Ok, definitely need to think about how I'm going to best do this... are you looking to acclimate all 3 spectrums? I think I have to abstract the code a bit so you can pass some parameters to how each channel is being acclimated. It may be an improvement on my code as well. Give me some more time.
MDB1029
Posts: 178
Joined: Wed Nov 12, 2014 3:10 pm
Location: An Oklahoman in Ohio

Re: Lee's Feature Complete PDE

Post by MDB1029 »

I usually run my red/green/uv lights with my actinic channel. So i would just need to make sure they aren't at 100% when the rest of the lights are at 50%. If it makes it easier to add the sunlocation code to get this to work it can be added, I have been planning on using that code, just haven't had a chance to get it coded in yet.
Image
89delta
Posts: 163
Joined: Mon Oct 15, 2012 7:21 pm
Location: Leesburg, GA

Re: Lee's Feature Complete PDE

Post by 89delta »

I ran my 6-channel LEDs on the pwm channels. I ran my reds and greens with the white channel and UV with my blues. Sunrise location is within my code.

Sent from my SAMSUNG-SM-N900A using Tapatalk
dansonamission
Posts: 10
Joined: Tue May 03, 2016 5:32 am

Re: Lee's Feature Complete PDE

Post by dansonamission »

Hi,
Im new to RA but not so new to Arduinos.

Running the Mac Arduino IDE from the RA website, 1.0.1, with Lee's code and I am receiving many errors when i try to verify the sketch. All the library folders have been copied into place.

I've also tried many other codes from the forums and receive many errors on them too. Maybe I'm missing something for setting the RA software initially?

Can some one point me in the right direction of RA's sample code? I don't see it anywhere to download and its not included in the mac download.

Many thanks

Code: Select all

Number of Relay Expansion Modules: 3
Number of Menu Options: 9
Reef_Angel_Lee.cpp: In function 'void setup()':
Reef_Angel_Lee:256: error: 'class ReefAngelClass' has no member named 'InitMenu'
Reef_Angel_Lee:281: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee.cpp: In function 'void CheckPower()':
Reef_Angel_Lee:341: error: 'class RelayClass' has no member named 'IsRelayPresent'
Reef_Angel_Lee:354: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:359: error: 'class RelayClass' has no member named 'IsRelayPresent'
Reef_Angel_Lee.cpp: In function 'void SetSun()':
Reef_Angel_Lee:434: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:439: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:440: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:442: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:443: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:448: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:449: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:451: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:452: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:457: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:458: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:460: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:461: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:466: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:467: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:469: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:470: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:475: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:476: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:478: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:479: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void SetMoon()':
Reef_Angel_Lee:517: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:518: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:523: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:524: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:528: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:529: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:533: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:534: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:538: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:539: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void FillInMoon()':
Reef_Angel_Lee:554: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:557: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:557: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:558: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:559: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:559: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:560: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:562: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:563: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void AcclimateLED()':
Reef_Angel_Lee:575: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:575: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:577: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:577: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:579: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:579: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:581: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:581: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void LEDPresets()':
Reef_Angel_Lee:604: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:605: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:606: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:607: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:608: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:609: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void UpdateLED()':
Reef_Angel_Lee:732: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:733: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:734: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:735: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:736: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:737: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:741: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:742: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:743: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:744: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void SetTide()':
Reef_Angel_Lee:759: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee.cpp: In function 'void SetRF()':
Reef_Angel_Lee:769: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:770: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:786: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:787: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:797: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee.cpp: In function 'void RFCustom()':
Reef_Angel_Lee:839: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee:843: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:848: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:853: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:858: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:863: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:868: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:924: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee:925: error: 'class ReefAngelClass' has no member named 'RF'
Reef_Angel_Lee.cpp: In function 'void CheckATO()':
Reef_Angel_Lee:936: error: 'class ReefAngelClass' has no member named 'WaterLevel'
Reef_Angel_Lee:942: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee.cpp: In function 'void RefillATO()':
Reef_Angel_Lee:965: error: 'class ReefAngelClass' has no member named 'WaterLevel'
Reef_Angel_Lee.cpp: In function 'void LogFeedings()':
Reef_Angel_Lee:1026: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee.cpp: In function 'void adjustAlk()':
Reef_Angel_Lee:1152: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee:1153: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee:1158: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee:1166: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee.cpp: In function 'void LogDosingPumps()':
Reef_Angel_Lee:1193: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee:1199: error: 'class ReefAngelClass' has no member named 'CustomVar'
Reef_Angel_Lee.cpp: In function 'void LockPorts()':
Reef_Angel_Lee:1301: error: 'class ReefAngelClass' has no member named 'OverridePortsE'
Reef_Angel_Lee:1302: error: 'class ReefAngelClass' has no member named 'OverridePortsE'
Reef_Angel_Lee:1304: error: 'class ReefAngelClass' has no member named 'OverridePortsE'
Reef_Angel_Lee:1305: error: 'class ReefAngelClass' has no member named 'OverridePortsE'
Reef_Angel_Lee.cpp: In function 'void DailyReport()':
Reef_Angel_Lee:1332: error: 'class ReefAngelClass' has no member named 'WaterLevel'
Reef_Angel_Lee.cpp: In function 'void MenuEntry8()':
Reef_Angel_Lee:1402: error: 'class ReefAngelClass' has no member named 'SetupCalibrateWaterLevel'
Reef_Angel_Lee.cpp: In function 'void DrawParams(int, int)':
Reef_Angel_Lee:1467: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1469: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee.cpp: In function 'void DrawStatus(int, int)':
Reef_Angel_Lee:1478: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1479: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1496: error: 'class ReefAngelClass' has no member named 'WaterLevel'
Reef_Angel_Lee:1497: error: 'class ReefAngelClass' has no member named 'WaterLevel'
Reef_Angel_Lee:1504: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1505: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1506: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1507: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1508: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1509: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1510: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1511: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1512: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee:1513: error: 'class RA_NokiaLCD' has no member named 'DrawLargeText'
Reef_Angel_Lee.cpp: In function 'void DrawSunMoon(int, int)':
Reef_Angel_Lee:1562: error: 'MoonPhaseLabel' was not declared in this scope
Reef_Angel_Lee:1567: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:1568: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee.cpp: In function 'void DrawRelays(int, int)':
Reef_Angel_Lee:1580: error: 'class RelayClass' has no member named 'RelayDataE'
Reef_Angel_Lee:1581: error: 'class RelayClass' has no member named 'RelayMaskOffE'
Reef_Angel_Lee:1582: error: 'class RelayClass' has no member named 'RelayMaskOnE'
Reef_Angel_Lee:1586: error: 'class RelayClass' has no member named 'RelayDataE'
Reef_Angel_Lee:1587: error: 'class RelayClass' has no member named 'RelayMaskOffE'
Reef_Angel_Lee:1588: error: 'class RelayClass' has no member named 'RelayMaskOnE'
Reef_Angel_Lee.cpp: In function 'void Strike()':
Reef_Angel_Lee:1899: error: 'class ReefAngelClass' has no member named 'PWM'
Reef_Angel_Lee:1906: error: 'class ReefAngelClass' has no member named 'PWM'
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

It looks like it's not finding the libraries. You copied them to ~/Documents/Arduino?

The example code should be visible in the menus if the folder is in the right spot.
dansonamission
Posts: 10
Joined: Tue May 03, 2016 5:32 am

Re: Lee's Feature Complete PDE

Post by dansonamission »

lnevo wrote:It looks like it's not finding the libraries. You copied them to ~/Documents/Arduino?

The example code should be visible in the menus if the folder is in the right spot.
They are in the correct library folder. I've looked through the library folders and none of them contain example files.

Going to try the windows software next.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

Something is either wrong in your arduino gui settings, i would check the preferences, as you said you arent new to arduino so maybe its referencing a different folder in your prefs. The arduino folder that comes on the mac image should contain the examples, wizard, and the feature directory not just the libraries. The errors you are getting are 100% telling me its not finding the libraries.
dansonamission
Posts: 10
Joined: Tue May 03, 2016 5:32 am

Re: Lee's Feature Complete PDE

Post by dansonamission »

lnevo wrote:Something is either wrong in your arduino gui settings, i would check the preferences, as you said you arent new to arduino so maybe its referencing a different folder in your prefs. The arduino folder that comes on the mac image should contain the examples, wizard, and the feature directory not just the libraries. The errors you are getting are 100% telling me its not finding the libraries.
Maybe I'm looking in the wrong place here, I downloaded the libraries from GitHub as there were no libraries included in the mac img download. Just a help doc, wifi utility and Arduino IDE. Which when run was using my library folder in my documents. I can see the libraries listed when going to sketch, include library....
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Lee's Feature Complete PDE

Post by lnevo »

Yeah thats the problem if you only downloaded the libraries. In the dmg file there should be an Arduino folder that you're supposed to drag to Documents. If you already had that folder then maybe it dropped into there. Either way check the dmg again and grab the contents of the Arduino folder and make sure they are in the documents/arduino folder.

You may also want to remove the prefernces file for the arduino ide just to make sure nothing was lingering.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

And for the record, I made this same mistake when I installed :)
dansonamission
Posts: 10
Joined: Tue May 03, 2016 5:32 am

Re: Lee's Feature Complete PDE

Post by dansonamission »

Ok I found them in the img. My fault, I hadn't actually clicked on the 'folder' which contains all the files needed. As the icon is what looks like a help doc for Arduino I hadn't clicked on it. Sorry for the confusion. Will try again later on.

On another note, I installed the 1.6.8 dev copy on windows and that's working ok so far.

Thanks for your help :)
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

Cool. Like I said, been there done that. Easy mistake :) glad that helped.
dansonamission
Posts: 10
Joined: Tue May 03, 2016 5:32 am

Re: Lee's Feature Complete PDE

Post by dansonamission »

If I try to compile your project with the standard RA its too big but no other errors, however when choosing the RA+ I see lots of Ethernet errors.

This is on the 1.6.8 so my guess is the library is out of date.

Code: Select all

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp: In member function 'void EthernetClass::begin(uint8_t*, IPAddress, IPAddress, IPAddress, IPAddress)':

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:64:39: error: no matching function for call to 'W5100Class::setIPAddress(IPAddress::<anonymous union>&)'

   W5100.setIPAddress(local_ip._address);

                                       ^

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:64:39: note: candidate is:

In file included from C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:1:0:

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\utility/w5100.h:392:6: note: void W5100Class::setIPAddress(uint8_t*)

 void W5100Class::setIPAddress(uint8_t *_addr) {

      ^

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\utility/w5100.h:392:6: note:   no known conversion for argument 1 from 'IPAddress::<anonymous union>' to 'uint8_t* {aka unsigned char*}'

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:65:38: error: no matching function for call to 'W5100Class::setGatewayIp(IPAddress::<anonymous union>&)'

   W5100.setGatewayIp(gateway._address);

                                      ^

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:65:38: note: candidate is:

In file included from C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:1:0:

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\utility/w5100.h:368:6: note: void W5100Class::setGatewayIp(uint8_t*)

 void W5100Class::setGatewayIp(uint8_t *_addr) {

      ^

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\utility/w5100.h:368:6: note:   no known conversion for argument 1 from 'IPAddress::<anonymous union>' to 'uint8_t* {aka unsigned char*}'

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:66:38: error: no matching function for call to 'W5100Class::setSubnetMask(IPAddress::<anonymous union>&)'

   W5100.setSubnetMask(subnet._address);

                                      ^

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:66:38: note: candidate is:

In file included from C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\Ethernet.cpp:1:0:

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\utility/w5100.h:376:6: note: void W5100Class::setSubnetMask(uint8_t*)

 void W5100Class::setSubnetMask(uint8_t *_addr) {

      ^

C:\Users\danstevens\Documents\Arduino\libraries\Ethernet\utility/w5100.h:376:6: note:   no known conversion for argument 1 from 'IPAddress::<anonymous union>' to 'uint8_t* {aka unsigned char*}'
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

The libraries dont work with the 1.6.8, Roberto posted a beta version with the dev library.
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Lee's Feature Complete PDE

Post by rimai »

You have to use the Arduino release in the dmg package.
It's compiled differently from the standard arduino ide so it allows to use the wizard and the other tools.
Roberto.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

Roberti what happened with the dev release of the new ide csn't find the post?
rimai
Posts: 12881
Joined: Fri Mar 18, 2011 6:47 pm

Re: Lee's Feature Complete PDE

Post by rimai »

Roberto.
dansonamission
Posts: 10
Joined: Tue May 03, 2016 5:32 am

Re: Lee's Feature Complete PDE

Post by dansonamission »

rimai wrote:You have to use the Arduino release in the dmg package.
It's compiled differently from the standard arduino ide so it allows to use the wizard and the other tools.
At the time i was using the 1.6.8 dev RA package on windows.
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

Was just checking out the coordinates my Sunrise/Sunset was linked to and then was just curious how accurate the calculations are. While not exact, they're pretty damn close. I'm satisfied

What my RA says
Sunrise: 10:10
Sunset: 23:33

What timeanddate says
Sunrise 6:02 AM
Sunset 7:27 PM
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

Just posted my latest code. Did a lot of improvement to the CheckATO function that measures the rate of evaporation by keeping a rolling 12 hour average of the % drop in my ATO reservoir. I did this so I can better set alerts if my ATO is either not dropping as expected or is dropping too fast.
User avatar
madweazl
Posts: 44
Joined: Tue Dec 03, 2013 3:08 am
Location: Fredericksburg, VA

Re: Lee's Feature Complete PDE

Post by madweazl »

I've been trying to adapt your code to my setup and am getting a "'class ReefAngelClass' has no member named 'LCD'" error in the validation process. Is this related to the NokiaLCD.h? I'm not sure how to continue from this point.

Edit: reinstalled arduino software and it seems to be fine now.
Image
User avatar
madweazl
Posts: 44
Joined: Tue Dec 03, 2013 3:08 am
Location: Fredericksburg, VA

Re: Lee's Feature Complete PDE

Post by madweazl »

OK, new stumbling block. I have two lights with two channels each (SBReef 16"). I have channel 11 running the actinics and 12 running the whites off of the relay dimming ports. I'm not sure how to make the changes to adapt your code that uses the dimming expansion to the relay box dimming outputs that I'm using (getting a 'class RA_PWMClass' has no member named 'Channel11PWMSlope' error). Can you point me in the right direction?

Code: Select all

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <Humidity.h>
#include <DCPump.h>
#include <PAR.h>
#include <ReefAngel.h>
#include <SunLocation.h>

        // Define Custom Memory Locations
        #define Mem_I_Latitude        108
        #define Mem_I_Longitude       110
        #define Mem_B_AcclRiseOffset  112
        #define Mem_B_AcclSetOffset   113
        #define Mem_B_AcclDay         114
        #define Mem_B_LightMode       160
        #define Mem_B_LightOffset     161
        #define Mem_I_RiseOffset      162
        #define Mem_I_SetOffset       164
        #define Mem_B_AcclActinicOffset     166
        #define Mem_B_AcclDaylightOffset    167
        #define Mem_B_LightsOffPerc   171
        #define Mem_B_EnableStorm     178
        #define Mem_B_PrintDebug      198
        #define Mem_B_ResetMemory     199

        void init_memory() {
          // Initialize Custom Memory Locations
          InternalMemory.write_int(Mem_I_Latitude,21);
          InternalMemory.write_int(Mem_I_Longitude,-73);
          InternalMemory.write(Mem_B_AcclRiseOffset,4);
          InternalMemory.write(Mem_B_AcclSetOffset,2);
          InternalMemory.write(Mem_B_AcclDay,0);
          InternalMemory.write(Mem_B_LightOffset,20);
          InternalMemory.write(Mem_B_LightMode,1);
          InternalMemory.write_int(Mem_I_RiseOffset,-1);
          InternalMemory.write_int(Mem_I_SetOffset,-1);
          InternalMemory.write(Mem_B_AcclActinicOffset,100);
          InternalMemory.write(Mem_B_AcclDaylightOffset,100);
          InternalMemory.write(Mem_B_LightsOffPerc,1);
          InternalMemory.write(Mem_B_EnableStorm,true);

          InternalMemory.write(Mem_B_ResetMemory,false);
        }

    // Define Relay Ports by Name
    #define Skimmer            1
    #define Heater             2
    #define Reactor            3
    #define Refugium           4
    #define Daylight           5
    #define Actinic            6
    #define Return             7
    #define ATO                8

    #define Wave 1             Box1_Port1
    #define Wave 2             Box1_Port2
    #define Unused             Box1_Port3
    #define Unused             Box1_Port4
    #define Unused             Box1_Port5
    #define Unused             Box1_Port6
    #define Unused             Box1_Port7
    #define Utility            Box1_Port8

////// Place global variable code below here

    // Custom classes
    SunLocation sun;
	
	// For Cloud and preset code
int DaylightPWMValue=0;
int ActinicPWMValue=0;
int DaylightPWMValue0=0;        // For cloud code, channel 0
int DaylightPWMValue2=0;        // For cloud code, chennel 2
int ActinicPWMValue1=0;        // For cloud code, channel 0
int ActinicPWMValue3=0;        // For cloud code, chennel 2

////// Place global variable code above here


void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
ReefAngel.AddStandardMenu(); // Add Standard Menu

ReefAngel.Use2014Screen(); // Let's use 2014 Screen 
// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port1Bit | Port3Bit;
ReefAngel.FeedingModePortsE[0] = Port3Bit | Port5Bit | Port6Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port1Bit | Port2Bit | Port3Bit | Port7Bit | Port8Bit;
ReefAngel.WaterChangePortsE[0] = Port3Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = Port4Bit;
ReefAngel.LightsOnPortsE[0] = Port3Bit;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit | Port3Bit | Port4Bit | Port5Bit | Port6Bit;
ReefAngel.OverheatShutoffPortsE[0] = Port3Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;
// Set the Overheat temperature setting
InternalMemory.OverheatTemp_write( 820 );


// Ports that are always on
ReefAngel.Relay.On( Port1 );
ReefAngel.Relay.On( Port3 );
ReefAngel.Relay.On( Port7 );
ReefAngel.Relay.On( Box1_Port1 );
ReefAngel.Relay.On( Box1_Port2 );

////// Place additional initialization code below here


////// Place additional initialization code above here
}

void loop()
{
ReefAngel.StandardHeater( Port2,796,798 );
ReefAngel.StandardLights( Port4,18,0,12,0 ); // Refugium light
ReefAngel.StandardATO( Port8,1200 );
ReefAngel.Wavemaker( Box1_Port1,60 );
ReefAngel.Relay.Set( Box1_Port2, !ReefAngel.Relay.Status( Box1_Port1 ) );

////// Place your custom code below here

     // Lighting and Flow
          SetSun();               // Setup Sun rise/set lighting
          AcclimateLED();         // Apply acclimation dimming
          LEDPresets();
          CheckCloud();           //  Check for cloud and lightning.
          UpdateLED();

////// Place your custom code above here

// This should always be the last line
ReefAngel.Portal("madweazl");
ReefAngel.ShowInterface();
}

        void SetSun() {
          // Start acclimation routine
          int acclRiseOffset=InternalMemory.read(Mem_B_AcclRiseOffset)*60;
          int acclSetOffset=InternalMemory.read(Mem_B_AcclSetOffset)*60;
          byte acclDay=InternalMemory.read(Mem_B_AcclDay);
         
          // See if we are acclimating corals and decrease the countdown each day
          static boolean acclCounterReady=false;
          if (now()%SECS_PER_DAY!=0) acclCounterReady=true;
          if (now()%SECS_PER_DAY==0 && acclCounterReady && acclDay>0) {
            acclDay--;
            acclCounterReady=false;
            InternalMemory.write(Mem_B_AcclDay,acclDay);
          }
          // End acclimation

          // Add some customizable offsets
          sun.Init(InternalMemory.read_int(Mem_I_Latitude), InternalMemory.read_int(Mem_I_Longitude));
          int riseOffset=InternalMemory.read_int(Mem_I_RiseOffset);
          int setOffset=InternalMemory.read_int(Mem_I_SetOffset);
         
          sun.SetOffset(riseOffset,(acclDay*acclRiseOffset),setOffset,(-acclDay*acclSetOffset)); // Bahamas
          sun.CheckAndUpdate(); // Calculate today's Sunrise / Sunset

          byte lightOffset=InternalMemory.read(Mem_B_LightOffset); // left right separation
          byte actinicOffset=InternalMemory.ActinicOffset_read();
         
          // Make sure light resets to zero at night.
          for(int i=0;i<4;i++) { ReefAngel.PWM.SetChannel(i,0); }
         
          switch(InternalMemory.read(Mem_B_LightMode)) {   
            case 0: {
              // Daylights
              ReefAngel.PWM.Channel11PWMSlope(lightOffset,0);
     
              // Actinics
              ReefAngel.PWM.Channel12PWMSlope(actinicOffset+lightOffset,actinicOffset);

              break;
            }
            case 1: {
              // Daylights
              ReefAngel.PWM.Channel11PWMParabola(lightOffset,0);

              // Actinics
              ReefAngel.PWM.Channel12PWMParabola(actinicOffset+lightOffset,actinicOffset);

              break;
            }
          case 2: {
              // Daylights
              ReefAngel.PWM.Channel11PWMSmoothRamp(lightOffset,0);

              // Actinics
              ReefAngel.PWM.Channel12PWMSmoothRamp(actinicOffset+lightOffset,actinicOffset);

              break;
            }
          case 3: {
              // Daylights
              ReefAngel.PWM.Channel11PWMSigmoid(lightOffset,0);

              // Actinics
              ReefAngel.PWM.Channel12PWMSigmoid(actinicOffset+lightOffset,actinicOffset);

              break;
            }
          case 4: { // Reverse the actinics in the morning
              // Daylights
              ReefAngel.PWM.Channel11PWMParabola(lightOffset+actinicOffset,0);

              // Actinics
              ReefAngel.PWM.Channel12PWMParabola(lightOffset,actinicOffset);
              break;
            }
          }
        }


        void AcclimateLED() {
          byte acclDay=InternalMemory.read(Mem_B_AcclDay);
         
          if (acclDay > 0) {
            float acclActinicOffset=acclDay*(40.95*(((float)InternalMemory.read(Mem_B_AcclActinicOffset)/100)));
            float acclDaylightOffset=acclDay*(40.95*((float)InternalMemory.read(Mem_B_AcclDaylightOffset)/100));
            float endPerc;
         
            endPerc=40.95*InternalMemory.PWMSlopeEnd1_read();
            ReefAngel.PWM.SetChannelRaw(1,map(ReefAngel.PWM.GetChannelValueRaw(1),0,endPerc,0,endPerc-acclActinicOffset));
            endPerc=40.95*InternalMemory.PWMSlopeEnd3_read();
            ReefAngel.PWM.SetChannelRaw(3,map(ReefAngel.PWM.GetChannelValueRaw(3),0,endPerc,0,endPerc-acclActinicOffset));
            endPerc=40.95*InternalMemory.PWMSlopeEnd0_read();
            ReefAngel.PWM.SetChannelRaw(0,map(ReefAngel.PWM.GetChannelValueRaw(0),0,endPerc,0,endPerc-acclDaylightOffset));
            endPerc=40.95*InternalMemory.PWMSlopeEnd2_read();
            ReefAngel.PWM.SetChannelRaw(2,map(ReefAngel.PWM.GetChannelValueRaw(2),0,endPerc,0,endPerc-acclDaylightOffset));
          }
        }

        #define LED_1to1  Box1_Port1
        #define LED_4to1  Box1_Port2
        #define LED_3to1  Box1_Port3
        #define LED_2to1  Box1_Port4
        #define LED_BLUE  Box1_Port5
        #define LED_WHITE Box1_Port6
        #define LED_STORM Box1_Port8

        void resetRelayBox(byte ID) {
          // toggle all relays except for the one selected
          for (int i=Box1_Port1;i<=Box1_Port4;i++) {
            if (i!=ID) ReefAngel.Relay.Auto(i);
          }
        }

        void LEDPresets() {
          static byte lastPreset=0;
         
          DaylightPWMValue0=ReefAngel.PWM.GetChannelValueRaw(0);
          ActinicPWMValue1=ReefAngel.PWM.GetChannelValueRaw(1);
          DaylightPWMValue2=ReefAngel.PWM.GetChannelValueRaw(2);
          ActinicPWMValue3=ReefAngel.PWM.GetChannelValueRaw(3);
          DaylightPWMValue=ReefAngel.PWM.GetDaylightValueRaw();
          ActinicPWMValue=ReefAngel.PWM.GetActinicValueRaw();

          if (ReefAngel.Relay.isMaskOn(LED_1to1)) {
            if (lastPreset!=1) resetRelayBox(LED_1to1);
            DaylightPWMValue0=90*40.95;
            ActinicPWMValue1=10*40.95;
            DaylightPWMValue2=90*40.95;
            ActinicPWMValue3=10*40.95;
            lastPreset=1;
          }
         
          if (ReefAngel.Relay.isMaskOff(LED_1to1)) {
            if (lastPreset!=2) resetRelayBox(LED_1to1);
            DaylightPWMValue0=10*40.95;
            ActinicPWMValue1=90*40.95;
            DaylightPWMValue2=10*40.95;
            ActinicPWMValue3=90*40.95;
            lastPreset=2;
          }
         
          if (ReefAngel.Relay.isMaskOn(LED_2to1)) {
            if (lastPreset!=3) resetRelayBox(LED_2to1);
            DaylightPWMValue0=60*40.95;
            ActinicPWMValue1=40*40.95;
            DaylightPWMValue2=60*40.95;
            ActinicPWMValue3=40*40.95;
            lastPreset=3;
          }

          if (ReefAngel.Relay.isMaskOff(LED_2to1)) {
            if (lastPreset!=4) resetRelayBox(LED_2to1);
            DaylightPWMValue0=40*40.95;
            ActinicPWMValue1=60*40.95;
            DaylightPWMValue2=40*40.95;
            ActinicPWMValue3=60*40.95;
            lastPreset=4;
          }

          if (ReefAngel.Relay.isMaskOn(LED_3to1)) {
            if (lastPreset!=5) resetRelayBox(LED_3to1);
            DaylightPWMValue0=75*40.95;
            ActinicPWMValue1=25*40.95;
            DaylightPWMValue2=75*40.95;
            ActinicPWMValue3=25*40.95;
            lastPreset=5;
          }

          if (ReefAngel.Relay.isMaskOff(LED_3to1)) {
            if (lastPreset!=6) resetRelayBox(LED_3to1);
            DaylightPWMValue0=25*40.95;
            ActinicPWMValue1=75*40.95;
            DaylightPWMValue2=25*40.95;
            ActinicPWMValue3=75*40.95;
            lastPreset=6;
          }

          if (ReefAngel.Relay.isMaskOn(LED_4to1)) {
            if (lastPreset!=7) resetRelayBox(LED_4to1);
            DaylightPWMValue0=80*40.95;
            ActinicPWMValue1=20*40.95;
            DaylightPWMValue2=80*40.95;
            ActinicPWMValue3=20*40.95;
            lastPreset=7;
          }

          if (ReefAngel.Relay.isMaskOff(LED_4to1)) {
            if (lastPreset!=8) resetRelayBox(LED_4to1);
            DaylightPWMValue0=20*40.95;
            ActinicPWMValue1=80*40.95;
            DaylightPWMValue2=20*40.95;
            ActinicPWMValue3=80*40.95;
            lastPreset=8;
          }

          if (ReefAngel.Relay.isMaskOn(LED_BLUE)) {
            if (lastPreset!=9) resetRelayBox(LED_BLUE);
            DaylightPWMValue0=0;
            ActinicPWMValue1=80*40.95;
            DaylightPWMValue2=0;
            ActinicPWMValue3=80*40.95;
            lastPreset=9;
          }

          if (ReefAngel.Relay.isMaskOff(LED_BLUE)) {
            if (lastPreset!=10) resetRelayBox(LED_BLUE);
            ActinicPWMValue1=0;
            ActinicPWMValue3=0;
            lastPreset=10;
          }   
         
          if (ReefAngel.Relay.isMaskOn(LED_WHITE)) {
            if (lastPreset!=11) resetRelayBox(LED_WHITE);
            DaylightPWMValue0=80*40.95;
            ActinicPWMValue1=0;
            DaylightPWMValue2=80*40.95;
            ActinicPWMValue3=0;
            lastPreset=11;
          }

          if (ReefAngel.Relay.isMaskOff(LED_WHITE)) {
            if (lastPreset!=12) resetRelayBox(LED_WHITE);
            DaylightPWMValue0=0;
            DaylightPWMValue2=0;
            lastPreset=12;
          } 
          }

        // Write updated values to the channels
        void UpdateLED() {
          ReefAngel.PWM.SetChannelRaw(0,DaylightPWMValue0);
          ReefAngel.PWM.SetChannelRaw(1,ActinicPWMValue1);
          ReefAngel.PWM.SetChannelRaw(2,DaylightPWMValue2);
          ReefAngel.PWM.SetChannelRaw(3,ActinicPWMValue3);
          ReefAngel.PWM.SetDaylightRaw(DaylightPWMValue);   
          ReefAngel.PWM.SetActinicRaw(ActinicPWMValue);

          byte LightsOffPerc=40.95*InternalMemory.read(Mem_B_LightsOffPerc);
         
          if (ReefAngel.PWM.GetChannelValueRaw(0)>=LightsOffPerc) ReefAngel.Relay.On(Daylight); else ReefAngel.Relay.Off(Daylight);
          if (ReefAngel.PWM.GetChannelValueRaw(1)>=LightsOffPerc) ReefAngel.Relay.On(Actinic); else ReefAngel.Relay.Off(Actinic);
          if (ReefAngel.PWM.GetChannelValueRaw(2)>=LightsOffPerc) ReefAngel.Relay.On(Daylight); else ReefAngel.Relay.Off(Daylight);
          if (ReefAngel.PWM.GetChannelValueRaw(3)>=LightsOffPerc) ReefAngel.Relay.On(Actinic); else ReefAngel.Relay.Off(Actinic);
        }


        // Menu Code
        void MenuEntry1() {
          ReefAngel.FeedingModeStart();
        }
        void MenuEntry2() {
          ReefAngel.WaterChangeModeStart();
        }
        void MenuEntry3() {
          ReefAngel.ATOClear();
          ReefAngel.DisplayMenuEntry("Clear ATO Timeout");
        }
        void MenuEntry4() {
          ReefAngel.OverheatClear();
          ReefAngel.DisplayMenuEntry("Clear Overheat");
        }
        void MenuEntry5() {
          ReefAngel.SetupCalibratePH();
        }
        void MenuEntry6() {
          ReefAngel.SetupDateTime();
        }

         void CheckCloud()
            {
              // ------------------------------------------------------------
              // Change the values below to customize your cloud/storm effect

              // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)
              // For testing purposes, you can use 1 and cause the cloud to occur everyday
            #define Clouds_Every_X_Days 1

              // Percentage chance of a cloud happening today
              // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
            #define Cloud_Chance_per_Day 100

              // Minimum number of minutes for cloud duration.  Don't use max duration of less than 6
            #define Min_Cloud_Duration 7

              // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
            #define Max_Cloud_Duration 7

              // Minimum number of clouds that can happen per day
            #define Min_Clouds_per_Day 1

              // Maximum number of clouds that can happen per day
            #define Max_Clouds_per_Day 2

              // Only start the cloud effect after this setting
              // In this example, start cloud after noon
            #define Start_Cloud_After NumMins(12,00)

              // Always end the cloud effect before this setting
              // In this example, end cloud before 9:00pm
            #define End_Cloud_Before NumMins(21,00)

              // Percentage chance of a lightning happen for every cloud
              // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening
            #define Lightning_Change_per_Cloud 100

              // Note: Make sure to choose correct values that will work within your PWMSLope settings.
              // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
              // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes
              // of effects or unforseen result could happen.
              // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
              // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the
              // 250 minutes (or 500 minutes) can fit in that 510 minutes window.
              // It's a tight fit, but it did.

              //#define printdebug // Uncomment this for debug print on Serial Monitor window
            #define forcecloudcalculation // Uncomment this to force the cloud calculation to happen in the boot process.

              // Add Random Lightning modes
            #define Calm 0    // No lightning
            #define Slow 1    // 5 seconds of slow lightning in the middle of a cloud for ELN style (slow response) drivers
            #define Fast 2    // 5 seconds of fast lightning in the middle of a cloud for LDD style (fast response) drivers
            #define Mega 3    // Lightning throughout the cloud, higher chance as it gets darker
            #define Mega2 4   // Like Mega, but with more lightning
              // Set which modes you want to use
              // Example:  { Calm, Fast, Mega, Mega2 } to randomize all four modes.
              // { Mega2 } for just Mega2.  { Mega, Mega, Fast} for Mega and Fast, with twice the chance of Mega.
              byte LightningModes[] = {Mega2,Mega,Mega};

              // Change the values above to customize your cloud/storm effect
              // ------------------------------------------------------------
              // Do not change anything below here

              static byte cloudchance=255;
              static byte cloudduration=0;
              static int cloudstart=0;
              static byte numclouds=0;
              static byte lightningchance=0;
              static byte cloudindex=0;
              static byte lightningstatus=0;
              static int LastNumMins=0;
              static byte lightningMode=0;
              static boolean chooseLightning=true;

              static time_t DelayCounter=millis();    // Variable for lightning timing.
              static int DelayTime=random(1000);      // Variable for lightning timimg.

              // Every day at midnight, we check for chance of cloud happening today
              if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

            #ifdef forcecloudcalculation
              if (cloudchance==255)
            #else
                if (hour()==0 && minute()==0 && second()==1 && cloudchance==255)
            #endif
                {
                  randomSeed(millis());    // Seed the random number generator
                  //Pick a random number between 0 and 99
                  cloudchance=random(100);
                  // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today
                  if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;
                  // Check if today is day for clouds.
                  if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;
                  // If we have cloud today
                  if (cloudchance)
                  {
                    // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day
                    numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
                    // pick the time that the first cloud will start
                    // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
                    cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
                    // pick a random number for the cloud duration of first cloud.
                    cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
                    //Pick a random number between 0 and 99
                    lightningchance=random(100);
                    // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
                    if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
                  }
                }
              // Now that we have all the parameters for the cloud, let's create the effect


              if (cloudchance)
              {
                //is it time for cloud yet?
                if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
                {
                  DaylightPWMValue=ReversePWMSlope(cloudstart,cloudstart+cloudduration,DaylightPWMValue/40.95,0,180)*40.95;
                  if (chooseLightning)
                  {
                    lightningMode=LightningModes[random(100)%sizeof(LightningModes)];
                    chooseLightning=false;
                  }
                  switch (lightningMode)
                  {
                  case Calm:
                    break;
                  case Mega:
                    // Lightning chance from beginning of cloud through the end.  Chance increases with darkness of cloud.
                    if (lightningchance && random(ReversePWMSlope(cloudstart,cloudstart+cloudduration,100,0,180))<1 && (millis()-DelayCounter)>DelayTime)
                    {
                      // Send the trigger
                      Strike();
                      DelayCounter=millis();    // If we just had a round of flashes, then lets put in a longer delay
                      DelayTime=random(1000);   // of up to a second for dramatic effect before we do another round.
                    }
                    break;
                  case Mega2:
                    // Higher lightning chance from beginning of cloud through the end.  Chance increases with darkness of cloud.
                    if (lightningchance && random(ReversePWMSlope(cloudstart,cloudstart+cloudduration,100,0,180))<2)
                    {
                      Strike();
                    }
                    break;
                  case Fast:
                    // 5 seconds of lightning in the middle of the cloud
                    if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5 && (millis()-DelayCounter)>DelayTime)
                    {
                      Strike();

                      DelayCounter=millis();    // If we just had a round of flashes, then lets put in a longer delay
                      DelayTime=random(1000);   // of up to a second for dramatic effect before we do another round.
                    }
                    break;
                  case Slow:
                    // Slow lightning for 5 seconds in the middle of the cloud.  Suitable for slower ELN style drivers
                    if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)
                    {
                      if (random(100)<20) lightningstatus=1;
                      else lightningstatus=0;
                      if (lightningstatus)
                      {
                        DaylightPWMValue=4095;
                      }
                      else
                      {
                        DaylightPWMValue=0;
                      }
                      delay(1);
                    }
                    break;
                  default:
                    break;
                  }
                }
                else
                {
                  chooseLightning=true; // Reset the flag to choose a new lightning type
                }

                if (NumMins(hour(),minute())>(cloudstart+cloudduration))
                {
                  cloudindex++;
                  if (cloudindex < numclouds)
                  {
                    cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
                    // pick a random number for the cloud duration of first cloud.
                    cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
                    //Pick a random number between 0 and 99
                    lightningchance=random(100);
                    // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
                    if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
                  }
                }
              }

              // Write the times of the next cloud, next lightning, and cloud duration to the screen and into some customvars for the Portal.
              if (LastNumMins!=NumMins(hour(),minute()))
              {
                LastNumMins=NumMins(hour(),minute());
                /*ReefAngel.LCD.Clear(255,0,120,132,132);
                 ReefAngel.LCD.DrawText(0,255,5,120,"C");
                 ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
                 ReefAngel.LCD.DrawText(0,255,45,120,"L");
                 ReefAngel.LCD.DrawText(0,255,51,120,"00:00"); */
                if (cloudchance && (NumMins(hour(),minute())<cloudstart))
                {
                  int x=0;
                  if ((cloudstart/60)>=10) x=11;
                  else x=17;
                  //ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
                  ReefAngel.CustomVar[3]=cloudstart/60; // Write the hour of the next cloud to custom variable for Portal reporting
                  if ((cloudstart%60)>=10) x=29;
                  else x=35;
                  //ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
                  ReefAngel.CustomVar[4]=cloudstart%60; // Write the minute of the next cloud to custom variable for Portal reporting

                }
                //ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
                ReefAngel.CustomVar[7]=(cloudduration);    // Put the duration of the next cloud in a custom var for the portal
                if (lightningchance)
                {
                  int x=0;
                  if (((cloudstart+(cloudduration/2))/60)>=10) x=51;
                  else x=57;
                  //ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
                  ReefAngel.CustomVar[5]=(cloudstart+(cloudduration/2))/60;    // Write the hour of the next lightning to a custom variable for the Portal
                  if (((cloudstart+(cloudduration/2))%60)>=10) x=69;
                  else x=75;
                  //ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60)); // Write the minute of the next lightning to a custom variable for the Portal
                    ReefAngel.CustomVar[6]=(cloudstart+(cloudduration/2))%60;
                }
              }   
            }

            void Strike()
            {
              int a=random(1,5);    // Pick a number of consecutive flashes from 1 to 4.
              for (int i=0; i<a; i++)
              {
                // Flash on
                int newdata=4095;
                Wire.beginTransmission(0x40);      // Address of the dimming expansion module
                Wire.write(0x8+(4*0));             // 0x8 is channel 0, 0x12 is channel 1, etc.  I'm using channel 1.
                Wire.write(newdata&0xff);          // Send the data 8 bits at a time.  This sends the LSB
                Wire.write(newdata>>8);            // This sends the MSB
                Wire.endTransmission();
               
                Wire.beginTransmission(0x40);      // Address of the dimming expansion module
                Wire.write(0x8+(4*2));             // 0x8 is channel 0, 0x12 is channel 1, etc.  I'm using channel 1.
                Wire.write(newdata&0xff);          // Send the data 8 bits at a time.  This sends the LSB
                Wire.write(newdata>>8);            // This sends the MSB
                Wire.endTransmission();
               
                int randy=random(20,80);    // Random number for a delay
                if (randy>71) randy=((randy-70)/2)*100;    // Small chance of a longer delay
                delay(randy);                // Wait from 20 to 69 ms, or 100-400 ms
               
                // Flash off.  Return to baseline.
                newdata=ReefAngel.PWM.GetChannelValueRaw(0);   // Use the channel number you're flashing here
                Wire.beginTransmission(0x40);    // Same as above
                Wire.write(0x8+(4*0));
                Wire.write(newdata&0xff);
                Wire.write(newdata>>8);
                Wire.endTransmission();
               
                newdata=ReefAngel.PWM.GetChannelValueRaw(0);   // Use the channel number you're flashing here
                Wire.beginTransmission(0x40);    // Same as above
                Wire.write(0x8+(4*2));
                Wire.write(newdata&0xff);
                Wire.write(newdata>>8);
                Wire.endTransmission();
               
                delay(random(30,50));                // Wait from 30 to 49 ms
                wdt_reset();    // Reset watchdog timer to avoid re-boots
              }
            }

            byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
            {
              long n=elapsedSecsToday(now());
              cstart*=60;
              cend*=60;
              if (n<cstart) return PWMStart;
              if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
              if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
              if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
              if (n>cend) return (int) PWMStart;
            }
Image
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

If you have Channel 11 and 12 then I'm guessing you have a custom 16 channel module?

If so then the correct function to use instead of:

ReefAngel.PWM.Channel11PWMSlope(lightOffset,0);

Use:

ReefAngel.PWM.SIXTEENChannelPWMSlope(11, 0, 100, 60, lightOffset, 0); // Channel / Start % / End % / Duration / PreOffset / PostOffset



There's no function to call this from direct memory
User avatar
madweazl
Posts: 44
Joined: Tue Dec 03, 2013 3:08 am
Location: Fredericksburg, VA

Re: Lee's Feature Complete PDE

Post by madweazl »

lnevo wrote:If you have Channel 11 and 12 then I'm guessing you have a custom 16 channel module?

If so then the correct function to use instead of:

ReefAngel.PWM.Channel11PWMSlope(lightOffset,0);

Use:

ReefAngel.PWM.SIXTEENChannelPWMSlope(11, 0, 100, 60, lightOffset, 0); // Channel / Start % / End % / Duration / PreOffset / PostOffset



There's no function to call this from direct memory
No 16ch module, just the original relay box (channel 11 and 12 in the manual). I believe you call them with "actinic" and "daylight" based on the standard code but I wasnt positive on how to tackle that.

Would ReefAngel.PWM.SetActinic( PWMSlope(10, 10, 60, lightOffset, 0) ); work? My lights only dim to 10%.
Image
tngo
Posts: 131
Joined: Wed Apr 27, 2011 9:08 am

Re: Lee's Feature Complete PDE

Post by tngo »

I had a question regarding the setRF() class in Lee's complete PDE. IIRC, this class is suppose to go into NTM mode after a feeding mode, and then back to the mode that it was in prior to being put into feeding mode? I wasn't able to tell where the code puts it back the original mode prior to feeding was enabled.

Thanks,
Tim
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

vtMode is being set at the top of the function by reading the InternalMemory variables for these settings. Then once the delay is set, then it get's picked up by the if and gets set to SmartNTM which finally get's written with RF.SetMode at the end of the function.
tngo
Posts: 131
Joined: Wed Apr 27, 2011 9:08 am

Re: Lee's Feature Complete PDE

Post by tngo »

Okay cool. Thanks lnevo for clearing that up for me. I thought that once it set the vtMode to NTM in the if statement I didn't see anywhere in the function that would reset it back to a previous setting.

Tim
User avatar
lnevo
Posts: 5430
Joined: Fri Jul 20, 2012 9:42 am

Re: Lee's Feature Complete PDE

Post by lnevo »

So after a very long hiatus, I've gotten back to my tank....

I had shorted a few outlets which I managed by shuffling a few outlets and taking my dosers offline. They weren't doing anything anyway so no big loss. I have now come to discover that this was also screwing with my ph reading so I finally swapped the box out.

I also took care of an issue with my Auto-Water-Change pump which was taking out more water than it was putting in. I was trying to compensate with extra salinity, but it looks like it was like a 60% delta. Since the AWC pump has 3 peristaltic heads and I was only using 2, I moved the new water line to a different head and now it's spot on exact.

I installed a Klir Di-4 filter in my sump and so far it's fantastic. The only issue I had was that the water level when the system was down or in feeding mode would cause the water level to trigger the optical sensor and the roll to continue forever. Problem solved by putting the power on the same outlet as my skimmer.

I detected a leak in my RO filter. Looks like the teflon wore off in the fitting. In order to not have to disassemble the entire thing, I will cut it in half and replace it with a straight fitting. Waiting for the part.

My MP40QWD wet side magnet exploded, so I ordered new ones and managed to get an RMA on it anyway :) That should be in shortly.

I thought I had a leak on my tank, the carpet all around my fish cabinet and tank is soaked... turned out to be my AC dripping... I now have a new AC unit. Now that the relay box was replaced, I connected back my fan array for cooling the tank. Temp was up to 84 degrees on my tank.

Lastly, I changed the bulkheads on my clearwater algae scrubber to use uniseals giving more room inside the scrubber for the mesh to hang and also to address a small leak I had there. It was impossible to tighten the bulkhead with the limited space. Much better now :)

My water has never been clearer. Having an automated 5 micon filter sock is fantastic :) I highly recommend the Klir filter.
binder
Posts: 2871
Joined: Fri Mar 18, 2011 6:20 pm
Location: Illinois
Contact:

Re: Lee's Feature Complete PDE

Post by binder »

nice.
sounds like you have had some experiences to say the least least.
glad to hear that you are back to your tank.

Sent from my XT1585 using Tapatalk
Post Reply