Web Wizard and WaterLevelATO bug?

Related to the development libraries, released by Curt Binder

Posts: 7
Joined: Wed Dec 20, 2017 3:53 am
PostPosted: Fri Jun 15, 2018 10:29 pm

With a Water Level extension (but not multilevel water level) the Web Wizard generates the following statement for a timeout of 10 minutes on port 5:
Code: Select all
ReefAngel.WaterLevelATO( Box1_Port5,10,15,600 );

Am I misunderstanding or shouldn't it generate something more like:
Code: Select all
ReefAngel.WaterLevelATO( Box1_Port5,600,98,100 );

which makes my ATO work correctly.

Checking the ReefAngel class the WaterLevelATO method is declared to have the following parameter order:
Code: Select all
void ReefAngelClass::WaterLevelATO(byte ATORelay, int ATOTimeout, byte LowLevel, byte HighLevel)

which suggests the last three parameters are generated by the Web Wizard in an incorrect order (and I don't know why it chooses to use 10 and 15 for the levels rather than numbers closer to 100).


Posts: 12615
Joined: Fri Mar 18, 2011 6:47 pm
PostPosted: Tue Jun 26, 2018 10:08 pm
You are correct.
Thanks for finding the bug.
I have corrected the problem of the wizard and it is now generating in the correct order.
The 10% and 15% are default values. Are you sure you have changed them to 98% and 100%?

Return to Development Libraries

Who is online

Users browsing this forum: Google [Bot] and 8 guests