Page 1 of 4
Re: My code - water level ATO help needed
Posted: Sun Mar 24, 2013 9:06 am
by rimai
Does the red light turns on immediately or it turns on after 60 seconds?
Re: My code - water level ATO help needed
Posted: Sun Mar 24, 2013 9:51 am
by bencollinz
rimai wrote:Does the red light turns on immediately or it turns on after 60 seconds?
ok, so I unplugged RA and plugged back in. no red light. ATO is on auto per portal. water level is at 55 currently, so it should be running but it's not.
I turn it to on manually, it doesn't shut off when it hits 60 seconds or 58% water level. If I set it back to auto it stays off.
the portal still says water is 55% but RA says 59%
unfortunately, I couldn't reproduce the red light issue now.
Re: My code - water level ATO help needed
Posted: Sun Mar 24, 2013 10:58 am
by rimai
It won't turn on until it reaches 52%. That's what you set it at.
It turns on at 52% and off at 58%.
So, when the level does get to 52, you have 60 seconds to pump water until it hits 58% or the timeout will happen and disable the ATO. This is a safety feature to prevent overflow. That's when the red light goes on, indicating an ATO timeout.
So, I think you are using too high of a range and too low of a timeout. Can you pump that much water in 60 seconds?
It will never shut off if you turn on manually. That's what we call override. You are forcing an on position situation no matter what the controller thinks it should be.
Re: My code - water level ATO help needed
Posted: Sun Mar 24, 2013 3:27 pm
by bencollinz
rimai wrote:It won't turn on until it reaches 52%. That's what you set it at.
It turns on at 52% and off at 58%.
So, when the level does get to 52, you have 60 seconds to pump water until it hits 58% or the timeout will happen and disable the ATO. This is a safety feature to prevent overflow. That's when the red light goes on, indicating an ATO timeout.
So, I think you are using too high of a range and too low of a timeout. Can you pump that much water in 60 seconds?
It will never shut off if you turn on manually. That's what we call override. You are forcing an on position situation no matter what the controller thinks it should be.
I found this is someone else's thread
http://forum.reefangel.com/viewtopic.ph ... ion#p14563
Code: Select all
// If water level less than 58, turn on auto top off relay; else, keep it off
if (ReefAngel.WaterLevel.GetLevel()<58) ReefAngel.Relay.On(Port7);
else ReefAngel.Relay.Off(Port7);
can I use that instead?
or does it still need a timeout, just in case?
Re: My code - water level ATO help needed
Posted: Sun Mar 24, 2013 3:42 pm
by rimai
Yeah, you can use that.
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 1:28 pm
by bencollinz
Code: Select all
#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <ReefAngel.h>
/*
#define Heater 1
#define Return 2
#define Skimmer 3
#define Vortech1 5
#define Vortech2 6
#define ATO 7
*/
////// Place global variable code below here
byte vtechmode;
////// Place global variable code above here
void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port7Bit | Port4Bit | Port5Bit | Port6Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = 0;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit | Port7Bit | Port4Bit | Port5Bit | Port6Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;
// Ports that are always on
ReefAngel.Relay.On( Port2 );
////// Place additional initialization code below here
// Hardcode PH calibrations
ReefAngel.PHMin=576; // PH7.0
ReefAngel.PHMax=842; // PH10.0
ReefAngel.SalMax=3000; // 35ppt
////// Place additional initialization code above here
}
void loop()
{
ReefAngel.StandardHeater( Port1,796,802 );
// ReefAngel.WaterLevelATO( Port7,60,52,58 ); // 60 seconds timeout, turn on at 52% and turn off at 58%
// If water level less than 58, turn on auto top off relay; else, keep it off
if (ReefAngel.WaterLevel.GetLevel()<58) ReefAngel.Relay.On(Port7);
else ReefAngel.Relay.Off(Port7);
ReefAngel.PWM.Channel1PWMParabola();
ReefAngel.PWM.Channel2PWMParabola();
ReefAngel.PWM.Channel3PWMParabola();
ReefAngel.PWM.Channel4PWMSlope();
ReefAngel.RF.UseMemory = true;
if ( ReefAngel.LowATO.IsActive())
{
ReefAngel.Relay.On(Port2);
}
else
{
ReefAngel.Relay.Off(Port2);
}
if (hour() <= 8 && hour() >= 20)
{
ReefAngel.PWM.SetChannel( 0, MoonPhase() );
ReefAngel.RF.UseMemory=false;
ReefAngel.RF.SetMode(Night,15,0);
vtechmode = 9;
}
else
{
ReefAngel.RF.UseMemory=true;
vtechmode = InternalMemory.RFMode_read();
ReefAngel.PWM.SetChannel( 0, MoonPhase(0) );
}
// This should always be the last line
ReefAngel.Portal( "bencollinz" );
ReefAngel.ShowInterface();
}
void DrawCustomMain()
{
char text[7];
// Date and Time
ReefAngel.LCD.DrawDate( 6, 2 );
ReefAngel.LCD.Clear(COLOR_BLACK, 1, 11, 132, 11);
pingSerial();
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 6, 90, "--------------------");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 6, 126, "--------------------");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 93, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 103, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 113, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 123, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 93, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 103, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 113, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 123, "|");
ReefAngel.LCD.DrawText(0,255,10,30,"Temp");
ConvertNumToString(text, ReefAngel.Params.[T1_PROBE], 10);
ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 10, 40, text, Num8x8);
pingSerial();
ReefAngel.LCD.DrawText(0,255,100,30,"pH");
ConvertNumToString(text, ReefAngel.Params.PH, 100);
ReefAngel.LCD.DrawLargeText(COLOR_PLUM, 255, 85, 40, text, Num8x8);
pingSerial();
ReefAngel.LCD.DrawText(0,255,43,48,"Salinity");
ConvertNumToString(text, ReefAngel.Params.Salinity, 100);
ReefAngel.LCD.DrawLargeText(COLOR_LIMEGREEN, 255, 49, 58, text, Num8x8);
pingSerial();
// Main Relay Box
byte TempRelay = ReefAngel.Relay.RelayData;
TempRelay &= ReefAngel.Relay.RelayMaskOff;
TempRelay |= ReefAngel.Relay.RelayMaskOn;
ReefAngel.LCD.DrawOutletBox( 12, 77, TempRelay );
pingSerial();
// water level
ReefAngel.LCD.DrawText(0,255,8,68,"WL:");
ReefAngel.LCD.DrawText( COLOR_CORNFLOWERBLUE, 40, 68, 10, ReefAngel.WaterLevel.GetLevel() );
pingSerial();
}
void DrawCustomGraph()
{
}
so this makes my ATO PORT 7 just continually cycle instead of remaining on until it reaches the proper %. what am I doing incorrect?
and I can't get water level to display on screen, what's wrong there?
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 2:15 pm
by rimai
Your coordinates are wrong.
It's printing at coordinates x=68 and y=10.
I think you what you want is this:
Code: Select all
ReefAngel.LCD.DrawText( COLOR_CORNFLOWERBLUE,255, 40, 68, ReefAngel.WaterLevel.GetLevel() );
The code you are using does just that. It will turn on whenever the level goes below 58. There is no hysteresis.
If you want hysteresis, you need to use the previous function you were using before. The one you commented out.
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 2:23 pm
by lnevo
It sounds like from what you want is to use the WaterLevelATO and just increase your timeout... or reduce the high/low difference...
I would suggest something like this.. 3 minutes instead of 1.
Code: Select all
ReefAngel.WaterLevelATO( Port7,180,52,58 ); // 180 seconds timeout, turn on at 52% and turn off at 58%
Another thing that will help to put the numbers in a better perspective is.. How long does it take to fill your sump from 52 to 58. That plus a few seconds is what you want your timeout to be.
The code you have everytime it drops to 57 it will turn on till 58 and sometimes the reported level varies from the sensor, so thats why you're seeing on / off / on / off
The other choice is making the numbers smaller. If you want it on at 52%, then leave than and reduce the 58 to something you can get to within 60 seconds.. Say 54%
Code: Select all
ReefAngel.WaterLevelATO( Port7,60,52,54 ); // 60 seconds timeout, turn on at 52% and turn off at 54%
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 2:28 pm
by bencollinz
now I get this...
Untitled4.jpg
Code: Select all
#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <ReefAngel.h>
/*
#define Heater 1
#define Return 2
#define Skimmer 3
#define Vortech1 5
#define Vortech2 6
#define ATO 7
*/
////// Place global variable code below here
byte vtechmode;
////// Place global variable code above here
void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port7Bit | Port4Bit | Port5Bit | Port6Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = 0;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit | Port7Bit | Port4Bit | Port5Bit | Port6Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;
// Ports that are always on
ReefAngel.Relay.On( Port2 );
////// Place additional initialization code below here
// Hardcode PH calibrations
ReefAngel.PHMin=576; // PH7.0
ReefAngel.PHMax=842; // PH10.0
ReefAngel.SalMax=3000; // 35ppt
////// Place additional initialization code above here
}
void loop()
{
ReefAngel.StandardHeater( Port1,796,802 );
ReefAngel.WaterLevelATO( Port7,600,55,58 ); // 60 seconds timeout, turn on at 55% and turn off at 58%
// If water level less than 58, turn on auto top off relay; else, keep it off
// if (ReefAngel.WaterLevel.GetLevel()<58) ReefAngel.Relay.On(Port7);
// else ReefAngel.Relay.Off(Port7);
ReefAngel.PWM.SetChannel( 0, MoonPhase() );
ReefAngel.PWM.Channel1PWMParabola();
ReefAngel.PWM.Channel2PWMParabola();
ReefAngel.PWM.Channel3PWMParabola();
ReefAngel.PWM.Channel4PWMSlope();
if ( ReefAngel.LowATO.IsActive())
{
ReefAngel.Relay.On(Port2);
}
else
{
ReefAngel.Relay.Off(Port2);
}
if (hour() <= 8 && hour() >= 20)
{
ReefAngel.RF.UseMemory=false;
ReefAngel.RF.SetMode(Night,15,0);
vtechmode = 9;
}
else
{
ReefAngel.RF.UseMemory=true;
vtechmode = InternalMemory.RFMode_read();
}
// This should always be the last line
ReefAngel.Portal( "bencollinz" );
ReefAngel.ShowInterface();
}
void DrawCustomMain()
{
char text[7];
// Date and Time
ReefAngel.LCD.DrawDate( 6, 2 );
ReefAngel.LCD.Clear(COLOR_BLACK, 1, 11, 132, 11);
pingSerial();
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 6, 90, "--------------------");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 6, 126, "--------------------");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 93, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 103, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 113, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, 123, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 93, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 103, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 113, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, 123, "|");
ReefAngel.LCD.DrawText(0,255,10,30,"Temp");
ConvertNumToString(text, ReefAngel.Params.[T1_PROBE], 10);
ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 10, 40, text, Num8x8);
pingSerial();
ReefAngel.LCD.DrawText(0,255,100,30,"pH");
ConvertNumToString(text, ReefAngel.Params.PH, 100);
ReefAngel.LCD.DrawLargeText(COLOR_PLUM, 255, 85, 40, text, Num8x8);
pingSerial();
ReefAngel.LCD.DrawText(0,255,43,48,"Salinity");
ConvertNumToString(text, ReefAngel.Params.Salinity, 10);
ReefAngel.LCD.DrawLargeText(COLOR_LIMEGREEN, 255, 49, 58, text, Num8x8);
pingSerial();
// Main Relay Box
byte TempRelay = ReefAngel.Relay.RelayData;
TempRelay &= ReefAngel.Relay.RelayMaskOff;
TempRelay |= ReefAngel.Relay.RelayMaskOn;
ReefAngel.LCD.DrawOutletBox( 12, 77, TempRelay );
pingSerial();
// water level
ReefAngel.LCD.DrawText(0,255,8,68,"WL:");
ReefAngel.LCD.DrawText( COLOR_CORNFLOWERBLUE,255, 40, 68, ReefAngel.WaterLevel.GetLevel() );
pingSerial();
}
void DrawCustomGraph()
{
}
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 2:37 pm
by bencollinz
rimai wrote:Your coordinates are wrong.
It's printing at coordinates x=68 and y=10.
I think you what you want is this:
Code: Select all
ReefAngel.LCD.DrawText( COLOR_CORNFLOWERBLUE,255, 40, 68, ReefAngel.WaterLevel.GetLevel() );
.
Thank you, that worked!
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 3:00 pm
by rimai
I think you already figured out, but just for records...
Your reference to T1 was wrong....
It should be this:
Code: Select all
ConvertNumToString(text, ReefAngel.Params.Temp[T1_PROBE], 10);
Re: My code - water level ATO help needed
Posted: Mon Mar 25, 2013 3:46 pm
by bencollinz
rimai wrote:I think you already figured out, but just for records...
Your reference to T1 was wrong....
It should be this:
Code: Select all
ConvertNumToString(text, ReefAngel.Params.Temp[T1_PROBE], 10);
yessir! everything is working so far, have to wait and see about the ATO changes.
Re: My code
Posted: Mon Mar 25, 2013 3:59 pm
by bencollinz
Code: Select all
if ( ReefAngel.LowATO.IsActive())
{
ReefAngel.Relay.On(Port2);
}
else
{
ReefAngel.Relay.Off(Port2);
for this, how do I require a clear command from RA menu when tripped?
Re: My code
Posted: Mon Mar 25, 2013 4:07 pm
by lnevo
Use the SingleATOLow function
Re: My code
Posted: Mon Mar 25, 2013 4:43 pm
by bencollinz
lnevo wrote:Use the SingleATOLow function
maybe I'm misunderstanding, I changed it to this:
and it doesn't turn port 2 off, just changes the status on the portal....?
My code
Posted: Mon Mar 25, 2013 5:19 pm
by lnevo
Did you change that whole section of code? It should go off when the switch is inactive. You may have the switch upside down. Which way is it facing?
Re: My code
Posted: Tue Mar 26, 2013 3:55 am
by bencollinz
lnevo wrote:Did you change that whole section of code? It should go off when the switch is inactive. You may have the switch upside down. Which way is it facing?
the wires are facing up. i removed
Code: Select all
if ( ReefAngel.LowATO.IsActive())
{
ReefAngel.Relay.On(Port2);
}
else
{
ReefAngel.Relay.Off(Port2);
and replaced with
again, maybe I'm misunderstanding, sorry.
Re: My code - water level ATO help needed
Posted: Tue Mar 26, 2013 8:18 am
by bencollinz
lnevo wrote:It sounds like from what you want is to use the WaterLevelATO and just increase your timeout... or reduce the high/low difference...
I would suggest something like this.. 3 minutes instead of 1.
Code: Select all
ReefAngel.WaterLevelATO( Port7,180,52,58 ); // 180 seconds timeout, turn on at 52% and turn off at 58%
Another thing that will help to put the numbers in a better perspective is.. How long does it take to fill your sump from 52 to 58. That plus a few seconds is what you want your timeout to be.
The code you have everytime it drops to 57 it will turn on till 58 and sometimes the reported level varies from the sensor, so thats why you're seeing on / off / on / off
The other choice is making the numbers smaller. If you want it on at 52%, then leave than and reduce the 58 to something you can get to within 60 seconds.. Say 54%
Code: Select all
ReefAngel.WaterLevelATO( Port7,60,52,54 ); // 60 seconds timeout, turn on at 52% and turn off at 54%
so i changed it back to this format
Code: Select all
ReefAngel.WaterLevelATO( Port7,60,52,54 );
water went from 61% to now 50% and it didn't turn on even for a blip...ideas?
Re: My code
Posted: Tue Mar 26, 2013 8:25 am
by rimai
Are you sure it isn't timed out already?
Just to be sure, can you clear ATO?
Re: My code
Posted: Tue Mar 26, 2013 8:56 am
by bencollinz
rimai wrote:Are you sure it isn't timed out already?
Just to be sure, can you clear ATO?
the red light was on, I chose clear ATO it started and wouldn't stop. the red light came on again, I cleared again, it still wouldn't turn off. it's now at 61% again. I had to turn off manually.
current code:
Code: Select all
#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <ReefAngel.h>
/*
#define Heater 1
#define Return 2
#define Skimmer 3
#define Vortech1 5
#define Vortech2 6
#define ATO 7
*/
////// Place global variable code below here
byte vtechmode;
////// Place global variable code above here
void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port4Bit | Port5Bit | Port6Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port7Bit | Port4Bit | Port5Bit | Port6Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = 0;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit | Port7Bit | Port4Bit | Port5Bit | Port6Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;
// Ports that are always on
ReefAngel.Relay.On( Port2 );
////// Place additional initialization code below here
// Hardcode calibrations
ReefAngel.PHMin=576; // PH7.0
ReefAngel.PHMax=842; // PH10.0
ReefAngel.SalMax=3000; // 35ppt
////// Place additional initialization code above here
}
void loop()
{
ReefAngel.StandardHeater( Port1,796,802 );
ReefAngel.WaterLevelATO( Port7,600,58,60 );
// If water level less than 58, turn on auto top off relay; else, keep it off
// if (ReefAngel.WaterLevel.GetLevel()<58) ReefAngel.Relay.On(Port7);
// else ReefAngel.Relay.Off(Port7);
ReefAngel.PWM.SetChannel( 0, MoonPhase() );
ReefAngel.PWM.Channel1PWMParabola();
ReefAngel.PWM.Channel2PWMParabola();
ReefAngel.PWM.Channel3PWMParabola();
ReefAngel.PWM.Channel4PWMSlope();
// ReefAngel.SingleATOLow(Port2);
if ( ReefAngel.LowATO.IsActive())
{
ReefAngel.Relay.On(Port2);
}
else
{
ReefAngel.Relay.Off(Port2);
if (hour() <= 8 && hour() >= 20)
{
ReefAngel.RF.UseMemory=false;
ReefAngel.RF.SetMode(Night,15,0);
vtechmode = 9;
}
else
{
ReefAngel.RF.UseMemory=true;
vtechmode = InternalMemory.RFMode_read();
}
// This should always be the last line
ReefAngel.Portal( "bencollinz" );
ReefAngel.ShowInterface();
}
void DrawCustomMain()
{
char text[7];
// Date and Time
ReefAngel.LCD.DrawDate( 6, 2 );
ReefAngel.LCD.Clear(COLOR_BLACK, 1, 11, 132, 11);
pingSerial();
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 6, 90, "--------------------");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 6, 126, "--------------------");
for (byte Left=93; Left < 133; Left+=10)
{
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 2, Left, "|");
ReefAngel.LCD.DrawText(COLOR_TOMATO,255, 126, Left, "|");
}
ReefAngel.LCD.DrawText(0,255,18,12,"EcoSmart Vortech");
ReefAngel.LCD.Clear(255, 1, 19, 128, 29);
if (vtechmode == 0) ReefAngel.LCD.DrawLargeText(COLOR_LIMEGREEN,255,35,21,"Constant");
else if(vtechmode == 1) ReefAngel.LCD.DrawLargeText(COLOR_GOLD,255,42,21,"Lagoon");
else if (vtechmode == 2) ReefAngel.LCD.DrawLargeText(COLOR_GOLD,255,25,21,"Reef Crest");
else if (vtechmode == 3) ReefAngel.LCD.DrawLargeText(COLOR_CORNFLOWERBLUE,255,22,21,"Short Pulse");
else if (vtechmode == 4) ReefAngel.LCD.DrawLargeText(COLOR_PINK,255,25,21,"Long Pulse");
else if (vtechmode == 5) ReefAngel.LCD.DrawLargeText(COLOR_MAGENTA,255,8,21,"Nutrient Trnsp.");
else if (vtechmode == 6) ReefAngel.LCD.DrawLargeText(COLOR_MAGENTA,255,23,21,"Tidal Swell");
else if (vtechmode == 9) ReefAngel.LCD.DrawLargeText(COLOR_WHITE,0,45,21,"Night");
ReefAngel.LCD.DrawText(0,255,10,30,"Temp");
ConvertNumToString(text, ReefAngel.Params.Temp[T1_PROBE], 10);
ReefAngel.LCD.DrawLargeText(COLOR_INDIANRED, 255, 10, 40, text, Num8x8);
pingSerial();
ReefAngel.LCD.DrawText(0,255,100,30,"pH");
ConvertNumToString(text, ReefAngel.Params.PH, 100);
ReefAngel.LCD.DrawLargeText(COLOR_PLUM, 255, 85, 40, text, Num8x8);
pingSerial();
ReefAngel.LCD.DrawText(0,255,43,48,"Salinity");
ConvertNumToString(text, ReefAngel.Params.Salinity, 10);
ReefAngel.LCD.DrawLargeText(COLOR_LIMEGREEN, 255, 49, 58, text, Num8x8);
pingSerial();
// Main Relay Box
byte TempRelay = ReefAngel.Relay.RelayData;
TempRelay &= ReefAngel.Relay.RelayMaskOff;
TempRelay |= ReefAngel.Relay.RelayMaskOn;
ReefAngel.LCD.DrawOutletBox( 12, 77, TempRelay );
pingSerial();
// water level
ReefAngel.LCD.DrawText(0,255,8,68,"WL:");
ReefAngel.LCD.DrawText( COLOR_CORNFLOWERBLUE,255, 40, 68, ReefAngel.WaterLevel.GetLevel() );
pingSerial();
}
void DrawCustomGraph()
{
}
Re: My code
Posted: Tue Mar 26, 2013 9:31 am
by rimai
Are you sure you uploaded this code?
It says timeout is 600 seconds. Was your ATO pump on for 600 seconds before it turned the red led again?
Re: My code
Posted: Tue Mar 26, 2013 1:28 pm
by bencollinz
rimai wrote:Are you sure you uploaded this code?
It says timeout is 600 seconds. Was your ATO pump on for 600 seconds before it turned the red led again?
yes, that is the current code.
the red light comes on after 10 mins every time I 'clear ATO' from menu, regardless of the port running or not.
The port did turn itself off at the proper % finally, though.
Re: My code
Posted: Tue Mar 26, 2013 2:29 pm
by rimai
So, you are getting ato timeout even when the port is supposed to be off?
You are not overriding it off, are you?
If you do, it would definitely timeout.
Re: My code
Posted: Tue Mar 26, 2013 3:19 pm
by bencollinz
rimai wrote:So, you are getting ato timeout even when the port is supposed to be off?
You are not overriding it off, are you?
If you do, it would definitely timeout.
so, for example, right now, the red light is on. i'll 'clear ato', the water is at 56%, so the port turned on for ATO, the red light came back on ~1-2 mins, i 'clear ato' (the port still on all the while), the port shuts off at 60%.
it's on auto via portal or reboot, not changing to off.
Re: My code
Posted: Tue Mar 26, 2013 3:26 pm
by bencollinz
and now the red light is on again. ~10 mins after I last pressed 'clear ato'
cleared it again, got it ~2 mins later
Re: My code
Posted: Tue Mar 26, 2013 4:04 pm
by rimai
I think you found a bug
Can you disconnect the ATO Low float switch and see if the problem is fixed?
Re: My code
Posted: Tue Mar 26, 2013 4:49 pm
by bencollinz
rimai wrote:I think you found a bug
Can you disconnect the ATO Low float switch and see if the problem is fixed?
I unplugged that, rebooted RA, let it sit for 20 mins and now my return pump port 2 just shut off.
but that was also the first time i set port 2 to auto instead of on.
Re: My code
Posted: Tue Mar 26, 2013 5:13 pm
by bencollinz
the ATO pump went on and off just as it should without the float switch! and no red light to clear.
Re: My code
Posted: Tue Mar 26, 2013 5:35 pm
by rimai
Yeah, just what thought.
The libraries code is sharing the part of the code with the low float switch.
I'll have to update it.
Should be fixed in the next update.
In the mean time, you can use the high ato port for your return.
Re: My code
Posted: Tue Mar 26, 2013 5:37 pm
by rimai