PWM ramp up and down

rimai · Post by **rimai** » Wed Apr 13, 2011 10:05 pm

Maybe you are seeing something that I'm not.

b_s_c1 wrote: ReefAngel.PWM.SetActinic(PWMSlope(12,0,22,0,15,100,60,ReefAngel.PWM.GetActinicValue()));

Again, the slopes are from start to end.
The above line tells me that blue slope starts at noon with 15% and go up to 100% at 1pm and then from 100% at 9pm down to 15% at 10pm.
I'm not so sure why at 6pm it was showing 15% though.
Can you attach your code so I can try to replicate the problem you are getting?

b_s_c1 · Post by **b_s_c1** » Thu Apr 14, 2011 8:42 pm

rimai wrote:Maybe you are seeing something that I'm not.
b_s_c1 wrote: ReefAngel.PWM.SetActinic(PWMSlope(12,0,22,0,15,100,60,ReefAngel.PWM.GetActinicValue()));
Again, the slopes are from start to end.
The above line tells me that blue slope starts at noon with 15% and go up to 100% at 1pm and then from 100% at 9pm down to 15% at 10pm.
I'm not so sure why at 6pm it was showing 15% though.
Can you attach your code so I can try to replicate the problem you are getting?

Here you go. I hope you can get it figured out.

// Autogenerated file by RAGen (v1.0.4.92), (04/09/2011 11:36)
// Memory_040911_1136.pde
//
// This file sets the default values to the Internal Memory
//

#include <ReefAngel_Features.h>
#include <ReefAngel_Globals.h>
#include <Time.h>
#include <OneWire.h>
#include <Phillips6610LCDInv.h>
#include <avr/pgmspace.h>
#include <ReefAngel_EEPROM.h>

Phillips6610LCDInv e;

void setup()
{
e.lcd_init();
e.lcd_clear(COLOR_WHITE,0,0,132,132);
e.lcd_BacklightOn();

InternalMemory.MHOnHour_write(8);
InternalMemory.MHOnMinute_write(0);
InternalMemory.MHOffHour_write(15);
InternalMemory.MHOffMinute_write(0);
InternalMemory.MHDelay_write(5);
InternalMemory.StdLightsOnHour_write(11);
InternalMemory.StdLightsOnMinute_write(0);
InternalMemory.StdLightsOffHour_write(23);
InternalMemory.StdLightsOffMinute_write(0);
InternalMemory.DP1OnHour_write(20);
InternalMemory.DP1OnMinute_write(0);
InternalMemory.DP2OnHour_write(22);
InternalMemory.DP2OnMinute_write(30);
InternalMemory.DP1Timer_write(10);
InternalMemory.DP2Timer_write(10);
InternalMemory.DP1RepeatInterval_write(60);
InternalMemory.DP2RepeatInterval_write(60);
InternalMemory.ATOTimeout_write(255);
InternalMemory.ATOHighTimeout_write(60);
InternalMemory.ATOHourInterval_write(3);
InternalMemory.ATOHighHourInterval_write(0);
InternalMemory.FeedingTimer_write(900);
InternalMemory.LCDTimer_write(600);
InternalMemory.LEDPWMActinic_write(15);
InternalMemory.LEDPWMDaylight_write(15);
InternalMemory.WM1Timer_write(0);
InternalMemory.WM2Timer_write(0);
InternalMemory.HeaterTempOn_write(780);
InternalMemory.HeaterTempOff_write(791);
InternalMemory.ChillerTempOn_write(810);
InternalMemory.ChillerTempOff_write(785);
InternalMemory.OverheatTemp_write(1500);
InternalMemory.PHMax_write(840);
InternalMemory.PHMin_write(550);
}

void loop()
{
// display the values
char buf[128];
sprintf(buf, "MH %2d:%02d-%2d:%02d,%d", InternalMemory.MHOnHour_read(), InternalMemory.MHOnMinute_read(),
InternalMemory.MHOffHour_read(), InternalMemory.MHOffMinute_read(),
InternalMemory.MHDelay_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW, buf);
sprintf(buf, "Std %2d:%02d-%2d:%02d", InternalMemory.StdLightsOnHour_read(), InternalMemory.StdLightsOnMinute_read(),
InternalMemory.StdLightsOffHour_read(), InternalMemory.StdLightsOffMinute_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*2, buf);
sprintf(buf, "LED A: %d%% D: %d%%", InternalMemory.LEDPWMActinic_read(), InternalMemory.LEDPWMDaylight_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*3, buf);
sprintf(buf, "WM1: %ds", InternalMemory.WM1Timer_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*4, buf);
sprintf(buf, "WM2: %ds", InternalMemory.WM2Timer_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*5, buf);
sprintf(buf, "F: %ds", InternalMemory.FeedingTimer_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*6, buf);
sprintf(buf, "S: %ds", InternalMemory.LCDTimer_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*7, buf);
sprintf(buf, "H On: %d -> %d", InternalMemory.HeaterTempOn_read(), InternalMemory.HeaterTempOff_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*9, buf);
sprintf(buf, "C On: %d -> %d", InternalMemory.ChillerTempOn_read(), InternalMemory.ChillerTempOff_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*10, buf);
sprintf(buf, "PH %d - %d", InternalMemory.PHMax_read(), InternalMemory.PHMin_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*11, buf);

delay(10000);
e.lcd_clear(COLOR_WHITE,0,0,132,132);

sprintf(buf, "OH: %dF", InternalMemory.OverheatTemp_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW, buf);
sprintf(buf, "ATO L: %ds (%dh)", InternalMemory.ATOTimeout_read(), InternalMemory.ATOHourInterval_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*2, buf);
sprintf(buf, "ATO H: %ds (%dh)", InternalMemory.ATOHighTimeout_read(), InternalMemory.ATOHighHourInterval_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*3, buf);

sprintf(buf, "DP1: %2d:%02d", InternalMemory.DP1OnHour_read(), InternalMemory.DP1OnMinute_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*5, buf);
sprintf(buf, " %ds", InternalMemory.DP1Timer_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*6, buf);
sprintf(buf, "DP2: %2d:%02d", InternalMemory.DP2OnHour_read(), InternalMemory.DP2OnMinute_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*7, buf);
sprintf(buf, " %ds", InternalMemory.DP2Timer_read());
e.lcd_draw_text(COLOR_BLACK, COLOR_WHITE, MENU_START_COL, MENU_START_ROW*8, buf);

delay(10000);
e.lcd_clear(COLOR_WHITE,0,0,132,132);
}

// Autogenerated file by RAGen (v1.0.4.92), (04/09/2011 11:37)
// RA_040911_1137.pde
//
// This version designed for v0.8.5 Beta 12 or later

/* The following features are enabled for this PDE File:
#define DisplayImages
#define DateTimeSetup
#define VersionMenu
#define ATOSetup
#define DirectTempSensor
#define DisplayLEDPWM
#define SingleATOSetup
#define StandardLightSetup
*/

#include <ReefAngel_Features.h>
#include <ReefAngel_Globals.h>
#include <ReefAngel_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <ReefAngel_EEPROM.h>
#include <ReefAngel_NokiaLCD.h>
#include <ReefAngel_ATO.h>
#include <ReefAngel_Joystick.h>
#include <ReefAngel_LED.h>
#include <ReefAngel_TempSensor.h>
#include <ReefAngel_Relay.h>
#include <ReefAngel_PWM.h>
#include <ReefAngel_Timer.h>
#include <ReefAngel_Memory.h>
#include <ReefAngel.h>

void setup()
{
ReefAngel.Init(); //Initialize controller

ReefAngel.FeedingModePorts = B10000000;
ReefAngel.WaterChangePorts = B10000000;
ReefAngel.OverheatShutoffPorts = B00000001;
ReefAngel.LightsOnPorts = B00000100;

// Ports that are always on
ReefAngel.Relay.On(Port5);
ReefAngel.Relay.On(Port6);
ReefAngel.Relay.On(Port7);
ReefAngel.Relay.On(Port8);
}

void loop()
{
ReefAngel.ShowInterface();

// Specific functions
ReefAngel.StandardHeater(Port1);
ReefAngel.StandardFan(Port2);
ReefAngel.StandardLights(Port3);
ReefAngel.SingleATOLow(Port4);

// Have PWM on from 12pm to 12am, with gradual 60 minute ramp up and down starting at the given times
// From 12pm to 1pm, actinic and 1pm to 2pm daylightthe PWM will slowly ramp from 15% to 100%
// From 9 pm to 10pm, daylight and 10 to 11 actinic the PWM will slowly ramp from 100% to 15%
ReefAngel.PWM.SetActinic(PWMSlope(12,0,22,0,15,100,60,ReefAngel.PWM.GetActinicValue()));
ReefAngel.PWM.SetDaylight(PWMSlope(13,0,21,0,15,100,60,ReefAngel.PWM.GetDaylightValue()));

}

rimai · Post by **rimai** » Fri Apr 15, 2011 9:57 am

This line is wrong. Won't afftect code, because it's just comments, but for your reference in the future.

b_s_c1 wrote: // From 9 pm to 10pm, daylight and 10 to 11 actinic the PWM will slowly ramp from 100% to 15%

Should be this:

// From 8 pm to 9pm, daylight and 9 to 10 actinic the PWM will slowly ramp from 100% to 15%

It's working fine here on my tests:

12:00PM - AP(15%), DP(15%)
12:30PM - AP(57%), DP(15%)
1:00PM - AP(100%), DP(15%)
1:30PM - AP(100%), DP(57%)
2:00PM - AP(100%), DP(100%)
6:00PM - AP(100%), DP(100%)
8:00PM - AP(100%), DP(100%)
8:30PM - AP(100%), DP(58%)
9:00PM - AP(100%), DP(15%)
9:30PM - AP(58%), DP(15%)
10:00PM - AP(15%), DP(15%)

b_s_c1 · Post by **b_s_c1** » Fri Apr 15, 2011 12:05 pm

Thanks for your help and sorry for the trouble. I think I just found the problem. I was changing a LED that was burned out and noticed it was shorted to the heat sink. When I disconnected that string the other strings went to the correct value. I then went through the hole array of lights to check for more shorts and found one more. These were corrected and the program has been running fine since then.

One more question. Should the PWM reading on the RA display be the current output? Mine stays at 0% all the time but the ramp up works correctly.

I changed the scale to 0% to have the ramp up and down turn on and off the lights to avoid the inrush current on the drivers.

rimai · Post by **rimai** » Fri Apr 15, 2011 12:10 pm

Glad it is working now

alexwbush · Post by **alexwbush** » Sun Apr 24, 2011 12:13 pm

what kind of LED setup do you guys run? I am thinking about switching over and want something dimmable with moonlights. I'll probably end up with a DIY kit from rapidLED, but wanted to see what you guys had. I know Roberto told me unless you're using Buckpucks you can only dim so far.

bmhair03 · Post by **bmhair03** » Mon Apr 25, 2011 9:24 am

I'm using a DYI from RapidLED. Mike there is a great guy ,and has great customer service. Yes with Meanwells you ll only get to about 15%, Buckpucks will give you full dim. Good to see someone from down south I lived in Santa Barbara for 10 yrs . Moved back to the Bay Area 3yrs ago. All me and my wife do now is plan how to get back down there! Ive made several changes to my Fixture since I first finished it .Look into clustering,It will help with color banding and a mixture of LEDs. Cool White with Royal blue and Blue. I'm very happy with it and the idea of not having to buy another bulb or 4 is awesome.
Reef Central has some good threads on Leds and there's a forum here in the Bay Area that has some great threads on Leds . I thought I read a lot but I still ended up changing things after .
http://www.bareefers.org/home/
Hope this helps.

ahmedess · Post by **ahmedess** » Fri Jun 10, 2011 4:41 am

I have read through the thread and from what i understood is that you guys turn the drivers off, after reaching 15-20%, using a relayed outlet during the night period instead of ramping down to zero because of the meanwell driver limitation.

I would like to use the pwm ramp function. But instead of using a relayed outlet I will be connecting the drivers of a regular outlet and I want to turn the leds on and off using pwm so i would like a function to do the following:

From 0% step up directly to 20% then ramp up to 100% then ramp down to 20% and then steps directly down to 0%.

I have tried using the function in this thread to ramp up and down from 20% and set my internal memory to 0% but it doesn't step down and up correctly as I want it.

Also in case of starting up from a power outage I would like the controller to check the time and turn the leds on or off depending on that using pwm.

rimai · Post by **rimai** » Fri Jun 10, 2011 7:43 am

Hi,
Yes, it is possible.
Although, even at 0% you are still wasting energy on the meanwell, just like a TV on stand by.
But I'd think it's minimal.
Anyway, the easiest way is to use the PWM slope function the regular way you want to achieve, which is from 20% to 100% within your own schedule.
Then, the next line of code should be:

Code: Select all

    if ((NumMins(hour(now()),minute(now())) < NumMins(15,30)) || (NumMins(hour(now()),minute(now())) > NumMins(21,0)))
   {
     ReefAngel.PWM.SetDaylight(0);
     ReefAngel.PWM.SetActinic(0);
   }

You can change the schedule to match your own.
The example above is turning both PWM channels to 0% if it is earlier than 3:30pm and later than 9:00pm.

ahmedess · Post by **ahmedess** » Fri Jun 10, 2011 9:38 am

thats great thanks a lot.

About starting up from a power outage I would like the controller to check the time and resume the pwm light schedule instead of using internal memory's stored value.

rimai · Post by **rimai** » Fri Jun 10, 2011 9:43 am

Pretty sure it already does that

ahmedess · Post by **ahmedess** » Fri Jun 10, 2011 11:18 am

I ve uploaded the program with the code you have just posted and now the LEDs should be at 100% but its at 0% now

ahmedess · Post by **ahmedess** » Fri Jun 10, 2011 11:23 am

here is the pwm code i placed in my pde:

Code: Select all

// Have PWM on from 4p to 1a, with gradual 60 minute ramp up and down starting at the given times
    // From 4p to 5p, the PWM will slowly ramp from 20% to 100%
    // From 12a to 1a, the PWM will slowly ramp from 100% to 20%
    ReefAngel.PWM.SetActinic(PWMSlope(16,0,1,0,20,100,60,ReefAngel.PWM.GetActinicValue()));
    ReefAngel.PWM.SetDaylight(PWMSlope(16,0,1,0,20,100,60,ReefAngel.PWM.GetDaylightValue()));
   
    if ((NumMins(hour(now()),minute(now())) < NumMins(16,0)) || (NumMins(hour(now()),minute(now())) > NumMins(1,0)))
   {
     ReefAngel.PWM.SetDaylight(0);
     ReefAngel.PWM.SetActinic(0);

binder · Post by **binder** » Fri Jun 10, 2011 11:53 am

ahmedess wrote:thats great thanks a lot.

About starting up from a power outage I would like the controller to check the time and resume the pwm light schedule instead of using internal memory's stored value.

The controller should do that. What will happen is initially (as in right at startup), it will restore to what the internal memory is set at. Once it starts running through the loop of the functions, it will resume the PWM where it should be based on the PWM calculations.

That's how it has worked for me during all of my testing and I do believe that is how it has worked for everybody else.

curt

ahmedess · Post by **ahmedess** » Fri Jun 10, 2011 12:06 pm

Curt,

Is there anything wrong with the code i posted above? I have this code placed in loop()

ahmedess · Post by **ahmedess** » Fri Jun 10, 2011 1:16 pm

I don't have the drivers connected to my controller yet cause I ve ordered them and they are on their way. The only way I could tell if its working or not is through the display of AP and DP on the LCD screen and the display says they are both Zero when they re supposed to be 100. Is it possible that the displayed values are incorrect and the output is correct?

binder · Post by **binder** » Fri Jun 10, 2011 5:59 pm

ahmedess wrote:Curt,

Is there anything wrong with the code i posted above? I have this code placed in loop()

Yes, there is a problem with the code above. The additional IF statement is incorrect. That statement will always be true and always set your PWM to 0%.

Your code says: if the current time is before 4pm OR after 1am, set the PWM to 0%

When this is tested, just about every minute encountered will be after 1am and therefore cause that if statement to evaluate to true. The OR conditional indicates that if either expression is true, the entire condition will be true.

You have some options:

Remove the IF statement completely and leave the ramp up and down alone
Remove the IF statement completely and change the ramp up and down to be from 0% to 100%
Change the IF statement around. Since you are running the PWM from 4p to 1a, your logic in the if statement needs to be changed to work properly

Changing the IF statement around like this will yield the appropriate response:

Code: Select all

if ( (NumMins(hour(), minute()) > NumMins(1,0)) &&
     (NumMins(hour(), minute()) < NumMins(16, 0)) )
{
    ReefAngel.PWM.SetActinic(0);
    ReefAngel.PWM.SetDaylight(0);
}

This code says: If the current time is after 1am AND before 4pm, set the PWM to 0%. Otherwise don't touch it

So there are your options with the solutions to them all.

curt

ahmedess · Post by **ahmedess** » Sat Jun 11, 2011 10:13 am

I still get the displayed values on the LCD screen for AP and DP equal to zero when they should be 100. Is it possible that the problem is with the displayed values?

ahmedess · Post by **ahmedess** » Sat Jun 11, 2011 10:37 am

b_s_c1 wrote: One more question. Should the PWM reading on the RA display be the current output? Mine stays at 0% all the time but the ramp up works correctly.

I changed the scale to 0% to have the ramp up and down turn on and off the lights to avoid the inrush current on the drivers.

It seems that b_s_c1 had the same issue with the displayed values. the problem is that i dont have the LEDs at the moment to test whether the output is correct or not. if its the problem with the displayed value how can I fix it?

binder · Post by **binder** » Sat Jun 11, 2011 6:34 pm

ahmedess wrote:I still get the displayed values on the LCD screen for AP and DP equal to zero when they should be 100. Is it possible that the problem is with the displayed values?

The display gets the value from the PWM every time it is updated. So the value is not just stored and displayed.

When I've tested the PWM slope function, I watched the values go up and down appropriately as others have experienced as well.

I do not have anything attached to the PWM to confirm or deny this but it should be working appropriately. My thoughts are that your IF statement is messing things up (even though I sent you an update for it, I never tested it). I want you to remove that IF statement (or comment it out or whatever) and run your code. I think you will find that it will work as it is supposed to. When you start changing the PWM outside the slope function, that's when things can start to get tricky and confusing and other undesired results happen.

Comment out the IF statement and test again (try the first 2 options of my previous post is what I'm saying).

curt

rimai · Post by **rimai** » Sun Jun 12, 2011 9:18 am

I've tested with this:

Code: Select all

    ReefAngel.PWM.SetActinic(PWMSlope(16,0,1,0,20,100,60,ReefAngel.PWM.GetActinicValue()));
    ReefAngel.PWM.SetDaylight(PWMSlope(16,0,1,0,20,100,60,ReefAngel.PWM.GetDaylightValue()));
   
if ( (NumMins(hour(), minute()) > NumMins(1,0)) &&
     (NumMins(hour(), minute()) < NumMins(16, 0)) )
{
    ReefAngel.PWM.SetActinic(0);
    ReefAngel.PWM.SetDaylight(0);
}

Here is the results:

4:00:00 = 0%
15:59:59 = 0%
16:00:00 = 20%
16:11:40 = 34%
16:27:10 = 56%
16:43.30 = 77%
17:16:40 = 100%
20:03:23 = 100%
23:59:59 = 100%
0:0:0 = 100%
0:11:04 = 86%
0:44:05 = 40%
0:50:08 = 34%
0:59:59 = 22%
1:00:00 = 20%
1:00:59 = 20%
1:01:00 = 0%
4:01:34 = 0%
09:56:48 = 0%

ahmedess · Post by **ahmedess** » Sun Jun 12, 2011 10:49 am

I have tried to ramp from 0 to 100 and I have tried to remove the IF statement but still no change.

Here is what I've found out:

After leaving the code running on the controller for 24 hrs, AP and DP values on the LCD screen have changed according to the correct schedule.

So this is what's happening, If the controller was powered on during the "LED on" period, lights will remain off until it goes through the cycle and starts a new one then it will turn on according to schedule. so it has to go through the on period then through the off period then it will turns on correctly.

Roberto, Is it possible that you run your test again but instead of begining on a time when the lights are off could you begin on a time when the lights are 100% and go through a cycle of "on" "off" "on" instead of an "off" "on" "off" cycle.

alexwbush · Post by **alexwbush** » Sun Jun 12, 2011 1:11 pm

quick off topic question for you guys...

I want to switch to LEDs and meanwells only time to 15%... what setup are you guys using and where did you get it such that it can start at 0%??? Please feel free to PM me so I don't mess up this thread anymore.

ahmedess · Post by **ahmedess** » Sun Jun 12, 2011 1:54 pm

I'm using Mean Well drivers. What I'm doing that I start from 0% then jump to 20% ramp to 100% then go back the same way. I m not using the drivers in the 0% to 20% range

rimai · Post by **rimai** » Sun Jun 12, 2011 2:32 pm

My tests were with resetting the controller for every reading.
I'm not going to sit and wait the clock to get to the reading I needed

ahmedess · Post by **ahmedess** » Sun Jun 12, 2011 3:01 pm

I thought you run the test using simulation. I know I've been bugging you and Curt with a lot of questions. Your help is really appreciated. I'm just trying to figure out why I m having this problem.

About the function:

Code: Select all

byte PWMSlope(byte startHour, byte startMinute, byte endHour, byte endMinute, byte startPWM, byte endPWM, byte Duration, byte oldValue)
{
	int Now = NumMins(hour(), minute());
	int Start = NumMins(startHour, startMinute);
	int StartD = Start + Duration;
	int End = NumMins(endHour, endMinute);
	int StopD = End - Duration;

	if ( Now >= Start && Now <= StartD )
		return constrain(map(Now, Start, StartD, startPWM, endPWM),startPWM, endPWM);
	else if ( Now >= StopD && Now <= End )
	{
		byte v = constrain(map(Now, StopD, End, startPWM, endPWM),startPWM, endPWM);
		return endPWM-v+startPWM;
	}
	else if ( Now > StartD && Now < StopD )
		return endPWM;

    // lastly return the existing value
    return oldValue;
}

I m trying to understand its code. this function returns two values, one is oldValue and the other is depending on the if statment. lets say this condition is true " else if ( Now > StartD && Now < StopD ) " then the function will return with oldValue and endPWM. are their values any different? Also what is the use of oldValue in this function?

rimai · Post by **rimai** » Sun Jun 12, 2011 5:00 pm

Almost there.
When the code finds a return statement, it just exits the function returning whatever it is passed after the return.
Som, in the case you mentioned, it would return endPWM.
The oldValue is one of the input parameters of PWMSlope function

Code: Select all

byte PWMSlope(byte startHour, byte startMinute, byte endHour, byte endMinute, byte startPWM, byte endPWM, byte Duration, byte oldValue)

It will only return oldValue if none of the 3 if statements are true.

ahmedess · Post by **ahmedess** » Mon Jun 13, 2011 11:48 am

I have found out something very interesting. I wanted to test if PWMSlope() was returning oldValue for some reason so i changed the function's input parameters to this:

ReefAngel.PWM.SetActinic(PWMSlope(16,0,1,0,20,100,60,100));

instead of this:

ReefAngel.PWM.SetActinic(PWMSlope(16,0,1,0,20,100,60,ReefAngel.PWM.GetActinicValue()));

and then compiled and loaded the code to the controller and the result was AP=100% while the daylight function which was left as it is was at zero.

There is a bug that causes the function to return oldValue when it should return endPWM and this only happens if you schedule endHour to be smaller than startHour in value. In my schedule StartD= 1020mins and StopD=0mins when you do this comparison
if ( Now > StartD && Now < StopD )
and lets say Now=1200mins which should return true for this condition returns False because Now is not less than StopD

ahmedess · Post by **ahmedess** » Mon Jun 13, 2011 2:46 pm

I have modified the PWMSlope function a bit incase any one wants to set his LEDs off time after midnight. here is the modified function:

Code: Select all

byte PWMSlope(byte startHour, byte startMinute, byte endHour, byte endMinute, byte startPWM, byte endPWM, byte Duration, byte oldValue)
{
	int Now = NumMins(hour(), minute());
	int Start = NumMins(startHour, startMinute);
	int StartD = Start + Duration;
	int End = NumMins(endHour, endMinute);
	
//Time correction if end time chosen is after midnight

	if ( Start > End )
	{
		End= End+1440;	// 1440mins = 24hr*60mins	
	}

	int StopD = End - Duration;

	if ( Now >= Start && Now <= StartD )
		return constrain(map(Now, Start, StartD, startPWM, endPWM),startPWM, endPWM);
	else if ( Now >= StopD && Now <= End )
	{
		byte v = constrain(map(Now, StopD, End, startPWM, endPWM),startPWM, endPWM);
		return endPWM-v+startPWM;
	}
	else if ( Now > StartD && Now < StopD )
		return endPWM;

    // lastly return the existing value
    return oldValue;
}

rimai · Post by **rimai** » Mon Jun 13, 2011 2:50 pm

Did this solve the issue you were having?

Reef Angel Forum

PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Re: PWM ramp up and down

Login • Register