Page 3 of 4
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 7:54 am
by lnevo
The offset is divided by 100 and then multiplied by the speed.
So if speed is 50 and your offset is 125, the the new speed should be 50*(125/100) which would be 50*1.25 which would be 62.5%
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 7:57 am
by lnevo
The offset is applied before the threshold is applied so that should prevent it from getting set over 100. I'll review that though, I haven't looked at the PumpThreshold function.
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 8:07 am
by lnevo
I added some parenthesis where I do the calculation. This should help. I really don't see any other reason why it wouldn't at this point. Let's see how you're test goes. If worse case scenario, I'll add a phantom DCPump set to my INO and see what happens

Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 8:17 am
by lnevo
I added a constraint to PumpThreshold() to make sure it won't give a setting over 100% as well, just in case

Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 4:46 pm
by Sacohen
OK. I downloaded and installed your new dev code.
I set the Internal Memory to Constant with a speed of 100.
Set the offset in my code to 30 and uploaded the code.
The offset did work, but it was applied to the Daylight Channel not the Actinic Channel.
I thought it was going to be applied to the Actinic channel.
Maybe I just assumed because that is the channel I need to run slower since that one is my WP-40 and the Daylight is my WP-25.
If you intended to effect the Daylight channel then it worked fine.
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 5:47 pm
by lnevo
I affect the AntiSync channel. The Sync channel isn't touched.
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 5:49 pm
by lnevo
Code: Select all
ReefAngel.DCPump.ActinicChannel=Sync; // Now you're pump will be affected by the portal settings.
ReefAngel.DCPump.DaylightChannel=AntiSync; // Now you're pump will be affected by the portal settings.
Your Daylight channel is you AntiSync channel.
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 5:51 pm
by lnevo
It's all how you set it. You can flip it by making Actinic the Anti-Sync and the daylight the sync.
If you want to leave it as-is, you could change the wp-25 to a greater than 100 offset and set your speed according to the wp-40.
Let's say you set the speed to 40% and the offset to 150, then your wp-40 would be at 40% and you're wp-25 would be at 60%.
Does that make sense?
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 5:53 pm
by Sacohen
Ok. I see.
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 7:05 pm
by lnevo
Cool, so it's working! Roberto merged it into dev already. This next release is going to be awesome. So many new features.
Re: Different settings for 2 different DC Pumps.
Posted: Tue Sep 02, 2014 7:12 pm
by Sacohen
Any idea when the it will be released?
I'm waiting for the DNS option.
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 4:14 am
by lnevo
Go get it, start using it

not sure what roberto has cooking, but I think Alan and I are mostly done with our updates.

Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 5:43 am
by Sacohen
I was going to do that.
I know the DNS update is in there as well as the webserver authentication section and now the DC Pump Offset.
As well as a couple of knew DC Pump presets.
This should be a great update.
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 5:44 am
by lnevo
Also high resolution dimming, SunLocation, Moon, Tide, and TimedPorts (although that still needs some documentation, but it's usable..)
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 7:57 am
by rimai
Yeah, mostly waiting to see if people find any bugs, but we are due for a release already.
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 7:58 am
by Sacohen
The timed ports are your stop, pause, play that you created for your AWC?
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 8:29 am
by AlanM
The DCPump changes at this point are pretty big. I'm scared of the new stuff that Lee did because it pulls so much out of ReefAngel.cpp and he doesn't even have a DC Pump to try it on. 8)
I'll pull it down tonight and see if it will make mine go.
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 8:45 am
by lnevo
Steve tested the latest and its working. Plus Roberto pulled it already I believe.
Yes the TimedPort is what I created for the WaterChange. I'll write up some examples later.
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 8:59 am
by Sacohen
I tested the offset.
I didn't really test the other pump modes or the threshold.
Re: Different settings for 2 different DC Pumps.
Posted: Wed Sep 03, 2014 9:17 am
by lnevo
It most likely would not have worked at all if my code wasn't working as I basically centralized where we actually write the PWM value so that we just had to do that once.
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 04, 2014 4:18 pm
by AlanM
As far as I can tell the DCPump stuff is working fine on my reef angel with 2 and soon to be 4 (as soon as they clear customs) DC Pumps. I didn't make any changes to my INO file to get them to work either.
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 04, 2014 4:36 pm
by Sacohen
You shouldn't need to change anything for the pumps.
The only reason I did was because I had the Else Mode in my code and as part of my random waves.
That code had to be removed to use the code in the library.
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 04, 2014 4:43 pm
by AlanM
Right. There are thankfully very few things that need to be changed in current .ino files to run the new code, but moving Else mode out is one of them. Now you can just do a
in your INO, though, so that should be pretty simple for most folks.
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 04, 2014 4:59 pm
by Sacohen
Yeah. It should.
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 11, 2014 6:44 am
by oscarinw
So I have a question for you all (hopefully on this topic)
I downloaded libraries and used the wizard for my WP40 on the LowATO channel about 2 weeks ago. All I did was add 'LowATO=DCPump' (or something like that) to the code. I set it in Sine mode at 70%. 3 days later, the pump died on me.
Since I can only understand about half of what you all discuss here, did I do something wrong or it shouldn't have anything to do?
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 11, 2014 7:04 am
by lnevo
You're using the dev libraries? You may need to raise the threshold (the default is 30) You may want to try 35.
ReefAngel.DCPump.Threshold=35;
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 11, 2014 11:43 am
by oscarinw
What does the threshold do and what could have it done to the pump? Yes I downloaded the dev libararies...
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 11, 2014 11:46 am
by lnevo
If your speed goes too low on the dc jaebo pumps they cut off...the threshold sets the low end speed
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 11, 2014 11:57 am
by Sacohen
I have a WP-25 and a WP-40.
The cut off on my WP-40 is 25% and my WP-25 is 30%.
I can't say that is the limit for all of them thought.
Re: Different settings for 2 different DC Pumps.
Posted: Thu Sep 11, 2014 12:11 pm
by oscarinw
OK, so it wouldn't damage the pump even if set too low. Am I correct?