Page 1 of 1
Re: Issues I've seen in the current Dev Library.
Posted: Thu Sep 11, 2014 4:39 pm
by cosmith71
Is there a way to exclude the DCPumps from feeding mode? I.e., ignore ReefAngel.DCPump.FeedingSpeed when in feeding mode?
Thanks,
--Colin
Override Feeding Mode Speed...
Posted: Fri Sep 12, 2014 8:52 am
by cosmith71
lnevo wrote:cosmith71 wrote:Is there a way to exclude the DCPumps from feeding mode? I.e., ignore ReefAngel.DCPump.FeedingSpeed when in feeding mode?
Thanks,
--Colin
Put this in your loop:
ReefAngel.DCPump.FeedingSpeed=InternalMemory.DCPumpSpeed_read();
I dont know if i have the function name right but essentially you can set the feeding mode speed to what you've set in memory.
Maybe roberto has a better suggestion.
You could also do math on it, lets say you want it 50% of the usual, you can add /2
That sets it to the portal speed value.
What I'd really like is to override it with a pump mode.
--Colin
Re: Issues I've seen in the current Dev Library.
Posted: Fri Sep 12, 2014 8:55 am
by lnevo
The mode doesn't change, just the speed when you go into feeding mode.
If you want to change the mode during feeding mode, just put an if (DISPLAYED_MENU==FEEDING_MODE)...
I thought you were trying to eliminate the spin-down during feeding mode...
Re: Override Feeding Mode Speed...
Posted: Fri Sep 12, 2014 2:14 pm
by cosmith71
Let me play with it some more. I was thinking it went to a constant speed of whatever was set when I tried it. I'll report back.
--Colin
Re: Override Feeding Mode Speed...
Posted: Fri Sep 12, 2014 3:27 pm
by cosmith71
Verified. Feeding mode sets the pumps to a constant speed of whatever is set.
I tried the displayed menu==feeding mode thing, it was ignored too.
--Colin
Re: Override Feeding Mode Speed...
Posted: Fri Sep 12, 2014 4:44 pm
by lnevo
Ok i'll take a look closer at the libraries and see how we can ignore that.
Re: Override Feeding Mode Speed...
Posted: Fri Sep 12, 2014 5:59 pm
by lnevo
Ok, I see the issue. Regardless of setting and everything we were just setting the channels to the FeedingSpeed and WaterChangeSpeed.
I've added a check that will now only do this if the value is less than 100. So if you want to override just set it to 101 or 255, just like we do with the PWM overrides.
You can test the patch from this branch. If it works for you, open an issue and I'll put a pull request through.
https://github.com/lnevo/Libraries/tree/modespeedfix
Re: Override Feeding Mode Speed...
Posted: Sat Sep 13, 2014 2:59 am
by cosmith71
Thanks! I'll give it a try this weekend.
--Colin
Re: Override Feeding Mode Speed...
Posted: Sat Sep 13, 2014 11:51 am
by lnevo
Created the pull requests. It's simple enough and should be there...
Re: Override Feeding Mode Speed...
Posted: Sat Sep 13, 2014 5:28 pm
by cosmith71
Appears to be working as intended now. I set the feeding speed to 255 and the pumps kept on doing what they were doing during feeding mode. Just like I wanted.
--Colin
Re: Override Feeding Mode Speed...
Posted: Sat Sep 13, 2014 7:34 pm
by lnevo
Awesome