Reef Angel Forum

Posted: **Wed Nov 14, 2012 9:07 am**

I can try that. But will it do 10% to 30%. Then 30% to 10% and repeat throughout cloud duration?

Posted: **Wed Nov 14, 2012 10:00 am**

Try this:

      if (NumMins(hour(),minute())>=(cloudstart+180) && NumMins(hour(),minute())<(cloudstart+cloudduration-180))
      {
        boolean static passingcloud=false;
        boolean static passingcloudstart=now();
        if (!passingcloud && random(1000)<10)
        {
            passingcloud=true;
            passingcloudstart=now();
        }
        if (passingcloud)
        {
          if ((now()-passingcloudstart)<10)
            DaylightPWMValue+=(now()-passingcloudstart)*2;
          if ((now()-passingcloudstart)>10 && (now()-passingcloudstart)<20)
            DaylightPWMValue-=(now()-passingcloudstart-10)*2;
          if ((now()-passingcloudstart)>20)
            passingcloud=false;
        }

Place it right after the PWM override value assignment:

Code: Select all

      DaylightPWMValue=ReversePWMSlope(cloudstart,cloudstart+cloudduration,DaylightPWMValue,0,180);

It's a random chance of 1% for every pass of loop and not every second.... don't increase too much or you will end up getting passing clouds all the time.
I even think 1% is too much.
It lasts for 20 seconds... 10 to go up and 10 to go down... It increases the PWM by 2 every second.

Posted: **Wed Nov 14, 2012 11:02 am**

//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function
void CheckCloud()
{

// ------------------------------------------------------------
// Change the values below to customize your cloud/storm effect

// Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)
// For testing purposes, you can use 1 and cause the cloud to occur everyday
#define Clouds_Every_X_Days 1

// Percentage chance of a cloud happening today
// For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
#define Cloud_Chance_per_Day 100

// Minimum number of minutes for cloud duration. Don't use max duration of less than 6
#define Min_Cloud_Duration 7

// Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
#define Max_Cloud_Duration 15

// Minimum number of clouds that can happen per day
#define Min_Clouds_per_Day 3

// Maximum number of clouds that can happen per day
#define Max_Clouds_per_Day 5

// Only start the cloud effect after this setting
// In this example, start could after 11:30am
#define Start_Cloud_After NumMins(11,30)

// Always end the cloud effect before this setting
// In this example, end could before 8:00pm
#define End_Cloud_Before NumMins(18,30)

// Percentage chance of a lightning happen for every cloud
// For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening
#define Lightning_Change_per_Cloud 100

// Note: Make sure to choose correct values that will work within your PWMSLope settings.
// For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
// Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
// Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
// In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
// It's a tight fit, but it did.

//#define printdebug // Uncomment this for debug print on Serial Monitor window
#define forcecloudcalculation // Uncomment this to force the cloud calculation to happen in the boot process.

// Change the values above to customize your cloud/storm effect
// ------------------------------------------------------------
// Do not change anything below here

static byte cloudchance=255;
static byte cloudduration=0;
static int cloudstart=0;
static byte numclouds=0;
static byte lightningchance=0;
static byte cloudindex=0;
static byte lightningstatus=0;
static int LastNumMins=0;
// Every day at midnight, we check for chance of cloud happening today
if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
if (cloudchance==255)
#else
if (hour()==0 && minute()==0 && second()==1 && cloudchance==255)
#endif
{
//Pick a random number between 0 and 99
cloudchance=random(100);
// if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today
if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;
// Check if today is day for clouds.
if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0;
// If we have cloud today
if (cloudchance)
{
// pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day
numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
// pick the time that the first cloud will start
// the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day.
cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
// pick a random number for the cloud duration of first cloud.
cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
//Pick a random number between 0 and 99
lightningchance=random(100);
// if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
}
}
// Now that we have all the parameters for the cloud, let's create the effect

if (cloudchance)
{
//is it time for cloud yet?
if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
{
DaylightPWMValue=ReversePWMSlope(cloudstart,cloudstart+cloudduration,DaylightPWMValue,0,180);
if (NumMins(hour(),minute())>=(cloudstart+180) && NumMins(hour(),minute())<(cloudstart+cloudduration-180))
{
boolean static passingcloud=false;
boolean static passingcloudstart=now();
if (!passingcloud && random(1000)<10)
{
passingcloud=true;
passingcloudstart=now();
}
if (passingcloud)
{
if ((now()-passingcloudstart)<10)
DaylightPWMValue+=(now()-passingcloudstart)*2;
if ((now()-passingcloudstart)>10 && (now()-passingcloudstart)<20)
DaylightPWMValue-=(now()-passingcloudstart-10)*2;
if ((now()-passingcloudstart)>20)
passingcloud=false;
}
if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5)
{
if (random(100)<20) lightningstatus=1;
else lightningstatus=0;
if (lightningstatus)
{
DaylightPWMValue=100;
ActinicPWMValue=100;
}
else
{
DaylightPWMValue=0;
ActinicPWMValue=0;
}
delay(1);
}
}
if (NumMins(hour(),minute())>(cloudstart+cloudduration))
{
cloudindex++;
if (cloudindex < numclouds)
{
cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
// pick a random number for the cloud duration of first cloud.
cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
//Pick a random number between 0 and 99
lightningchance=random(100);
// if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
}
}
}

if (LastNumMins!=NumMins(hour(),minute()))
{
LastNumMins=NumMins(hour(),minute());
ReefAngel.LCD.Clear(255,0,120,132,132);
ReefAngel.LCD.DrawText(0,255,5,120,"C");
ReefAngel.LCD.DrawText(0,255,11,120,"00:00");
ReefAngel.LCD.DrawText(0,255,45,120,"L");
ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
if (cloudchance && (NumMins(hour(),minute())<cloudstart))
{
int x=0;
if ((cloudstart/60)>=10) x=11; else x=17;
ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart/60));
if ((cloudstart%60)>=10) x=29; else x=35;
ReefAngel.LCD.DrawText(0,255,x,120,(cloudstart%60));
}
ReefAngel.LCD.DrawText(0,255,90,120,cloudduration);
if (lightningchance)
{
int x=0;
if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;
ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))/60));
if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;
ReefAngel.LCD.DrawText(0,255,x,120,((cloudstart+(cloudduration/2))%60));
}
}
}

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
long n=elapsedSecsToday(now());
cstart*=60;
cend*=60;
if (n<cstart) return PWMStart;
if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
if (n>cend) return PWMStart;
}

Like this???

Posted: **Wed Nov 14, 2012 11:11 am**

Yeah, let me know if it works

Posted: **Wed Nov 14, 2012 11:24 am**

uploading now

Posted: **Wed Nov 14, 2012 11:38 am**

Can't get it to force a cloud...weird.
#define Clouds_Every_X_Days 1

// Percentage chance of a cloud happening today
// For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
#define Cloud_Chance_per_Day 100

// Minimum number of minutes for cloud duration. Don't use max duration of less than 6
#define Min_Cloud_Duration 7

// Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
#define Max_Cloud_Duration 15

// Minimum number of clouds that can happen per day
#define Min_Clouds_per_Day 2

// Maximum number of clouds that can happen per day
#define Max_Clouds_per_Day 4

// Only start the cloud effect after this setting
// In this example, start could after 10:30am
#define Start_Cloud_After NumMins(10,30)

// Always end the cloud effect before this setting
// In this example, end could before 5:30pm
#define End_Cloud_Before NumMins(17,30)

should be going..yes?

Posted: **Wed Nov 14, 2012 11:38 am**

#define forcecloudcalculation is also uncommented

Posted: **Wed Nov 14, 2012 11:55 am**

I think you need this:
http://forum.reefangel.com/viewtopic.php?f=12&t=425

Posted: **Wed Nov 14, 2012 11:58 am**

bummer...no room for a custom menu. I'll just watch for the next cloud and see what happens.

Posted: **Mon Nov 19, 2012 10:20 am**

A cloud just happened...

It works but it doesn't repeat throughout the cloud duration..it only happened once?? but it worked..sort of

Posted: **Mon Nov 19, 2012 1:12 pm**

thoughts?

Posted: **Mon Nov 19, 2012 1:46 pm**

I'll get back to you after 12/03 when we open again.

Posted: **Mon Nov 19, 2012 1:57 pm**

Can you post your entire code?
I think the post I made with the code was missing one closing bracket.

Posted: **Mon Nov 19, 2012 2:22 pm**

I fixed that closing bracket originally. I'll post it

Posted: **Mon Nov 19, 2012 2:28 pm**

Code: Select all

// Autogenerated file by RAGen (v1.2.2.171), (06/09/2012 20:37)
// RA_060912_2037.ino
//
// This version designed for v0.9.0 or later

//The following features are enabled for this File: 
#define VersionMenu
#define DisplayLEDPWM
#define wifi
#define WDT
#define SIMPLE_MENU




#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <ReefAngel.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>


byte ActinicPWMValue=0;
byte DaylightPWMValue=0;

////// Place global variable code below here
void DrawCustomMain()
{
  byte x = 6;
  byte y = 2;
  byte t;
  char text[7];
  

  ReefAngel.LCD.DrawDate(6, 2);
  ReefAngel.LCD.Clear(COLOR_BLACK, 1, 11, 132, 11);
  pingSerial();
  
  ReefAngel.LCD.DrawText(0,255,3,17,"Drew Palmer's 75 Reef");
  
 

  pingSerial();

  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 6, 90, "--------------------");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 6, 126, "--------------------");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 93, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 103, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 113, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 2, 123, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 93, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 103, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 113, "|");
  ReefAngel.LCD.DrawText(COLOR_BLACK,255, 126, 123, "|");
  
  

  ReefAngel.LCD.DrawText(0,255,10,30,"Display");
  ConvertNumToString(text, ReefAngel.Params.Temp[T3_PROBE], 10);
  ReefAngel.LCD.DrawText(COLOR_BLACK, 255, 10, 40, text);
  
  ReefAngel.LCD.DrawText(0,255,8,68,"Room");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T2_PROBE], COLOR_BLACK, 40, 68, 10);

  ReefAngel.LCD.DrawText(0,255,70,68,"Light");
  ReefAngel.LCD.DrawSingleMonitor(ReefAngel.Params.Temp[T1_PROBE], COLOR_BLACK, 99, 68, 10);
  pingSerial();

  ReefAngel.LCD.DrawText(0,255,100,30,"pH");
  ConvertNumToString(text, ReefAngel.Params.PH, 100);
  ReefAngel.LCD.DrawText(COLOR_BLACK, 255, 95, 40, text);
  
  pingSerial();

  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox(12, 77, TempRelay);

  pingSerial();
  
  ReefAngel.LCD.DrawText(0,255,8,100, "CWLED");  
  ReefAngel.LCD.DrawText(COLOR_BLACK,255,15,119, ReefAngel.PWM.GetDaylightValue());
  
  ReefAngel.LCD.DrawText(0,255,88,100, "RBLED");  
  ReefAngel.LCD.DrawText(COLOR_BLACK,255,95,119, ReefAngel.PWM.GetActinicValue());
  
  ReefAngel.LCD.DrawText(0,255,48,100, "Cloud");
  ReefAngel.LCD.DrawText(0,255,41,108, "Duration"); 
  
  
  pingSerial();
 

}
void DrawCustomGraph()
{
}

byte wc_status=0;

// 0 - Draining
// 1 - Filling up
// 2 - Finish
////// Place global variable code above here


void setup()
{
    // This must be the first line
    ReefAngel.Init();  //Initialize controller
     ReefAngel.FeedingModePorts = 0;
    // Ports toggled in Water Change Mode
    ReefAngel.WaterChangePorts = Port4Bit | Port6Bit | Port8Bit | Port5Bit;
    // Ports toggled when Lights On / Off menu entry selected
    ReefAngel.LightsOnPorts = 0;
    // Ports turned off when Overheat temperature exceeded
    ReefAngel.OverheatShutoffPorts = Port5Bit | Port6Bit | Port7Bit;
    // Use T1 probe as temperature and overheat functions
    ReefAngel.TempProbe = T1_PROBE;
    ReefAngel.OverheatProbe = T3_PROBE;
    // Set the Overheat temperature setting
    InternalMemory.OverheatTemp_write( 860 );
    
    ReefAngel.PHMin=830; // 830=PH10.0
    ReefAngel.PHMin=480; // 480=PH7.0
    

    
    
       

    // Ports that are always on
    
    
    ReefAngel.Relay.On(Port6);
    ReefAngel.Relay.On(Port5); //Heater
    
    
    
    
    ////// Place additional initialization code below here
    


    
    
    //ReefAngel.AddWifi();

    ////// Place additional initialization code above here
}

void loop()
{
   
 //water change ATO
 if (ReefAngel.DisplayedMenu==WATERCHANGE_MODE)
  {
    byte TempRelay = ReefAngel.Relay.RelayData;
    TempRelay &= ReefAngel.Relay.RelayMaskOff;
    TempRelay |= ReefAngel.Relay.RelayMaskOn;
    ReefAngel.LCD.DrawOutletBox(10, 100, TempRelay);

    switch (wc_status)
    {
    case 0:
      ReefAngel.Relay.On(1);
      if (ReefAngel.LowATO.IsActive()) wc_status++;
      break;
    case 1:
      ReefAngel.Relay.Off(1);
      ReefAngel.Relay.On(3);
      if (!ReefAngel.HighATO.IsActive()) wc_status++;
      break;
    case 2:
      ReefAngel.Relay.Off(1);
      ReefAngel.Relay.Off(3);
      wc_status=0;
      ButtonPress++;
    }
  }
  //end water change
 
  // Specific functions that use Internal Memory values
    // Calculate your regular sunrise/sunset PWM value
  ActinicPWMValue=PWMParabola(6,5,21,0,0,85,0);//85%
  DaylightPWMValue=PWMParabola(7,5,19,0,0,80,0);//80%
  CheckCloud();
  ReefAngel.PWM.SetActinic(ActinicPWMValue);
  ReefAngel.PWM.SetDaylight(DaylightPWMValue);
  
    //ReefAngel.StandardHeater( Port4,740,770 );
    
    //Loop Lights & Fan
  ReefAngel.StandardLights(Port7,6,30,20,30);//On LED light FAN
  ReefAngel.StandardLights(Port2,19,15,6,30);//Fug Light
    
   
   
  

    
    
    ////// Place your custom code below here
   ReefAngel.Relay.DelayedOn( Port4,5);
   ReefAngel.Relay.DelayedOn( Port8,5);
   

    ////// Place your custom code above here
  


    // This should always be the last line
    ReefAngel.ShowInterface();
}
//*********************************************************************************************************************************
// Random Cloud/Thunderstorm effects function
void CheckCloud()
{

  // ------------------------------------------------------------
  // Change the values below to customize your cloud/storm effect

  // Frequency in days based on the day of the month - number 2 means every 2 days, for example (day 2,4,6 etc)
  // For testing purposes, you can use 1 and cause the cloud to occur everyday
#define Clouds_Every_X_Days 1 

  // Percentage chance of a cloud happening today
  // For testing purposes, you can use 100 and cause the cloud to have 100% chance of happening
#define Cloud_Chance_per_Day 100

  // Minimum number of minutes for cloud duration.  Don't use max duration of less than 6
#define Min_Cloud_Duration 7

  // Maximum number of minutes for the cloud duration. Don't use max duration of more than 255
#define Max_Cloud_Duration 15

  // Minimum number of clouds that can happen per day
#define Min_Clouds_per_Day 2

  // Maximum number of clouds that can happen per day
#define Max_Clouds_per_Day 4

  // Only start the cloud effect after this setting
  // In this example, start could after 10:30am
#define Start_Cloud_After NumMins(10,30)

  // Always end the cloud effect before this setting
  // In this example, end could before 5:30pm
#define End_Cloud_Before NumMins(17,30)

  // Percentage chance of a lightning happen for every cloud
  // For testing purposes, you can use 100 and cause the lightning to have 100% chance of happening
#define Lightning_Change_per_Cloud 0

  // Note: Make sure to choose correct values that will work within your PWMSLope settings.
  // For example, in our case, we could have a max of 5 clouds per day and they could last for 50 minutes.
  // Which could mean 250 minutes of clouds. We need to make sure the PWMSlope can accomodate 250 minutes of effects or unforseen resul could happen.
    // Also, make sure that you can fit double those minutes between Start_Cloud_After and End_Cloud_Before.
  // In our example, we have 510 minutes between Start_Cloud_After and End_Cloud_Before, so double the 250 minutes (or 500 minutes) can fit in that 510 minutes window.
    // It's a tight fit, but it did.

    //#define printdebug // Uncomment this for debug print on Serial Monitor window
  #define forcecloudcalculation // Uncomment this to force the cloud calculation to happen in the boot process. 


  // Change the values above to customize your cloud/storm effect
  // ------------------------------------------------------------
  // Do not change anything below here

  static byte cloudchance=255;
  static byte cloudduration=0;
  static int cloudstart=0;
  static byte numclouds=0;
  static byte lightningchance=0;
  static byte cloudindex=0;
  static byte lightningstatus=0;
  static int LastNumMins=0;
  // Every day at midnight, we check for chance of cloud happening today
  if (hour()==0 && minute()==0 && second()==0) cloudchance=255;

#ifdef forcecloudcalculation
    if (cloudchance==255)
#else
    if (hour()==0 && minute()==0 && second()==1 && cloudchance==255) 
#endif
    {
      //Pick a random number between 0 and 99
      cloudchance=random(100); 
      // if picked number is greater than Cloud_Chance_per_Day, we will not have clouds today
      if (cloudchance>Cloud_Chance_per_Day) cloudchance=0;
      // Check if today is day for clouds. 
      if ((day()%Clouds_Every_X_Days)!=0) cloudchance=0; 
      // If we have cloud today
      if (cloudchance)
      {
        // pick a random number for number of clouds between Min_Clouds_per_Day and Max_Clouds_per_Day
        numclouds=random(Min_Clouds_per_Day,Max_Clouds_per_Day);
        // pick the time that the first cloud will start
        // the range is calculated between Start_Cloud_After and the even distribuition of clouds on this day. 
        cloudstart=random(Start_Cloud_After,Start_Cloud_After+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  // Now that we have all the parameters for the cloud, let's create the effect

  if (cloudchance)
  {
    //is it time for cloud yet?
    if (NumMins(hour(),minute())>=cloudstart && NumMins(hour(),minute())<(cloudstart+cloudduration))
    {
      DaylightPWMValue=ReversePWMSlope(cloudstart,cloudstart+cloudduration,DaylightPWMValue,10,180);
            if (NumMins(hour(),minute())>=(cloudstart+180) && NumMins(hour(),minute())<(cloudstart+cloudduration-180))
      {
        boolean static passingcloud=false;
        boolean static passingcloudstart=now();
        if (!passingcloud && random(1000)<10)
        {
            passingcloud=true;
            passingcloudstart=now();
        }
        if (passingcloud)
        {
          if ((now()-passingcloudstart)<10)
            DaylightPWMValue+=(now()-passingcloudstart)*2;
          if ((now()-passingcloudstart)>10 && (now()-passingcloudstart)<20)
            DaylightPWMValue-=(now()-passingcloudstart-10)*2;
          if ((now()-passingcloudstart)>20)
            passingcloud=false;
        }

      if (lightningchance && (NumMins(hour(),minute())==(cloudstart+(cloudduration/2))) && second()<5) 
      {
        if (random(100)<20) lightningstatus=1; 
        else lightningstatus=0;
        if (lightningstatus)
        {
          DaylightPWMValue=100; 
          ActinicPWMValue=100;
        }
        else 
        {
          DaylightPWMValue=0;
          ActinicPWMValue=0;
        }
        delay(1);
      }
    }
    if (NumMins(hour(),minute())>(cloudstart+cloudduration))
    {
      cloudindex++;
      if (cloudindex < numclouds)
      {
        cloudstart=random(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2),(Start_Cloud_After+(((End_Cloud_Before-Start_Cloud_After)/(numclouds*2))*cloudindex*2))+((End_Cloud_Before-Start_Cloud_After)/(numclouds*2)));
        // pick a random number for the cloud duration of first cloud.
        cloudduration=random(Min_Cloud_Duration,Max_Cloud_Duration);
        //Pick a random number between 0 and 99
        lightningchance=random(100);
        // if picked number is greater than Lightning_Change_per_Cloud, we will not have lightning today
        if (lightningchance>Lightning_Change_per_Cloud) lightningchance=0;
      }
    }
  }
  }
  if (LastNumMins!=NumMins(hour(),minute()))
  {
    LastNumMins=NumMins(hour(),minute());
    ReefAngel.LCD.Clear(255,0,120,132,132);
    ReefAngel.LCD.DrawText(0,255,48,47,"Cloud");
    ReefAngel.LCD.DrawText(0,255,48,57,"00:00");
    //ReefAngel.LCD.DrawText(0,255,45,120,"L");
    //ReefAngel.LCD.DrawText(0,255,51,120,"00:00");
    if (cloudchance && (NumMins(hour(),minute())<cloudstart))
    {
      int x=0;
      if ((cloudstart/60)>=10) x=48; else x=54;
      ReefAngel.LCD.DrawText(0,255,x,57,(cloudstart/60));
      if ((cloudstart%60)>=10) x=66; else x=72;
      ReefAngel.LCD.DrawText(0,255,x,57,(cloudstart%60));
    }
    ReefAngel.LCD.DrawText(0,255,56,119,cloudduration);
    if (lightningchance) 
    {
      int x=0;
      if (((cloudstart+(cloudduration/2))/60)>=10) x=51; else x=57;
      ReefAngel.LCD.DrawText(0,255,x,115,((cloudstart+(cloudduration/2))/60));
      if (((cloudstart+(cloudduration/2))%60)>=10) x=69; else x=75;
      ReefAngel.LCD.DrawText(0,255,x,115,((cloudstart+(cloudduration/2))%60));
    }
  }   
}

byte ReversePWMSlope(long cstart,long cend,byte PWMStart,byte PWMEnd, byte clength)
{
  long n=elapsedSecsToday(now());
  cstart*=60;
  cend*=60;
  if (n<cstart) return PWMStart;
  if (n>=cstart && n<=(cstart+clength)) return map(n,cstart,cstart+clength,PWMStart,PWMEnd);
  if (n>(cstart+clength) && n<(cend-clength)) return PWMEnd;
  if (n>=(cend-clength) && n<=cend) return map(n,cend-clength,cend,PWMEnd,PWMStart);
  if (n>cend) return PWMStart;
}

Posted: **Mon Nov 19, 2012 2:46 pm**

Try replacing this:

Code: Select all

boolean static passingcloudstart=now();

To this:

Code: Select all

unsigned long static passingcloudstart=now();

Posted: **Mon Nov 19, 2012 3:02 pm**

Thanks. Will see and post back

Posted: **Thu Nov 22, 2012 10:15 am**

Cloud happened.

After replacing what you said to do. It reverted back to just going to 0 and sitting there. For the duration of the cloud. It just went back to the original code cycle.

Posted: **Thu Nov 22, 2012 10:37 am**

So, is it still doing the same thing?

Posted: **Thu Nov 22, 2012 12:20 pm**

Yep. Same thing. Maybe it's not using the correct code you made and is just using the standard code from before? I'm also only getting one cloud a day now. Even though I have it set to up to 5 every other day. We might need to restart from the beginning?

Posted: **Thu Nov 22, 2012 12:37 pm**

There is also a % chance of cloud per day. What do you have it set to?

Code: Select all

#define Cloud_Chance_per_Day 50

Posted: **Thu Nov 22, 2012 12:47 pm**

60%
The weird thing is that only one cloud happens per day and it's always at 1100 for a changing duration

Posted: **Thu Nov 22, 2012 12:50 pm**

This was all functioning as intended until I wanted "passing" clouds where the PWM will ramp and down in the duration. So something is up with what we changed to make passing clouds

Posted: **Thu Nov 22, 2012 3:25 pm**

Thoughts?

Posted: **Thu Nov 22, 2012 3:26 pm**

I'll have to revisit this when I get back.
No way of troubleshooting at the moment.

Posted: **Thu Nov 22, 2012 3:28 pm**

Thanks!

Posted: **Thu Nov 29, 2012 6:24 pm**

Back?

Posted: **Fri Nov 30, 2012 4:04 am**

Next week

Posted: **Sat Dec 08, 2012 1:43 pm**

You're back!

haha. Still cloud at 11am daily? Only one all day even though I've changed variables to try and get it working like it used to. Passing clouds still not working either

Posted: **Sat Dec 08, 2012 5:02 pm**

Yeah, back

Let me see if I troubleshoot.

Reef Angel Forum

Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display

Re: Clouds and display