Reef Angel Forum

daniella3d wrote:HI everyone, I just installed the jebao cable and uploaded the code but the short pulse mode does not work, wondering why?

I can hear the pump go into cycle but it seem to be going at 100% but never really stop, just slow down. What am I doing wrong? With the jebao controller the W1 mode, short pulse, the pump goes to 100%, then completele stop, then 100% then stop. You can actually see the propeller stops. With the RA it never really stop??

the code I am using:

ReefAngel.PWM.SetDaylight( ShortPulseMode(0,100,500,true) ); // Short pulse at 60% with 200ms pulse on sync mode

lnevo wrote:A lot of the timings are going to be unique for each tank dimension and what speed the pumps are run at.

Your function is pretty good though, we should make it a submitted function...

How about BioHazardMode()

daniella3d wrote:I only have one pump though. Problem is that the short pulse mode does not go to 0, so there really is no wave or bearely any, no matter what value I use.

Also the custom code is not random enough, at least no like the Else mode. I listen to the pump with the Jebao controller in Else mode and it's really random. It does these speeds at about 1 second duration:

10, 15, 20, 60, 100, 30, 100, 20, 15, 10, 5, 80, 60.

It goes up slowly, then down quickly, then up, then down slowly, then anything pretty much random. with the custom RA code all it does is going to 0, then something random around 40%, then it goes to the maximum speed, then again, 0, like this:

0, 37, 80, 0, 40, 80, 0, 23, 80, 0, 26, 80, 0, 37, 80. So the only randomness is in the middle value. Is it possible to have something that does what the else mode do?

bhazard wrote:

daniella3d wrote:For just one pump, use one line, like this:

ReefAngel.PWM.SetDaylight(millis()%1200>800?80:0);

The 80 value is the intensity on. You can change it up to 100. The 0 stops the pump, just like W1.

As far as the randomness of ELSE mode, I'm sure we'll all eventually figure it out to get it close. There was no W1 like code as of a few weeks ago, and with a group effort, now there is. The support from the guys here at Reef Angel, along with the potential of the RA itself is just awesome.

daniella3d wrote:Ok tanks!

Looking forward to that else mode. I wish I could contribute something but I am just learning what the code is doing, nevermind trying to compose something, I know zero in programmation.

The else mode seem pretty random and with very short pulse at least on the wp25 controller. The pulse seem to be even less than a second each. I am sure someone will figure it out, it's just a matter of time.

bhazard wrote:

daniella3d wrote:For just one pump, use one line, like this:

ReefAngel.PWM.SetDaylight(millis()%1200>800?80:0);

The 80 value is the intensity on. You can change it up to 100. The 0 stops the pump, just like W1.

As far as the randomness of ELSE mode, I'm sure we'll all eventually figure it out to get it close. There was no W1 like code as of a few weeks ago, and with a group effort, now there is. The support from the guys here at Reef Angel, along with the potential of the RA itself is just awesome.

I have absolutely no idea how to code either, but I am starting to understand where/what to modify in code that I can copy/paste. If people weren't as helpful as they are, most of us would be lost. You'll start picking up on things more and more.

daniella3d wrote:Ok tanks!

Looking forward to that else mode. I wish I could contribute something but I am just learning what the code is doing, nevermind trying to compose something, I know zero in programmation.

The else mode seem pretty random and with very short pulse at least on the wp25 controller. The pulse seem to be even less than a second each. I am sure someone will figure it out, it's just a matter of time.

lnevo wrote:Roberto needs to add custom to the drop down like he did for RF... And you'd just do...

if (ReefAngel.DCPump.Mode==Custom) {
ReefAngel.DCPump.UseMemory=False;
ReefAngel.PWM.SetDaylight(.....);
}

You could retrieve the Duration and Speed from the DCPump class to use in your SetDaylight or custom function by using ReefAngel.DCPump.Speed and ReefAngel,DCPump.Duration

lnevo wrote:Your sprintf is wrong and I dont think you need to set the usememory to false or at least you should add an else and set usememory=true;.

It will only do whats in your if statement when the mode is custom. So anything else will revert to that mode. As long as usememory = true;

if (ReefAngel.DCPump.Mode==Custom) sprintf(buf,"RC %d% +/-%d%",wpWavStr,wpWavOff);
else sprintf(buf,ReefAngel.DCPump.Mode);

////  Port 1			Heater
////  Port 2			ATO pump
////  Port 3			Reactor Pump
////  Port 4			Protien Skimmer
////  Port 5			Return Pump
////  Port 6			Wavemaker
////  Port 7                    UV Sterilizer
////  Port 8                    Fuge Light
////  Always on - Lights & Salinity Module


#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <PH.h>
#include <WaterLevel.h>
#include <DCPump.h>
#include <ReefAngel.h>

////// Place global variable code below here

#define Heater Port1
#define Topoff Port2
#define Reactor Port3
#define Skimmer Port4
#define Return Port5
#define Wave Port6
#define UVlight Port7
#define Fugelight Port8

#define FugelightBit   1<<7
#define UVlightBit   1<<6
#define WaveBit   1<<5
#define ReturnBit   1<<4
#define SkimmerBit   1<<3
#define ReactorBit   1<<2
#define TopoffBit   1<<1
#define HeaterBit   1<<0

static byte wpMode;
static byte wpWavStr;
static byte wpWavOff;

////// Place global variable code above here

void setup()
{
  // This must be the first line
  ReefAngel.Init();  //Initialize controller
  // Ports toggled in Feeding Mode
  ReefAngel.FeedingModePorts = TopoffBit | ReactorBit | SkimmerBit | ReturnBit | UVlightBit;
  // Ports toggled in Water Change Mode
  ReefAngel.WaterChangePorts = HeaterBit | TopoffBit | ReactorBit | SkimmerBit | ReturnBit | WaveBit | UVlightBit;
  // Ports toggled when Lights On / Off menu entry selected
  ReefAngel.LightsOnPorts = FugelightBit;
  // Ports turned off when Overheat temperature exceeded
  ReefAngel.OverheatShutoffPorts = HeaterBit | TopoffBit | ReactorBit | SkimmerBit | ReturnBit | WaveBit | UVlightBit;

  // Use T1 (SUMP) probe as temperature and overheat functions
  ReefAngel.TempProbe = T1_PROBE;
  ReefAngel.OverheatProbe = T1_PROBE;

  // Ports that are always on
  ReefAngel.Relay.On( Return );
  ReefAngel.Relay.On( Reactor );
  ReefAngel.Relay.On( Wave );

  ////// Place additional initialization code below here


    ////// Place additional initialization code above here
}

void loop()
{
  ReefAngel.StandardHeater( Heater );
  ReefAngel.StandardATO( Topoff );
  ReefAngel.MoonLights( Fugelight );

  ////// Place your custom code below here

  ReefAngel.LCD.DrawText(0,255,20,80,"Joe's Reef Tank");

  ReefAngel.Relay.DelayedOn(Skimmer,2);
  ReefAngel.Relay.DelayedOn(UVlight,1);

  ReefAngel.DCPump.FeedingSpeed=30;
  ReefAngel.DCPump.WaterChangeSpeed=0;
  ReefAngel.DCPump.UseMemory = true;
  ReefAngel.DCPump.DaylightChannel = AntiSync;
  ReefAngel.DCPump.ActinicChannel = AntiSync;
  ReefAngel.PWM.SetActinic(100);
     
  // Set Wave Str
  if (wpMode=1) wpWavStr=45;
  if (wpMode=2) wpWavStr=50;
  if (wpMode=3) wpWavStr=55;
  
  //Set the Wave OffSet
  wpWavOff=15;       

  // set the wpMode
  if ( (hour() >= 5) && (hour() < 8) ) wpMode=1;       // from 5am - 8am
  if ( (hour() >= 8) && (hour() < 11) ) wpMode=2;      // from 8am - 11am
  if ( (hour() >= 11) && (hour() < 14) ) wpMode=3;     // from 11a - 2pm
  if ( (hour() >= 14) && (hour() < 17) ) wpMode=2;     // from 2pm - 5pm
  if ( (hour() >= 17) && (hour() < 20) ) wpMode=1;     // from 5pm - 8pm
  if ( (hour() >= 20) && (hour() < 23) ) wpMode=2;     // from 8pm - 11p
  if ( (hour() >= 23) && (hour() < 2) ) wpMode=3;      // from 11pm - 2am
  if ( (hour() >= 2) && (hour() < 5) ) wpMode=2;       // from 2am - 5am

// if the portal is set to a custom wave speed 
  if (ReefAngel.DCPump.Mode==Custom)    {
    ReefAngel.DCPump.UseMemory=false;
    ReefAngel.PWM.SetDaylight( ReefCrestMode(wpWavStr,wpWavOff,false) ); 
  }

  //  Only turn on UV Sterilizer between 11pm and 5am
  if ( (hour() >= 5) && (hour() < 23) )  // from 5a - 11p
  ReefAngel.Relay.Off(UVlight);
  else ReefAngel.Relay.On(UVlight);
 
  ////// Place your custom code above here

  // This should always be the last line
  ReefAngel.Portal( "Smotz" );
  ReefAngel.ShowInterface();
}

void DrawCustomMain()
{
  int x,y;
  char text[10];
  char buf[16];

if (ReefAngel.DCPump.Mode==Custom) sprintf(buf,"RC %d% +/-%d%",wpWavStr,wpWavOff);
else sprintf(buf,ReefAngel.DCPump.Mode);

  x = 15;
  y = 52;
  //ReefAngel.LCD.DrawText(0,255,x,y,"RF:"); 
  //ReefAngel.LCD.Clear(DefaultBGColor,x,y,128-x,y+8);
  ReefAngel.LCD.DrawText(0,255,x,y,buf);

  // Parameters
#if defined DisplayLEDPWM && ! defined RemoveAllLights
  ReefAngel.LCD.DrawMonitor( 15, 20, ReefAngel.Params,
  ReefAngel.PWM.GetDaylightValue(), ReefAngel.PWM.GetActinicValue() );
#else // defined DisplayLEDPWM && ! defined RemoveAllLights
  ReefAngel.LCD.DrawMonitor( 15, 20, ReefAngel.Params );
#endif // defined DisplayLEDPWM && ! defined RemoveAllLights
  pingSerial();

  // Salinity
  ReefAngel.LCD.DrawText( COLOR_DARKKHAKI,DefaultBGColor,15,66, "SAL:" );
  ReefAngel.LCD.DrawText( COLOR_DARKKHAKI,DefaultBGColor,39,66, ReefAngel.Params.Salinity );
  pingSerial();

  // Main Relay Box
  byte TempRelay = ReefAngel.Relay.RelayData;
  TempRelay &= ReefAngel.Relay.RelayMaskOff;
  TempRelay |= ReefAngel.Relay.RelayMaskOn;
  ReefAngel.LCD.DrawOutletBox( 12, 93, TempRelay );
  pingSerial();

  // Date and Time
  ReefAngel.LCD.DrawDate( 6, 122 );
  pingSerial();
}

void DrawCustomGraph()
{
}

lnevo wrote:sprintf (buf,"%d", ReefAngel.DCPump.Mode);

I don't see how your wpMode time settings are going to work. The DCPump is set to UseMemory and it will get the mode from the memory location. You'll need to use ReefAngel.DCPump.SetMode manually and disable UseMemory or its going to stay in the memory set mode.

lnevo wrote:Yes. Exactly. The channels are defined here:

ReefAngel.DCPump.DaylightChannel = AntiSync;
ReefAngel.DCPump.ActinicChannel = AntiSync;

By, the way, is this what you want to do though? I think this will be ignored later on because the ReefAngel class will overwrite the speed for that port..

ReefAngel.PWM.SetActinic(100);

lnevo wrote:If you set it to None it won't be considered a DCPump and you can set it to whatever you need.

If you set it to Sync or AntiSync then it will get driven by the DCPump code...

The default is None so you can just remove the line. Also if you only have one Pump then i would set it to Sync not Anti.

oscarinw wrote:

daniella3d wrote:
Hey you may want to take a look at what I did... i used the ReefCrestMode and made its time intervals random between 5 and 15 seconds and then at random power between the set values on a parabola for stronger during the day and slower at night...

http://forum.reefangel.com/viewtopic.php?p=28423#p28423

I like it so far...

BTW, not really me but 'lnevo' did all the logic behind it. I also don't know any programming...