ATO signal on Portal

Seagals · Post by **Seagals** » Fri Aug 02, 2013 10:51 am

Are the ATO high and low signals in the web portal supposed to change colors? Another words my ato low actually acts as a low water cutoff fr my main pump. currently I am not using a high water switch.

So if my ATO low is not activated shouldn't the light in the portal be a green light??

Thanks in advance

lnevo · Post by **lnevo** » Fri Aug 02, 2013 11:19 am

If it's not activated that means the switch is open which means the light is off / red.

If you want the light to always be green, you could use

ReverseATOLow();

That would also affect the behavior of the IsActive() function though so you'll have to add a ! or remove the ! in your current logic.

rimai · Post by **rimai** » Fri Aug 02, 2013 11:22 am

Portal only update every 5 minutes. So, you float switch needs to be triggered for 5 minutes to show up in the portal.

lnevo · Post by **lnevo** » Fri Aug 02, 2013 11:23 am

rimai wrote:Portal only update every 5 minutes. So, you float switch needs to be triggered for 5 minutes to show up in the portal.

Seagals wrote:So if my ATO low is not activated shouldn't the light in the portal be a green light??

Think he's asking about the default status of the switch...

Seagals · Post by **Seagals** » Fri Aug 02, 2013 12:36 pm

[quote="lnevo"]If it's not activated that means the switch is open which means the light is off / red.

Ok thanks so I understand it - on a low water cut off the float is always up (at least supoosed to be). and the light in the portal will indicate as 'red'.

Is my float goes down and triggers low water shuts off the main pump than what color light will be indicated on the portal?

Sacohen · Post by **Sacohen** » Fri Aug 02, 2013 1:11 pm

Greem. The colors of the ATO (by Default) are Red for off or not active and Green for on or active.

Seagals · Post by **Seagals** » Fri Aug 02, 2013 4:13 pm

lnevo wrote:If it's not activated that means the switch is open which means the light is off / red.

If you want the light to always be green, you could use

ReverseATOLow();

That would also affect the behavior of the IsActive() function though so you'll have to add a ! or remove the ! in your current logic.

So the following is my current ATO code for the low water cut off:

////// Place your custom code below here
static unsigned long lastATOCheck=millis();
if (!ReefAngel.LowATO.IsActive()) lastATOCheck=millis();
if (ReefAngel.LowATO.IsActive() && (millis()-lastATOCheck>2000)) ReefAngel.Relay.RelayMaskOff&=~(Port8Bit | Port7Bit | Port1Bit);
if ( (hour()>=8 && hour()<20))//wavemakers on at 8am and off at 8pm
{
static unsigned long nexttoggle=now();
static boolean state=false;
int cycle=nexttoggle-now();
ReefAngel.Relay.Set(Port5,state);
ReefAngel.Relay.Set(Port6,!ReefAngel.Relay.Status(Port5));
if (cycle<0)
{
nexttoggle+=random(960,1020);//tunzes on for 15-16 mins
state=!state;
}
if (cycle<10)//10 sec overlap
{
ReefAngel.Relay.On(Port5);
ReefAngel.Relay.On(Port6);
}
}
else
{
ReefAngel.Relay.Off(Port5);
ReefAngel.Relay.Off(Port6);
}

////// Place your custom code above here

Please let me know if the following changes would give me the green light when low water cut off has enough ater in the sump.:

////// Place your custom code below here
static unsigned long lastATOCheck=millis();
if (ReefAngel.ReverseLowATO.IsActive()) lastATOCheck=millis();
if (ReefAngel.ReverseLowATO.IsActive() && (millis()-lastATOCheck>2000)) ReefAngel.Relay.RelayMaskOff&=~(Port8Bit | Port7Bit | Port1Bit);
if ( (hour()>=8 && hour()<20))//wavemakers on at 8am and off at 8pm
{
static unsigned long nexttoggle=now();
static boolean state=false;
int cycle=nexttoggle-now();
ReefAngel.Relay.Set(Port5,state);
ReefAngel.Relay.Set(Port6,!ReefAngel.Relay.Status(Port5));
if (cycle<0)
{
nexttoggle+=random(960,1020);//tunzes on for 15-16 mins
state=!state;
}
if (cycle<10)//10 sec overlap
{
ReefAngel.Relay.On(Port5);
ReefAngel.Relay.On(Port6);
}
}
else
{
ReefAngel.Relay.Off(Port5);
ReefAngel.Relay.Off(Port6);
}

////// Place your custom code above here

Thanks in Advance

lnevo · Post by **lnevo** » Sat Aug 03, 2013 5:49 am

No. the ReverseATOLow() is just used once. It triggers the code to reverse the behavior. You dont use it in every call.

You still use the isActive the way you did before not like you have now...just reverse the logic with the ! If you had it remove it, if not add it.

Seagals · Post by **Seagals** » Sat Aug 03, 2013 7:08 am

Unfortunately I am getting a error message when I try to verify. The error code states the following:

'class ReefangelClass' has no member named 'ReverseATOLow()'

I tried it a few different ways but NG. This was the last code I tired I removed the ! before the Reef Angel in the following and added the Reverse: 'if (ReefAngel.ReverseLowATO.IsActive()) lastATOCheck=millis();'

Below is the code:

static unsigned long lastATOCheck=millis();
if (ReefAngel.ReverseLowATO.IsActive()) lastATOCheck=millis();
if (ReefAngel.LowATO.IsActive() && (millis()-lastATOCheck>2000)) ReefAngel.Relay.RelayMaskOff&=~(Port8Bit | Port7Bit | Port1Bit);
if ( (hour()>=8 && hour()<20))//wavemakers on at 8am and off at 8pm
{
static unsigned long nexttoggle=now();
static boolean state=false;
int cycle=nexttoggle-now();
ReefAngel.Relay.Set(Port5,state);
ReefAngel.Relay.Set(Port6,!ReefAngel.Relay.Status(Port5));
if (cycle<0)
{
nexttoggle+=random(960,1020);//tunzes on for 15-16 mins
state=!state;
}
if (cycle<10)//10 sec overlap
{
ReefAngel.Relay.On(Port5);
ReefAngel.Relay.On(Port6);
}
}
else
{
ReefAngel.Relay.Off(Port5);
ReefAngel.Relay.Off(Port6);
}

////// Place your custom code above here

Any Advice would be appreciated.

lnevo · Post by **lnevo** » Sat Aug 03, 2013 7:53 am

You are using it incorrectly. Please post your original full code and I'll fix it.

lnevo · Post by **lnevo** » Sat Aug 03, 2013 8:04 am

All you need is this:

Code: Select all

static unsigned long lastATOCheck=millis();
ReefAngel.ReverseATOLow();

if (ReefAngel.LowATO.IsActive()) lastATOCheck=millis();
if (ReefAngel.LowATO.IsActive() && (millis()-lastATOCheck>2000)) ReefAngel.Relay.RelayMaskOff&=~(Port8Bit | Port7Bit | Port1Bit);
if ( (hour()>=8 && hour()<20))//wavemakers on at 8am and off at 8pm
{
static unsigned long nexttoggle=now();
static boolean state=false;
int cycle=nexttoggle-now();
ReefAngel.Relay.Set(Port5,state);
ReefAngel.Relay.Set(Port6,!ReefAngel.Relay.Status(Port5));
if (cycle<0)
{
nexttoggle+=random(960,1020);//tunzes on for 15-16 mins 
state=!state;
}
if (cycle<10)//10 sec overlap
{
ReefAngel.Relay.On(Port5);
ReefAngel.Relay.On(Port6);
}
}
else
{
ReefAngel.Relay.Off(Port5);
ReefAngel.Relay.Off(Port6);
}

Seagals · Post by **Seagals** » Sat Aug 03, 2013 11:02 am

Thanks Inevo, I was able to successfully upload it but the portal still shows a red light on both LW and HW ports - I checked the portal over a duration of several hours figuring the portal needed time to see it but still red.

Here is my entire code If you wouldn't mind please take a look at my code and perhaps lmk where I went wrong thanks.

#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <ReefAngel.h>

////// Place global variable code below here
#include <avr/pgmspace.h>
prog_char menu0_label[] PROGMEM = "Feeding";
prog_char menu1_label[] PROGMEM = "Water Change";
prog_char menu2_label[] PROGMEM = "ATO Clear";
prog_char menu3_label[] PROGMEM = "Overheat Clear";
prog_char menu4_label[] PROGMEM = "PH Calibration";
prog_char menu5_label[] PROGMEM = "Version";
prog_char menu6_label[] PROGMEM = "Clear Low Water";
PROGMEM const char *menu_items[] = {
menu0_label, menu1_label, menu2_label, menu3_label, menu4_label, menu5_label, menu6_label };

void MenuEntry1()
{
ReefAngel.FeedingModeStart();

}
void MenuEntry2()
{
ReefAngel.WaterChangeModeStart();

}
void MenuEntry3()
{
ReefAngel.ATOClear();
ReefAngel.DisplayMenuEntry("Clear ATO Timeout");
}
void MenuEntry4()
{
ReefAngel.OverheatClear();
ReefAngel.DisplayMenuEntry("Clear Overheat");
}
void MenuEntry5()
{
ReefAngel.SetupCalibratePH();
ReefAngel.DisplayedMenu = ALT_SCREEN_MODE;

}
void MenuEntry6()
{
ReefAngel.DisplayVersion();

}
void MenuEntry7()
{
ReefAngel.Relay.RelayMaskOff=255;
}

////// Place global variable code above here

void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port1Bit | Port5Bit | Port6Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port1Bit | Port7Bit | Port8Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = Port2Bit | Port3Bit | Port4Bit;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port1Bit | Port2Bit | Port3Bit | Port4Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;
// Set the Overheat temperature setting
InternalMemory.OverheatTemp_write( 850 );

// Ports that are always on
ReefAngel.Relay.On( Port7 );//Chiller
ReefAngel.Relay.On( Port8 );//Main pump

////// Place additional initialization code below here
ReefAngel.InitMenu(pgm_read_word(&(menu_items[0])),SIZE(menu_items));

////// Place additional initialization code above here
}

void loop()
{
ReefAngel.StandardLights( Port1,8,0,21,0 );//Protein skimmer
ReefAngel.StandardLights( Port2,9,0,21,30 );
ReefAngel.StandardLights( Port3,11,0,20,30 );
ReefAngel.StandardLights( Port4,9,0,21,30 );
ReefAngel.Wavemaker( Port5,960 );
ReefAngel.Relay.Set( Port6, !ReefAngel.Relay.Status( Port5 ) );
ReefAngel.PWM.SetDaylight( PWMSlope(11,0,20,25,5,70,120,5) );
ReefAngel.PWM.SetActinic( PWMSlope(9,0,21,30,15,88,60,20) );
////// Place your custom code below here
static unsigned long lastATOCheck=millis();

ReefAngel.ReverseATOLow();

if (ReefAngel.LowATO.IsActive()) lastATOCheck=millis();
if (ReefAngel.LowATO.IsActive() && (millis()-lastATOCheck>2000)) ReefAngel.Relay.RelayMaskOff&=~(Port8Bit | Port7Bit | Port1Bit);
if ( (hour()>=8 && hour()<20))//wavemakers on at 8am and off at 8pm
{
static unsigned long nexttoggle=now();
static boolean state=false;
int cycle=nexttoggle-now();
ReefAngel.Relay.Set(Port5,state);
ReefAngel.Relay.Set(Port6,!ReefAngel.Relay.Status(Port5));
if (cycle<0)
{
nexttoggle+=random(960,1020);//tunzes on for 15-16 mins
state=!state;
}
if (cycle<10)//10 sec overlap
{
ReefAngel.Relay.On(Port5);
ReefAngel.Relay.On(Port6);
}
}
else
{
ReefAngel.Relay.Off(Port5);
ReefAngel.Relay.Off(Port6);
}

////// Place your custom code above here

// This should always be the last line
ReefAngel.Portal( "Seagals" );
ReefAngel.ShowInterface();
}

lnevo · Post by **lnevo** » Sat Aug 03, 2013 12:23 pm

This is where feature.txt update may be needed.

Roberto the info was in the pull request:

https://github.com/reefangel/Libraries/pull/89

Take a look at that link and make sure those two lines are in your feature.txt

Seagals · Post by **Seagals** » Sat Aug 03, 2013 5:37 pm

This is what I found in my library - not sure is this is what you were referring too. It states ATO_LOW_REVERSE - Appreciate your assistance - coding is new to me and after 50+ yrs trying to learn a new language .

LMK - if this helps clarify the issue thanks

/*
* Copyright 2010 Reef Angel / Roberto Imai
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/

/*
* Updated by: Curt Binder
* Updates Released under Apache License, Version 2.0
*/

#ifndef __RA_ATO_H__
#define __RA_ATO_H__

#include <Globals.h>

/*
Auto Top Off Class
*/

class RA_ATOClass
{
public:
RA_ATOClass();
virtual bool IsActive() = 0;
inline bool IsTopping() { return topping; }
#ifdef ENABLE_ATO_LOGGING
virtual void StartTopping(bool fHighAto = false);
virtual void StopTopping(bool fHighAto = false);
#else
inline void StartTopping() { topping = true; }
inline void StopTopping() { topping = false; }
#endif // ENABLE_ATO_LOGGING
unsigned long Timer;
#ifdef REEFTOUCHDISPLAY
bool activestatus;
void inline SetActive(bool status) { activestatus=status; }
#endif // REEFTOUCHDISPLAY

private:
bool topping;
};

class RA_ATOHighClass : public RA_ATOClass
{
public:
#ifdef ATO_HIGH_REVERSE
#ifdef REEFTOUCHDISPLAY
inline bool IsActive() { return !activestatus; }
#else // REEFTOUCHDISPLAY
inline bool IsActive() { return digitalRead(highATOPin); }
#endif // REEFTOUCHDISPLAY
#else // ATO_HIGH_REVERSE
#ifdef REEFTOUCHDISPLAY
inline bool IsActive() { return activestatus; }
#else // REEFTOUCHDISPLAY
inline bool IsActive() { return !digitalRead(highATOPin); }
#endif // REEFTOUCHDISPLAY
#endif // ATO_HIGH_REVERSE
};

class RA_ATOLowClass : public RA_ATOClass
{
public:
#ifdef ATO_LOW_REVERSE
#ifdef REEFTOUCHDISPLAY
inline bool IsActive() { return !activestatus; }
#else // REEFTOUCHDISPLAY
inline bool IsActive() { return digitalRead(lowATOPin); }
#endif // REEFTOUCHDISPLAY
#else // ATO_LOW_REVERSE
#ifdef REEFTOUCHDISPLAY
inline bool IsActive() { return activestatus; }
#else // REEFTOUCHDISPLAY
inline bool IsActive() { return !digitalRead(lowATOPin); }
#endif // REEFTOUCHDISPLAY
#endif // ATO_LOW_REVERSE
};

#if defined WATERLEVELEXPANSION
class RA_ATOWLClass : public RA_ATOClass
{
public:
inline bool IsActive() { return false; }
};
#endif // WATERLEVELEXPANSION

#endif // __RA_ATO_H__

lnevo · Post by **lnevo** » Sat Aug 03, 2013 5:46 pm

I wrote that code and am using it as well. You must be missing the feature.txt line i posted.

You should see a message about it when you compile. If not then its going to do nothing.

lnevo · Post by **lnevo** » Sat Aug 03, 2013 5:47 pm

lnevo wrote:This is where feature.txt update may be needed.

Roberto the info was in the pull request:

https://github.com/reefangel/Libraries/pull/89

Take a look at that link and make sure those two lines are in your feature.txt

Seagals · Post by **Seagals** » Sun Aug 04, 2013 7:19 am

Inevo - I may have misunderstood was your last email directed towards Roberto? or me? because at this point I did all I know how to do with my limited knowledge

lnevo · Post by **lnevo** » Sun Aug 04, 2013 9:26 am

Its directed to both. Find the feature.txt file and add the two lines. Mentioned in the link posted. Re-compile and you should see the "feature" listed when you compile.

Seagals · Post by **Seagals** » Sun Aug 04, 2013 12:22 pm

Thanks but thing is I am kinda lost at this point what I found yesterday was all I have and will need Roberto's input.

Roberto - when you have a moment please offer me some help - thanks

rimai · Post by **rimai** » Sun Aug 04, 2013 12:26 pm

I'm not so sure what you are trying to accomplish.
Are you trying to invert the colors from red to green?
Is that it?

lnevo · Post by **lnevo** » Sun Aug 04, 2013 12:52 pm

Ok nevermind. Just put this in your code

#define ATO_LOW_REVERSE

That should trigger it manually.

rimai · Post by **rimai** » Sun Aug 04, 2013 1:25 pm

Using defines on INO code does not get the feature included...
It would be too easy if it worked this way

That's this exact reason why I had to come up with the auto-selection of features based on the feature.txt file.

lnevo · Post by **lnevo** » Sun Aug 04, 2013 1:28 pm

That sucks

Seagals · Post by **Seagals** » Sun Aug 04, 2013 1:42 pm

thanks guys but if its to much trouble don't worry about it - I would have liked the light on the portal to be green on my low water cut off indicating (to me at least) that all was ok. but it sounds like its to much trouble - so lets just leave it as is - thanks

lnevo · Post by **lnevo** » Sun Aug 04, 2013 2:25 pm

Just find the feature.txt file in your Documents\Arduino folder. You just need to add two lines to it.

lnevo · Post by **lnevo** » Sun Aug 04, 2013 2:25 pm

I think it should be in updates folder?

Seagals · Post by **Seagals** » Sun Aug 04, 2013 3:28 pm

lnevo · Post by **lnevo** » Sun Aug 04, 2013 4:16 pm

Thats not it. You are looking for a file not folder called feature.txt

You want to add these two lines:

ATO_LOW_REVERSE,ReefAngel.ReverseATOLow,Reverse ATO Low
ATO_HIGH_REVERSE,ReefAngel.ReverseATOHigh,Reverse ATO High

lnevo · Post by **lnevo** » Sun Aug 04, 2013 4:22 pm

The second one you showed "features"

Its not a folder but contents are correct.

Add the two lines i gave you above.

Seagals · Post by **Seagals** » Mon Aug 05, 2013 1:26 pm

YES it worked!!!! Thank you - It makes so much more sense for the light to be green meaning its safe - that's awesome thanks

Reef Angel Forum

ATO signal on Portal

ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Re: ATO signal on Portal

Login • Register