Page 1 of 1

Serious Bug in ph calibration code

Posted: Sun Aug 02, 2015 12:21 pm
by dedvalson
Hi,

There is a bug in the current pH expansion calibration code. If you look at ReefAngel_1.5_LCD.h you see:

Code: Select all

        InternalMemory.PHMin_write(PHExpMin);
        InternalMemory.PHMax_write(PHExpMax);
What should be there is:

Code: Select all

        InternalMemory.PHExpMin_write(PHExpMin);
        InternalMemory.PHExpMax_write(PHExpMax);
This bug causes the main ph values to be overwritten when you try to calibrate the ph expansion.

Don

Re: Serious Bug in ph calibration code

Posted: Sun Aug 02, 2015 7:43 pm
by rimai
Good catch :)
Thanks for the contribution!!