dosometric pump issue: start ok, no stop

[mantu]

hello,
i have a strange issue with dosometric pump functions.
dosing pump starts but never stops!
i use lastest curt library and i call init function only one time.
(same problem happened to another user for this reason)
i have tryed this 2 codes with no luck:
DosingPump1(Port3) // i have setup start time and duration in setup
menu of RA
DosingPump(Port3,4,22,10,10) // DosingPump(byte DPRelay, byte DPTimer,
byte OnHour, byte OnMinute, byte RunTime) timer 4 may be free
any suggestions? even for debug...
thanks!

[rimai]

Hey Mantu,

I tested it with the same function you mentioned and it worked just fine.
Attached is the code I used for testing.

Roberto.

[mantu]

tested your code... i missed one information.... i'm using dosing pump on relay expansion module so my code is:

DosingPump(Box1_Port1,4,22,10,10)
this doesn't work (on ok but no off).... but if i use
DosingPump(Port1,4,22,10,10)
it works!

any suggestion?
tnx!

[binder]

Do you have the Relay Expansion feature enabled in the code? This can be found under the Features tab inside RAGen OR if you are not using RAGen, make sure you have this line uncommented/enabled inside your ReefAngel_Features.h file (located in the ReefAngel_Features folder)

Code: Select all

#define RelayExp

This will enable the functionality of the expansion relays and should correct any problems you may have if the other code works fine for you.

curt

[mantu]

Do you have the Relay Expansion feature enabled in the code? This can be found under the Features tab inside RAGen OR if you are not using RAGen, make sure you have this line uncommented/enabled inside your ReefAngel_Features.h file (located in the ReefAngel_Features folder)

Code: Select all

#define RelayExp

This will enable the functionality of the expansion relays and should correct any problems you may have if the other code works fine for you.

curt

yes curt,
this is my line on features.h


/*
This will enable code for multiple expansion modules.

Approximately 530 bytes to have this feature
*/
#define RelayExp

i think that without this line uncommented the relay expansion wouldn't also power on..

[binder]

Ok. I'm not quite sure what to say then. I'm looking at the code and everything appears to be ok in it. The only thing that I could suggest trying is to change Box1_Port1 to be just 11 and see if that works.

Code: Select all

ReefAngel.DosingPump(11,4,22,10,10);  // first port on relay box, timer 4, on at 22:10 run for 10s

I doubt that using 11 will make a difference because Box1_Port1 is just another name for it. Maybe there is something else going on? I cannot test because I do not have an expansion box.

curt

[mantu]

Ok. I'm not quite sure what to say then. I'm looking at the code and everything appears to be ok in it. The only thing that I could suggest trying is to change Box1_Port1 to be just 11 and see if that works.

Code: Select all

ReefAngel.DosingPump(11,4,22,10,10);  // first port on relay box, timer 4, on at 22:10 run for 10s

I doubt that using 11 will make a difference because Box1_Port1 is just another name for it. Maybe there is something else going on? I cannot test because I do not have an expansion box.

curt

i tryed with Box1_Port8 and also with 18.... but no luck... issue not resolved!

here is my features.h, pde is the roberto's one with relay name changed...

Code: Select all

/*
 * Copyright 2010 / Curt Binder
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

#ifndef __REEFANGEL_FEATURES_H__
#define __REEFANGEL_FEATURES_H__

/*
This contains all the defines for enabling/disabling features with the controller software.

This file can be AutoGenerated by using the RAGenFeatures program.
*/

/*
If your sketch/compile size is getting too big or if you are running out of RAM and having bizarre events
happen with the controller, you may want to not display the graphics on screen which can save some memory.
Just comment out the next line to prevent any graphics from being displayed, you will have text only screens
during water changes and feeding modes.

Approximately 346 bytes to have this feature
*/
#define DisplayImages  // do we display the graphics for feeding or water change mode

/*
The next line is for displaying the setup screens to configure the values for the Feeding Mode timer and
the LCD shutoff timer.  The defaults are fine, BUT if you would like to have the ability to change them
from the setup screen, uncomment the next line.  This will increase the file size.  If you do not plan
to change these values often (or at all), keep the next line commented out.

Approximately 362 bytes to have this feature
*/
//#define SetupExtras  // feeding mode & screensaver timeout setup. ACTIVATE WITH CAUTION

/*
Since we may or may not need to always configure the Wavemakers, give the option to
turn off the setup screens to keep the compile size down.  You can still use the Wavemakers,
you just will not have the setup screen available to configure the values.  You will have to manually set
the intervals inside the Sketch (hardcode or have it read from memory if the memory contains the correct values).

Approximately 378 bytes to have WavemakerSetup
*/
//#define WavemakerSetup

/*
These next two options are for the Dosing Pumps.  They operate differently, so read carefully to determine
what option you want.

DosingPumpSetup
  Allows for specifying a specific time in which you want the dosing pump to turn on and run for.
  It only runs once per day and for the specified duration/run time.
  This feature will allow you to configure the start time and run time from the setup screens.

DosingPumpIntervalSetup
  Allows for specifying a minute interval that you would like the pump to turn on and run for.
  It runs every minute interval for the entire day.  It's start time is based off of midnight of the current day.
  If you specified a 60 minute interval, it will run for the specified duration every hour.
  This feature will allow you to configure the minute interval and run time from the setup screens.

Both options use the same Run Time that is stored in memory, so you will only be able to use one or the other
if you plan on configuring the run time from the setup screens.  If you use the hard coded values, you won't
need to use these options and you can use separate run times.

You can still use the DosingPump and DosingPumpInterval functions without these options,
you will just need to have the memory already be set or specifically set the values in the PDE file.
You just will not be able to change the values from the controller's setup screen.

Approximately 2000 bytes to have DosingPumpSetup
Approximately 368 bytes to have DosingPumpIntervalSetup
*/
#define DosingPumpSetup
//#define DosingPumpIntervalSetup


/*
Overheat Temperature is fairly constant.  This value will most likely not get changed very often (if ever).
The default value is set to 150.0F.  Once this value is reached, all the lights will get shutoff.  If you
would like the ability to change this value from the menus, uncomment the next line.  Otherwise you will have
to hardcode the value in the ShowInterface Function

Approximately 156 bytes to have this feature
*/
#define OverheatSetup

/*
The ability to set the Date & Time on the controller is controlled by this next line.  This line will add
in a Date / Time Setup menu entry which will allow you to set the date & time on the controller easily.
Comment the next line to remove this ability.

Approximately 1984 bytes to have this feature
*/
//#define DateTimeSetup

/*
If you do not want to have a Version menu entry to see what version of the software is on the controller,
then you will want to comment out the next line

Approximately 144 bytes to have this feature
*/
#define VersionMenu

/*
If you do not use any of the ATO features in your setup, you can comment out this next line to remove
the ATO set and clear menu items.

Approximately 900 bytes to have this feature (and without SetupExtras)

When this or SetupExtras are defined, the Timeouts menu is included.
Timeouts menu requires approximately 710 bytes
This feature requires approximately 190 bytes if SetupExtras is defined
*/
#define ATOSetup

/*
This item will remove all lighting functionality from the controller.  It is the equivalent to
commenting out MetalHalideSetup, StandardLightSetup, DisplayLEDPWM
This will OVERRIDE any of the other defines.  So use caution when enabling this feature.

Approximately 2796 bytes to have this feature
*/
//#define RemoveAllLights

/*
If you do not use metal halides and do not wish to have any of the setup screens on your controller,
you can comment out the next line to remove the Metal Halide Setup and Metal Halide Delay

Approximately 258 bytes to have this feature
*/
#define MetalHalideSetup

/*
If you do not use standard lights and do not wish to have the setup screens on your controller,
you can comment out the next line to remove the Standard Lights Setup

Approximately 90 bytes to have this feature
*/
//#define StandardLightSetup

/*
If you want to use the old way of reading the temp sensor which is always reading the value in
and not performing any sanity check, then you will want to uncomment this next line.

Otherwise, you will use the new way to handle the temperatures.  The value is read in and then
compared to the existing value.  If the difference between the 2 values is less than MAX_TEMP_SWING
or the temperature is 0 then the temperature is allowed to be updated, otherwise it is not updated.
MAX_TEMP_SWING is currently set to 50, which is 5.0 F.  This prevents any temporary large fluctations
in temperatures.  Also, there should not be more than a 5.0 F degree fluctation in 1 second.
*/
//#define DirectTempSensor

/*
Do we save the relay state before we enter Feeding Mode or Water Change Mode?

Comment out the next line to not save the state and always force specific ports to be turned off and then
back on again after we exit the mode.  This can turn on some ports that were not already on.  This
is also how the controller originally works.

Currently untested.
*/
#define SaveRelayState

/*
If you have the wifi module for your controller and wish to use it, you must uncomment this next line
to utilize the built-in webserver for the controller.
*/
//#define wifi

/*
This next line will control the displaying of all LED PWM related items.  The items it controls are:

DP & AP displaying on main screen
LED PWM Setup screen

So, if you do not use LED PWM's at all and do not wish to display anything related to it, comment out
the next line and all that stuff will be removed.

Approximately 720 bytes to have this feature
*/
//#define DisplayLEDPWM

/*
This next line will allow you to use the ATO switches independently from each other.  You can specify
separate ports to control, separate timeouts and separate hourly intervals.
If you have this defined, you cannot use both switches together like originally intended.
The setup screens will show configurations for both switches.

Approximately 454 bytes to have this feature
*/
#define SingleATOSetup

/*
If this next line is uncommented, you must include the following lines in
the PDE file at the top above all other include statements:
#include <ReefAngel_Colors.h>
#include <ReefAngel_CustomColors.h>
*/
//#define COLORS_PDE

/*
This will enable code for multiple expansion modules.

Approximately 530 bytes to have this feature
*/
#define RelayExp

#endif  // __REEFANGEL_FEATURES_H__

[binder]

Oh my goodness. I looked at the underlying code more closely and I found a bug relating to the expansion code in my Development libraries. When I was updating the relay expansion code, I got a bitSet and a bitClear confused and used the wrong function.

To fix the problem, the easiest solution is to open up the file ReefAngel_Relay/ReefAngel_Relay.cpp. Look for this function:

Code: Select all

void ReefAngel_RelayClass::Off(byte ID)
{
    if ( ID < 9 ) bitClear(RelayData, ID-1);
#ifdef RelayExp
	if ( (ID > 10) && (ID < 89) )
	{
		byte EID = byte(ID/10);
		bitSet(RelayDataE[EID-1],(ID%10)-1);  // Change this line to bitClear
	}
#endif  // RelayExp
}

Change the line bitSet(RelayDataE[EID-1],(ID%10)-1); to bitClear(RelayDataE[EID-1],(ID%10)-1);
Then save and upload your code to the controller. That should take care of things for you.

Thanks for catching this bug.

Curt

[mantu]

Oh my goodness. I looked at the underlying code more closely and I found a bug relating to the expansion code in my Development libraries. When I was updating the relay expansion code, I got a bitSet and a bitClear confused and used the wrong function.

To fix the problem, the easiest solution is to open up the file ReefAngel_Relay/ReefAngel_Relay.cpp. Look for this function:

Change the line bitSet(RelayDataE[EID-1],(ID%10)-1); to bitClear(RelayDataE[EID-1],(ID%10)-1);
Then save and upload your code to the controller. That should take care of things for you.

Thanks for catching this bug.

Curt

Thanks you too for the super fast solution! n1!

Lorenzo