Problem with v. 0.8.5.15

[lukeluke]

Curt know

This is my problem with the new versione.

SingleATOHigh the float position is inverted (you must rotate it before update)

SingleATOTimeout don't work.... i try to put the internal memory value to 60 or 1 .... but nothing, the pump is never stopped.

In the ReefAngel.cpp in the SingleATO void

i see this change : if ( (iSafeTop < (byteHrInterval * 60)) && (iLastTop >= 0) )

and i try to set like the old version : if ( iSafeTop < (byteHrInterval * 60) )

but nothing...

This post is for Curt and for alert the other people

[binder]

I figured out what is going on. The function works but the timeout does not. So if something fails the port will not shutoff currently. I'm working on a fix for it right now. Sorry if this has caused any inconvenience.

curt

[binder]

Ok. I figured out the problem. I've got a fix for it. I'm going to put it in .16 but before I release .16 I'm going to try to get some of the wdt stuff added in too.

For those who are anxious, here's the code fix. Inside the SingleATO function in ReefAngel.cpp, there is a line that looks like this:

Code: Select all

    if ( ato->IsActive() )
    {
        if ( bCanRun )
        {

It needs to be changed to this:

Code: Select all

    if ( ato->IsActive() )
    {
        if ( (! ato->IsTopping()) && bCanRun )
        {

I added in the "if not topping" check. Otherwise, without this check the timeout is being reset all the time and it never starts a countdown. So the timeout exceeded check is never true.

curt

[lukeluke]

i try it and it's ok