changing wavemaker time on controller makes ato turn on?

[adamgrif]

Hey Roberto I was wondering if you could help me... i uploaded 1.0.1 to controller... when i change wavemaker time in controller it made my ato pump turn on? this is the code. The only thing that i added was the line that makes wavemaker pumps work opposite of each other. did i put it in wrong spot? thanks for your help
#include <ReefAngel_Features.h>
#include <Globals.h>
#include <RA_Wifi.h>
#include <Wire.h>
#include <OneWire.h>
#include <Time.h>
#include <DS1307RTC.h>
#include <InternalEEPROM.h>
#include <RA_NokiaLCD.h>
#include <RA_ATO.h>
#include <RA_Joystick.h>
#include <LED.h>
#include <RA_TempSensor.h>
#include <Relay.h>
#include <RA_PWM.h>
#include <Timer.h>
#include <Memory.h>
#include <InternalEEPROM.h>
#include <RA_Colors.h>
#include <RA_CustomColors.h>
#include <Salinity.h>
#include <RF.h>
#include <IO.h>
#include <ORP.h>
#include <AI.h>
#include <ReefAngel.h>

////// Place global variable code below here


////// Place global variable code above here


void setup()
{
// This must be the first line
ReefAngel.Init(); //Initialize controller
ReefAngel.AddStandardMenu(); // Add Standard Menu

// Ports toggled in Feeding Mode
ReefAngel.FeedingModePorts = Port5Bit | Port6Bit | Port8Bit;
// Ports toggled in Water Change Mode
ReefAngel.WaterChangePorts = Port1Bit | Port5Bit | Port6Bit | Port8Bit;
// Ports toggled when Lights On / Off menu entry selected
ReefAngel.LightsOnPorts = Port3Bit | Port4Bit;
// Ports turned off when Overheat temperature exceeded
ReefAngel.OverheatShutoffPorts = Port7Bit;
// Use T1 probe as temperature and overheat functions
ReefAngel.TempProbe = T1_PROBE;
ReefAngel.OverheatProbe = T1_PROBE;


// Ports that are always on
ReefAngel.Relay.On( Port8 );

////// Place additional initialization code below here


////// Place additional initialization code above here
}

void loop()
{
ReefAngel.SingleATOLow( Port1 );
ReefAngel.MoonLights( Port2 );
ReefAngel.DayLights( Port3 );
ReefAngel.ActinicLights( Port4 );
ReefAngel.Wavemaker1( Port5 );
ReefAngel.Wavemaker1( Port6 );
ReefAngel.StandardHeater( Port7 );
////// Place your custom code below here
ReefAngel.Relay.Set(Port6,!ReefAngel.Relay.Status(Port5));

////// Place your custom code above here

// This should always be the last line
ReefAngel.ShowInterface();
}

[rimai]

Does it turn on/off together with Port6?

[adamgrif]

just checked this and no it doesnt turn on or off with port 6. it doesnt turn off at all. right after i change wavemaker time, it just turns on? it even bypasses the singleato low float switch that i have set to timeout after 4 seconds...the only way to stop it is to manually push the singleato low float switch down until the 4 second timeout, then reset ato timeout from controller. then it works fine unless i want to change wavemaker times. was also wanting the ato timeout to shut down the pump untill i reset from controller cause right now it just times out until the float rises up then resets but the red led stays lit on controller. so really the only thing that im reseting on controller is the led. i need it to shutdown the ato pump if it goes more than time selected on controller. do you have code for this?

[rimai]

Can you load the controllertester code and check if the float switch is working as it is supposed to?
It is supposed to be active when it is not floating.

[adamgrif]

thanks for replying so fast...i checked this earlier, but i checked it manually while looking at controller and i see the relay 1 picking and also hear it. not sure what controllertester is... i took float off when it first happened and cleaned it thinking it was sticking but thats not the case. the switch works fine it only does this when i change times on wmaker.

[rimai]

You found a bug
It does indeed happen when you change the wavemaker timer.
Thanks for reporting it
I'll have it patched on the next update.
But in the mean time, change this:

Code: Select all

ReefAngel.Wavemaker1( Port6 );

To this:

Code: Select all

ReefAngel.Wavemaker2( Port6 );

This should fix the issue for you.

[adamgrif]

thanks alot ill let you know how it works. other than this the Reef Angel has been awesome! thanks again for replying so fast!!

[adamgrif]

Hey Roberto, I changed the code and it worked. Thanks again. I was wondering if you had any ideas on how to make the ato shutoff completely after it reaches timeout specified. meaning that it will have to be reset from controller in order for it to run again instead of the float switch going up and it resets itself.

[rimai]

Technically, if the timeout happened, the float hasn't reached the top position, right?
Can you give me a scenario where the timeout happens and the float goes up and you don't want to reset itself?

[adamgrif]

hehehe makes sense...scenario doesnt exist. have a good night and thanks again